Patch Detail
Show a patch.
GET /api/1.1/patches/22370/?format=api
{ "id": 22370, "url": "https://patchwork.libcamera.org/api/1.1/patches/22370/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22370/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241216172827.1055088-4-barnabas.pocze@ideasonboard.com>", "date": "2024-12-16T17:28:27", "name": "[libcamera-ci,RFC,v2,4/4] Add job to run lc-compliance on the virtual pipeline handler", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8beb6a2a5a86b3ad04cc7ae894f0f4103b0a5081", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22370/mbox/", "series": [ { "id": 4897, "url": "https://patchwork.libcamera.org/api/1.1/series/4897/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4897", "date": "2024-12-16T17:28:24", "name": "[libcamera-ci,RFC,v2,1/4] Enable `UDMABUF` in the kernel", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4897/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22370/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22370/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF614C32FB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Dec 2024 17:28:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3D4A67F92;\n\tMon, 16 Dec 2024 18:28:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D388267F7D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Dec 2024 18:28:31 +0100 (CET)", "from pb-laptop.local (185.221.140.157.nat.pool.zt.hu\n\t[185.221.140.157])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 401B0675\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Dec 2024 18:27:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SktQxWMt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734370075;\n\tbh=P3YUOcPU7wQ3BmBT8SXodHqOLy92Olu6970g9utG01Y=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=SktQxWMtxsx+SaSwHyKnQjFVQ5alsnUU+CxU3R9Tu8Z3eyPLRgJi8L1BALRrE9ue8\n\tYG5HGpDIlwyITppkMKRrOdVkQofkjbC7VFDbGuS/6zxVeELLJQsiCIPNdsrLFZWsY6\n\tVg3xCDsqhDEN0H8DDbRRxokyuvJdZ4xSZ84BrDk0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [RFC PATCH v2 4/4] Add job to run lc-compliance on\n\tthe virtual pipeline handler", "Date": "Mon, 16 Dec 2024 18:28:27 +0100", "Message-ID": "<20241216172827.1055088-4-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20241216172827.1055088-1-barnabas.pocze@ideasonboard.com>", "References": "<20241216172827.1055088-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a new job named `lc-compliance:virtual` that uses the\nbuild artifacts created by the `build-package:debug` job\non amd64 to run `lc-compliance` on the \"Virtual0\" camera\nin a virtual machine.\n\nThe `force_fallback_for=gtest` option is needed because `cpp_debustl`\nmakes ABI incompatible changes in the STL containers, so googletest\nalso needs to be compiled with these changes.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n\nChanges in v2:\n * publish lc-compliance results to gitlab\n * add and use script to install libcamera binary package\n\n---\n .gitlab-ci/test-lc-compliance.sh | 37 +++++++++++++++++++++++++++++++\n .gitlab-ci/unpackage-libcamera.sh | 17 ++++++++++++++\n gitlab-ci.yml | 24 +++++++++++++++++++-\n 3 files changed, 77 insertions(+), 1 deletion(-)\n create mode 100755 .gitlab-ci/test-lc-compliance.sh\n create mode 100755 .gitlab-ci/unpackage-libcamera.sh\n\n--\n2.47.1", "diff": "diff --git a/.gitlab-ci/test-lc-compliance.sh b/.gitlab-ci/test-lc-compliance.sh\nnew file mode 100755\nindex 0000000..a927f1d\n--- /dev/null\n+++ b/.gitlab-ci/test-lc-compliance.sh\n@@ -0,0 +1,37 @@\n+#!/bin/bash\n+\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# SPDX-FileCopyrightText: © 2024 Google Inc.\n+\n+set -e\n+\n+source \"$(dirname \"$0\")/lib.sh\"\n+\n+libcamera_compliance() {\n+\techo \"Running libcamera compliance tests in a qemu VM\"\n+\n+\tvirtme-ng \\\n+\t\t--verbose \\\n+\t\t--skip-modules \\\n+\t\t--force-9p \\\n+\t\t--rwdir \"$PWD/build\" \\\n+\t\t--run /opt/linux/bzImage \\\n+\t\t--exec \"\\\n+\t\t\tLIBCAMERA_LOG_LEVELS=*:DEBUG \\\n+\t\t\tASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 \\\n+\t\t\tUBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 \\\n+\t\t\tGTEST_OUTPUT=xml:./build/lc-compliance-report.xml \\\n+\t\t\tlc-compliance -c Virtual0; \\\n+\t\t\techo \\\\\\$? > ./build/.test-status \\\n+\t\t\"\n+\n+\tlocal status=$(cat build/.test-status)\n+\techo \"Test result exit state: $status\"\n+\trm build/.test-status\n+\n+\tif [[ $status != 0 ]] ; then\n+\t\texit $status\n+\tfi\n+}\n+\n+run libcamera_compliance\ndiff --git a/.gitlab-ci/unpackage-libcamera.sh b/.gitlab-ci/unpackage-libcamera.sh\nnew file mode 100755\nindex 0000000..9eb3192\n--- /dev/null\n+++ b/.gitlab-ci/unpackage-libcamera.sh\n@@ -0,0 +1,17 @@\n+#!/bin/bash\n+\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# SPDX-FileCopyrightText: © 2024 Google Inc.\n+\n+set -e\n+\n+source \"$(dirname \"$0\")/lib.sh\"\n+\n+libcamera_unpackage() {\n+\techo \"Unpackage libcamera binaries\"\n+\n+\ttar -xvf libcamera-${CI_COMMIT_SHA}.tar.xz -C /\n+\tldconfig -v\n+}\n+\n+run libcamera_unpackage\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex 0a3eab3..8ea1d12 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -328,11 +328,13 @@ build-package:debug:\n BUILD_TYPE: debug\n MESON_OPTIONS: >-\n -D auto_features=disabled\n+ -D lc-compliance=enabled\n -D test=false\n -D v4l2=false\n -D b_sanitize=address,undefined\n -D cpp_debugstl=true\n- -D pipelines=[]\n+ -D pipelines=['virtual']\n+ -D force_fallback_for=['gtest']\n parallel:\n matrix:\n - ARCH: amd64\n@@ -440,3 +442,23 @@ test-unit:\n # artifacts:\n # reports:\n # junit: build/meson-logs/testlog.junit.xml\n+\n+lc-compliance:virtual:\n+ extends:\n+ - .fdo.distribution-image@debian\n+ - .libcamera-ci.debian:12\n+ - .libcamera-ci.scripts\n+ stage: test\n+ needs:\n+ - job: build-package:debug\n+ parallel:\n+ matrix:\n+ - ARCH: amd64\n+ tags:\n+ - kvm\n+ script:\n+ - $CI_PROJECT_DIR/.gitlab-ci/unpackage-libcamera.sh\n+ - $CI_PROJECT_DIR/.gitlab-ci/test-lc-compliance.sh\n+ artifacts:\n+ reports:\n+ junit: build/lc-compliance-report.xml\n", "prefixes": [ "libcamera-ci", "RFC", "v2", "4/4" ] }