Patch Detail
Show a patch.
GET /api/1.1/patches/22313/?format=api
{ "id": 22313, "url": "https://patchwork.libcamera.org/api/1.1/patches/22313/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22313/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241215181835.802589-1-pobrn@protonmail.com>", "date": "2024-12-15T18:18:38", "name": "[v1,1/2] gstreamer: allocator: Recognize FrameBufferAllocator errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e4c9ce980ae14abb09b15adca8b870253c4b3a47", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22313/mbox/", "series": [ { "id": 4883, "url": "https://patchwork.libcamera.org/api/1.1/series/4883/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4883", "date": "2024-12-15T18:18:38", "name": "[v1,1/2] gstreamer: allocator: Recognize FrameBufferAllocator errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4883/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22313/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22313/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD8BBC32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 15 Dec 2024 18:18:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDB3D67F07;\n\tSun, 15 Dec 2024 19:18:45 +0100 (CET)", "from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D08B67EEE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Dec 2024 19:18:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"BsDbmJRU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734286723; x=1734545923;\n\tbh=aS3YEHrQ2tHzTb2MdljxMSdODBdI9/WQyI8TYfLOwVg=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=BsDbmJRUknN5Cwp7tDhY+9LL5PWKya8ZNAy2+Im5+TexakKLJcVwXn9SDj1iMUprd\n\tw64UKbWt2aAjDbu/ZvyKAGo9IPLtczj7iE9nJNHcERLvolg3zunG8bPc9t1LaOvYtf\n\tR0UhROYignqi6w4K2NUH5ln18N23/FSoMWMsFknWxcissUNDXL92qx9prOpwueHujy\n\ticGrBkan/RpKg+TFCJF4eFENq+ugFmQtavTCMudKFd1XwnVmf2dvZHSDaLOQLBuwtJ\n\tB3fM0gYJ8v9DnO3Y+2i8IQAYXFaOY7TfGg0TCLl+IWXi2qne0I1DqDTDx/nrW1pozC\n\t+OZjEBRHjNSZQ==", "Date": "Sun, 15 Dec 2024 18:18:38 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v1 1/2] gstreamer: allocator: Recognize FrameBufferAllocator\n\terrors", "Message-ID": "<20241215181835.802589-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "0ab074a75be0aa0af3e650caf95726c3373ca8fe", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`FrameBufferAllocator::allocate()` might return a negative error code,\nbut currently this is handled the same way as success. So instead\nof continuing, abort the construction.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex 7e4c904da..b0c84893a 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr<Camera> camera,\n \t\tStream *stream = streamCfg.stream();\n \n \t\tret = self->fb_allocator->allocate(stream);\n-\t\tif (ret == 0)\n+\t\tif (ret <= 0)\n \t\t\treturn nullptr;\n \n \t\tGQueue *pool = g_queue_new();\n", "prefixes": [ "v1", "1/2" ] }