Patch Detail
Show a patch.
GET /api/1.1/patches/22307/?format=api
{ "id": 22307, "url": "https://patchwork.libcamera.org/api/1.1/patches/22307/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22307/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241213094602.2083174-3-naush@raspberrypi.com>", "date": "2024-12-13T09:38:25", "name": "[2/6] ipa: rpi: Add erase()/eraseLocked() to RPiController::Metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e08b7914fe5f4944e2a942f354c3d9ae1064c154", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22307/mbox/", "series": [ { "id": 4881, "url": "https://patchwork.libcamera.org/api/1.1/series/4881/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4881", "date": "2024-12-13T09:38:23", "name": "Raspberry Pi: Various changes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4881/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22307/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22307/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67536C32F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Dec 2024 09:46:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61BD067EE5;\n\tFri, 13 Dec 2024 10:46:13 +0100 (CET)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA33167EE0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Dec 2024 10:46:09 +0100 (CET)", "by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-3862f11a13dso139003f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Dec 2024 01:46:09 -0800 (PST)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4362557c502sm43989105e9.11.2024.12.13.01.46.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Dec 2024 01:46:08 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"YkIn3s2E\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1734083169; x=1734687969;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=aYx9VVm9lHIOifsTwg6GTaNC5W+9lzFaSpeOtlhfR2w=;\n\tb=YkIn3s2ElRODURtsrPkTv4uVDUQ1hkKZfS7+PjoyYrLc1IhmPwAbBD+RRN4ibMLnvr\n\tM+KL7VoOihIO9yQ95cbj6xf76/JOPRHGkxaUKCXCucoYdc5po38XQX1ip22/c05u+53e\n\tAw48FL7mjQfqFthYVu9OUsJlEZm6upiigcmYZ4eiCgGrQKLNKYZTva8qJLFLLrIWho/k\n\tlpu8XF6v8/fgx+x+AGQ49P6ri6S+dKF3WWdGx9FcqJ5XQ49KfYRl+ZkxGvuioNlsquIM\n\tgxk7oCkSr/ywquVUCYkrUtsZKTeniCDwkTu+eILrGUXmHe8JhR1YPvgF5olxbpvMQLjI\n\tmG9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1734083169; x=1734687969;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=aYx9VVm9lHIOifsTwg6GTaNC5W+9lzFaSpeOtlhfR2w=;\n\tb=GTmsK5dK5swxi8ZnKEAbGUrGHrM+K20LpMNpDCnrhR0CkD7o4gWao49YgQ3edDLjPU\n\tRxxG6KTUdTWizpWJC9m8qhYBe2roh5/IPvLZFu0sWWUBSJYtVgdqmxs7SeaxhYChHH6r\n\tSTZGqtbHA7IXJucoj/BOiDx+EodazecJ73lPOre0AvHVenwcE5ZxcGiavAocvAdFjOHC\n\tnDfEeI59F7ai0/J3dAayRfSE15tlb7v0cSkMpAUOfMKGT5U6v9ECkEZOo5E6gSZJEu44\n\tio43w2Q0PlwasGroPhishqGWBFDdjx/gRD55G+ZFxG0EcTanNJAs8czmHnveCIefZmvV\n\tdxRQ==", "X-Gm-Message-State": "AOJu0Yy98XrhNhQcPecljsbEI7sHBKJfsNTeslRaeaNFoyH5A4Wb8dv4\n\tpre7uSl4nxvo3cDciUMo2qfD/P0TZ5oQvppbCikzWXZcrzKPhqt4z/PaYLw/t5Q9ZObFGL4Pgiv\n\tu", "X-Gm-Gg": "ASbGnctNOXWcoe85GaR2qpaayMqPpBlMWADKb1wNPP1BufH6BEIYlcUUvG3H0XyhEiZ\n\t4E3+4bZ4kiKeSJmwrlT2hqZSoVPg1eDZJ/tIptkHL9IOrLIqqS78tp9KZHaY1z5Igky8UhN6UgD\n\tzOU2I14U5nJD9pywJdYSOgcY/8X44PcXYdH5YihrIUEWgsaWPAaxPeIfyJngusgL+javfSzfPUe\n\tLFAYln8bRm7zUB/b6oeEbKtrc1XFXsBxHl7w5VnoF060YOOobpA6pdyXDQ/IX0Qa3+XLRyMujXM", "X-Google-Smtp-Source": "AGHT+IEPzU2zUo1JcPv+W5s1fdtrNwUd+bWAyHLTS+wQkrekyW/XNjscNts29On9f7q39ZVIt63HyQ==", "X-Received": "by 2002:a05:600c:1d1c:b0:434:f335:aa0d with SMTP id\n\t5b1f17b1804b1-4362aa108d8mr5450065e9.2.1734083169206; \n\tFri, 13 Dec 2024 01:46:09 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH 2/6] ipa: rpi: Add erase()/eraseLocked() to\n\tRPiController::Metadata", "Date": "Fri, 13 Dec 2024 09:38:25 +0000", "Message-ID": "<20241213094602.2083174-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241213094602.2083174-1-naush@raspberrypi.com>", "References": "<20241213094602.2083174-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "These function erases a key/value pair from the metadata object.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/controller/metadata.h | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/src/ipa/rpi/controller/metadata.h b/src/ipa/rpi/controller/metadata.h\nindex eda4b59bca9a..62e54051f8f4 100644\n--- a/src/ipa/rpi/controller/metadata.h\n+++ b/src/ipa/rpi/controller/metadata.h\n@@ -90,6 +90,12 @@ public:\n \t\tdata_.insert(other.data_.begin(), other.data_.end());\n \t}\n \n+\tvoid erase(std::string const &tag)\n+\t{\n+\t\tstd::scoped_lock lock(mutex_);\n+\t\teraseLocked(tag);\n+\t}\n+\n \ttemplate<typename T>\n \tT *getLocked(std::string const &tag)\n \t{\n@@ -110,6 +116,14 @@ public:\n \t\tdata_[tag] = std::forward<T>(value);\n \t}\n \n+\tvoid eraseLocked(std::string const &tag)\n+\t{\n+\t\tauto it = data_.find(tag);\n+\t\tif (it == data_.end())\n+\t\t\treturn;\n+\t\tdata_.erase(it);\n+\t}\n+\n \t/*\n \t * Note: use of (lowercase) lock and unlock means you can create scoped\n \t * locks with the standard lock classes.\n", "prefixes": [ "2/6" ] }