Patch Detail
Show a patch.
GET /api/1.1/patches/22303/?format=api
{ "id": 22303, "url": "https://patchwork.libcamera.org/api/1.1/patches/22303/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22303/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241212181655.112958-3-barnabas.pocze@ideasonboard.com>", "date": "2024-12-12T18:16:55", "name": "[libcamera-ci,RFC,v1,3/3] Add job to run lc-compliance on the virtual pipeline handler", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f87408ff3c3482abbe974cb2176eedc34fefb495", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22303/mbox/", "series": [ { "id": 4879, "url": "https://patchwork.libcamera.org/api/1.1/series/4879/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4879", "date": "2024-12-12T18:16:53", "name": "[RFC,v1,1/3] Enable `UDMABUF` in the kernel", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4879/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22303/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22303/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A7B9C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Dec 2024 18:17:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E891467EDE;\n\tThu, 12 Dec 2024 19:17:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A46CE67EDA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Dec 2024 19:16:59 +0100 (CET)", "from pb-laptop.local (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF22E316\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Dec 2024 19:16:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eAd5GoMz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734027385;\n\tbh=AwhueC/jxcCrfvDFKEW3e7iX5VorJwlmYijEHVXBma4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=eAd5GoMzemo07LAC1ZwnqTFaCKEC4OvVO2s1VNzx77gpVDKg393r57N60IS3CXum8\n\trzKBwHBLGyj1O5r41mbUth/edowPlabYVgwFeyG62gfEpl198+JUGNV/3DL3T0/Irn\n\tr8tA/2hhI/s/uCIAGUwgterOVemkLdwgIrFsahUQ=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [RFC PATCH v1 3/3] Add job to run lc-compliance on\n\tthe virtual pipeline handler", "Date": "Thu, 12 Dec 2024 19:16:55 +0100", "Message-ID": "<20241212181655.112958-3-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20241212181655.112958-1-barnabas.pocze@ideasonboard.com>", "References": "<20241212181655.112958-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a new job \"lc-compliance:virtual\" that uses the build artifacts\nproduced by the \"build-test:debug\" job to run lc-compliance in a\nvirtual machine on the \"Virtual0\" camera.\n\nThe `force_fallback_for=gtest` option is needed because `cpp_debustl`\nmakes ABI incompatible changes in the STL containers, so googletest\nalso needs to be compiled with these changes.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .gitlab-ci/test-lc-compliance.sh | 27 +++++++++++++++++++++++++++\n gitlab-ci.yml | 18 ++++++++++++++++--\n 2 files changed, 43 insertions(+), 2 deletions(-)\n create mode 100755 .gitlab-ci/test-lc-compliance.sh\n\n--\n2.47.1", "diff": "diff --git a/.gitlab-ci/test-lc-compliance.sh b/.gitlab-ci/test-lc-compliance.sh\nnew file mode 100755\nindex 0000000..e6697a6\n--- /dev/null\n+++ b/.gitlab-ci/test-lc-compliance.sh\n@@ -0,0 +1,27 @@\n+#!/bin/bash\n+\n+set -e\n+\n+source \"$(dirname \"$0\")/lib.sh\"\n+\n+libcamera_compliance() {\n+\techo \"Running libcamera compliance tests in a qemu VM\"\n+\n+\tvirtme-ng \\\n+\t\t--verbose \\\n+\t\t--skip-modules \\\n+\t\t--force-9p \\\n+\t\t--rwdir \"$PWD/build\" \\\n+\t\t--run /opt/linux/bzImage \\\n+\t\t--exec \"LIBCAMERA_LOG_LEVELS=*:DEBUG ./build/src/apps/lc-compliance/lc-compliance -c Virtual0; echo \\\\\\$? > ./build/.test-status\"\n+\n+\tlocal status=$(cat build/.test-status)\n+\techo \"Test result exit state: $status\"\n+\trm build/.test-status\n+\n+\tif [[ $status != 0 ]] ; then\n+\t\texit $status\n+\tfi\n+}\n+\n+run libcamera_compliance\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex c7448b8..5e9e309 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -382,9 +382,10 @@ build-test:debug:\n -D cam=disabled\n -D cpp_debugstl=true\n -D documentation=disabled\n+ -D force_fallback_for=gtest\n -D gstreamer=enabled\n- -D lc-compliance=disabled\n- -D pipelines=[]\n+ -D lc-compliance=enabled\n+ -D pipelines=virtual\n -D pycamera=enabled\n -D qcam=disabled\n -D test=true\n@@ -420,3 +421,16 @@ test-unit:\n # artifacts:\n # reports:\n # junit: build/meson-logs/testlog.junit.xml\n+\n+lc-compliance:virtual:\n+ extends:\n+ - .fdo.distribution-image@debian\n+ - .libcamera-ci.debian:12\n+ - .libcamera-ci.scripts\n+ stage: test\n+ needs:\n+ - job: build-test:debug\n+ tags:\n+ - kvm\n+ script:\n+ - $CI_PROJECT_DIR/.gitlab-ci/test-lc-compliance.sh\n", "prefixes": [ "libcamera-ci", "RFC", "v1", "3/3" ] }