Patch Detail
Show a patch.
GET /api/1.1/patches/22302/?format=api
{ "id": 22302, "url": "https://patchwork.libcamera.org/api/1.1/patches/22302/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22302/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241212181655.112958-2-barnabas.pocze@ideasonboard.com>", "date": "2024-12-12T18:16:54", "name": "[libcamera-ci,RFC,v1,2/3] Separate the building and running of unit tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5cbf9bdd03b369232b6eb37ae23bd94a490ea8ee", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22302/mbox/", "series": [ { "id": 4879, "url": "https://patchwork.libcamera.org/api/1.1/series/4879/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4879", "date": "2024-12-12T18:16:53", "name": "[RFC,v1,1/3] Enable `UDMABUF` in the kernel", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4879/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22302/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22302/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE514C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Dec 2024 18:17:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5B3867EE3;\n\tThu, 12 Dec 2024 19:17:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75AE267ED9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Dec 2024 19:16:59 +0100 (CET)", "from pb-laptop.local (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92D6DA2F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Dec 2024 19:16:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Aqq0ggnY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734027385;\n\tbh=yZ8nZU7xzMKShnGGc99l0UHvn1p389jHCOzXshUly7Y=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Aqq0ggnYMxPXwsJjSKLZjmfwXCUZB3twLRInv4M0E5NNnhCBvhO+exJHKkB51HJVm\n\t90Yc/RjiaeYOVscHCmbk4oFu2KOtwTO4hNOPEZPGO01F7YVI7fz9X9LJQEb5PeXlL8\n\t0meBzfN+UaisF2QtRVAdoawDCZ7yX/jjdgY29o4w=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [RFC PATCH v1 2/3] Separate the building and running\n\tof unit tests", "Date": "Thu, 12 Dec 2024 19:16:54 +0100", "Message-ID": "<20241212181655.112958-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20241212181655.112958-1-barnabas.pocze@ideasonboard.com>", "References": "<20241212181655.112958-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The built artifacts will be reused in a later job, so split\nthe \"test-unit\" into the \"build-test\" and \"test-unit\" jobs.\n\nThe `libevent` development package cannot be installed in the container\ndirectly because it is not multiarch compatible. It is, however, installed\nin the architecture specific build jobs, right before building. To ensure\nthat the it is available for already built executables in different jobs,\ninstall just the libraries in the container.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .gitlab-ci/setup-container.sh | 3 +++\n gitlab-ci.yml | 42 +++++++++++++++++++++++------------\n 2 files changed, 31 insertions(+), 14 deletions(-)\n\n--\n2.47.1", "diff": "diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh\nindex d2909c7..0658368 100755\n--- a/.gitlab-ci/setup-container.sh\n+++ b/.gitlab-ci/setup-container.sh\n@@ -103,6 +103,9 @@ case $FDO_DISTRIBUTION_VERSION in\n 'bookworm')\n \t# libclang-rt-dev for the clang ASan runtime.\n \tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libclang-rt-dev )\n+\t# For cam and lc-compliance\n+\t# libevent-dev cannot be used here, see build-libcamera-common.sh\n+\tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libevent-2.1-7 libevent-pthreads-2.1-7 )\n \t;;\n 'trixie')\n \t# gcc 13 to expand compilation testing coverage.\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex 8bc8bc2..c7448b8 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -64,7 +64,7 @@ include:\n .libcamera-ci.debian:12:\n variables:\n FDO_DISTRIBUTION_VERSION: 'bookworm'\n- FDO_DISTRIBUTION_TAG: '2024-12-12.1'\n+ FDO_DISTRIBUTION_TAG: '2024-12-12.2'\n\n .libcamera-ci.debian:13:\n variables:\n@@ -363,28 +363,18 @@ test-soraka:\n script:\n - submit .gitlab-ci/lava/soraka-camera-test.yml\n\n-# Run the unit tests in a virtual machine. Enable only the options exercised by\n-# the unit tests.\n-test-unit:\n+# Enable only the options exercised by the unit tests.\n+build-test:debug:\n extends:\n - .fdo.distribution-image@debian\n - .libcamera-ci.debian:12\n - .libcamera-ci.scripts\n- stage: test\n+ stage: build\n needs:\n - job: container-debian:12\n artifacts: false\n- tags:\n- - kvm\n script:\n - $CI_PROJECT_DIR/.gitlab-ci/build-libcamera.sh\n- - $CI_PROJECT_DIR/.gitlab-ci/test-libcamera-qemu.sh\n- artifacts:\n- name: libcamera-unit-tests-${CI_COMMIT_SHA}\n- when: always\n- expire_in: 1 week\n- paths:\n- - build/meson-logs/\n variables:\n BUILD_TYPE: debug\n MESON_OPTIONS: >-\n@@ -399,6 +389,30 @@ test-unit:\n -D qcam=disabled\n -D test=true\n -D v4l2=true\n+ artifacts:\n+ paths:\n+ - build/\n+ expire_in: 1 day\n+\n+# Run the unit tests in a virtual machine.\n+test-unit:\n+ extends:\n+ - .fdo.distribution-image@debian\n+ - .libcamera-ci.debian:12\n+ - .libcamera-ci.scripts\n+ stage: test\n+ needs:\n+ - job: build-test:debug\n+ tags:\n+ - kvm\n+ script:\n+ - $CI_PROJECT_DIR/.gitlab-ci/test-libcamera-qemu.sh\n+ artifacts:\n+ name: libcamera-unit-tests-${CI_COMMIT_SHA}\n+ when: always\n+ expire_in: 1 week\n+ paths:\n+ - build/meson-logs/\n\n # meson prior to 1.2.0 doesn't correctly escape non-printable characters\n # when generating the testlog XML. This results in an unparseable file.\n", "prefixes": [ "libcamera-ci", "RFC", "v1", "2/3" ] }