Patch Detail
Show a patch.
GET /api/1.1/patches/2229/?format=api
{ "id": 2229, "url": "https://patchwork.libcamera.org/api/1.1/patches/2229/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2229/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191026213835.15110-1-laurent.pinchart@ideasonboard.com>", "date": "2019-10-26T21:38:35", "name": "[libcamera-devel,PATCH/RFC] meson: Remove -Wno-unused-parameter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "613f5e16c806b60efca5b9970741af0d84b00356", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2229/mbox/", "series": [ { "id": 556, "url": "https://patchwork.libcamera.org/api/1.1/series/556/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=556", "date": "2019-10-26T21:38:35", "name": "[libcamera-devel,PATCH/RFC] meson: Remove -Wno-unused-parameter", "version": 1, "mbox": "https://patchwork.libcamera.org/series/556/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2229/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2229/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7449760C0F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Oct 2019 23:38:47 +0200 (CEST)", "from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9E7E325\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Oct 2019 23:38:46 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572125927;\n\tbh=rKRVG+nLUpuRfh+bgJipGU16GTQ7oZDqwV6El8csV44=;\n\th=From:To:Subject:Date:From;\n\tb=OuABNF9P4wEBX/rNNjf9VTLknAUn3nEmT073cI5wfxTnRvFXcLxTYD2jDCgvqIxhC\n\tjQ+bwmiV0yaqLKDEEXDzOeqW21mro9O/sXschLzhHnJcVX1z1qWtjsCh5RsLVvi1Xs\n\taNqQB5sYQ7XnNoLHarlVqDSlbQshjmYnUXUSB7fA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 27 Oct 2019 00:38:35 +0300", "Message-Id": "<20191026213835.15110-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH/RFC] meson: Remove -Wno-unused-parameter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 26 Oct 2019 21:38:47 -0000" }, "content": "We build libcamera with -Wno-unused-parameter and this doesn't cause\nmuch issue internally. However, it prevents catching unused parameters\nin inline functions defined in public headers. This can lead to\ncompilation warnings for applications compiled without\n-Wno-unused-parameter.\n\nTo catch those issues, remove -Wno-unused-parameter and fix all the\nrelated warnings.\n\nFix an additional checkstyle.py error while at it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 1 -\n src/android/camera3_hal.cpp | 9 +++++----\n src/android/camera_device.cpp | 4 ++--\n src/android/camera_proxy.cpp | 4 ++--\n src/cam/main.cpp | 2 +-\n src/ipa/ipa_vimc.cpp | 10 +++++-----\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/device_enumerator_udev.cpp | 2 +-\n src/libcamera/ipc_unixsocket.cpp | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/timeline.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo.cpp | 2 +-\n src/libcamera/pipeline/vimc.cpp | 4 ++--\n src/libcamera/process.cpp | 2 +-\n src/libcamera/proxy/ipa_proxy_linux.cpp | 12 ++++++------\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n src/qcam/main.cpp | 2 +-\n test/camera/capture.cpp | 2 +-\n test/libtest/test.h | 4 ++--\n test/log/log_process.cpp | 3 ++-\n test/message.cpp | 2 +-\n test/process/process_test.cpp | 3 ++-\n test/timer-thread.cpp | 2 +-\n test/timer.cpp | 2 +-\n 25 files changed, 43 insertions(+), 41 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 72ad7c8b493b..19a921a8ba6a 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -31,7 +31,6 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n endif\n \n common_arguments = [\n- '-Wno-unused-parameter',\n '-include', 'config.h',\n ]\n \ndiff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\nindex 8d2629ca356c..a7f470172583 100644\n--- a/src/android/camera3_hal.cpp\n+++ b/src/android/camera3_hal.cpp\n@@ -31,18 +31,19 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n \treturn cameraManager.getCameraInfo(id, info);\n }\n \n-static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n+static int hal_set_callbacks(const camera_module_callbacks_t * /*callbacks*/)\n {\n \treturn 0;\n }\n \n-static int hal_open_legacy(const struct hw_module_t *module, const char *id,\n-\t\t\t uint32_t halVersion, struct hw_device_t **device)\n+static int hal_open_legacy(const struct hw_module_t * /*module*/,\n+\t\t\t const char * /*id*/, uint32_t /*halVersion*/,\n+\t\t\t struct hw_device_t ** /*device*/)\n {\n \treturn -ENOSYS;\n }\n \n-static int hal_set_torch_mode(const char *camera_id, bool enabled)\n+static int hal_set_torch_mode(const char * /*camera_id*/, bool /*enabled*/)\n {\n \treturn -ENOSYS;\n }\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex c7c9b3fd1724..b0ba1cf0a921 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -49,7 +49,7 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n * to the framework using the designated callbacks.\n */\n \n-CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr<Camera> &camera)\n+CameraDevice::CameraDevice(unsigned int /*id*/, const std::shared_ptr<Camera> &camera)\n \t: running_(false), camera_(camera), staticMetadata_(nullptr)\n {\n \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n@@ -875,7 +875,7 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n /*\n * Produce a set of fixed result metadata.\n */\n-std::unique_ptr<CameraMetadata> CameraDevice::getResultMetadata(int frame_number,\n+std::unique_ptr<CameraMetadata> CameraDevice::getResultMetadata(int /*frame_number*/,\n \t\t\t\t\t\t\t\tint64_t timestamp)\n {\n \t/*\ndiff --git a/src/android/camera_proxy.cpp b/src/android/camera_proxy.cpp\nindex 4f5c0a024903..c9f98c784eec 100644\n--- a/src/android/camera_proxy.cpp\n+++ b/src/android/camera_proxy.cpp\n@@ -79,11 +79,11 @@ static int hal_dev_process_capture_request(const struct camera3_device *dev,\n \treturn proxy->processCaptureRequest(request);\n }\n \n-static void hal_dev_dump(const struct camera3_device *dev, int fd)\n+static void hal_dev_dump(const struct camera3_device * /*dev*/, int /*fd*/)\n {\n }\n \n-static int hal_dev_flush(const struct camera3_device *dev)\n+static int hal_dev_flush(const struct camera3_device * /*dev*/)\n {\n \treturn 0;\n }\ndiff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 9d99f5587cbb..ceb0efeff045 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -326,7 +326,7 @@ int CamApp::run()\n \treturn 0;\n }\n \n-void signalHandler(int signal)\n+void signalHandler(int /*signal*/)\n {\n \tstd::cout << \"Exiting\" << std::endl;\n \tCamApp::instance()->quit();\ndiff --git a/src/ipa/ipa_vimc.cpp b/src/ipa/ipa_vimc.cpp\nindex 63d578b4e2aa..16c7e0732d40 100644\n--- a/src/ipa/ipa_vimc.cpp\n+++ b/src/ipa/ipa_vimc.cpp\n@@ -30,11 +30,11 @@ public:\n \t~IPAVimc();\n \n \tint init() override;\n-\tvoid configure(const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t const std::map<unsigned int, ControlInfoMap> &entityControls) override {}\n-\tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n-\tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n-\tvoid processEvent(const IPAOperationData &event) override {}\n+\tvoid configure(const std::map<unsigned int, IPAStream> & /*streamConfig*/,\n+\t\t const std::map<unsigned int, ControlInfoMap> & /*entityControls*/) override {}\n+\tvoid mapBuffers(const std::vector<IPABuffer> & /*buffers*/) override {}\n+\tvoid unmapBuffers(const std::vector<unsigned int> & /*ids*/) override {}\n+\tvoid processEvent(const IPAOperationData & /*event*/) override {}\n \n private:\n \tvoid initTrace();\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 9a13f5c7df17..84f270791340 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -61,7 +61,7 @@ private:\n \tuint32_t maxGain_;\n };\n \n-void IPARkISP1::configure(const std::map<unsigned int, IPAStream> &streamConfig,\n+void IPARkISP1::configure(const std::map<unsigned int, IPAStream> & /*streamConfig*/,\n \t\t\t const std::map<unsigned int, ControlInfoMap> &entityControls)\n {\n \tif (entityControls.empty())\ndiff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex b2c5fd221dcd..6e0fbbd8c70c 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -309,7 +309,7 @@ int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n \treturn 0;\n }\n \n-void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n+void DeviceEnumeratorUdev::udevNotify(EventNotifier * /*notifier*/)\n {\n \tstruct udev_device *dev = udev_monitor_receive_device(monitor_);\n \tstd::string action(udev_device_get_action(dev));\ndiff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\nindex def08eef00f8..eb594268dd6c 100644\n--- a/src/libcamera/ipc_unixsocket.cpp\n+++ b/src/libcamera/ipc_unixsocket.cpp\n@@ -306,7 +306,7 @@ int IPCUnixSocket::recvData(void *buffer, size_t length,\n \treturn 0;\n }\n \n-void IPCUnixSocket::dataNotifier(EventNotifier *notifier)\n+void IPCUnixSocket::dataNotifier(EventNotifier * /*notifier*/)\n {\n \tint ret;\n \ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 8d3ad568d16e..84356646b736 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -700,7 +700,7 @@ error:\n }\n \n int PipelineHandlerIPU3::freeBuffers(Camera *camera,\n-\t\t\t\t const std::set<Stream *> &streams)\n+\t\t\t\t const std::set<Stream *> & /*streams*/)\n {\n \tIPU3CameraData *data = cameraData(camera);\n \ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 7a28b03b8d38..aed060bada70 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -703,7 +703,7 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera,\n }\n \n int PipelineHandlerRkISP1::freeBuffers(Camera *camera,\n-\t\t\t\t const std::set<Stream *> &streams)\n+\t\t\t\t const std::set<Stream *> & /*streams*/)\n {\n \tRkISP1CameraData *data = cameraData(camera);\n \ndiff --git a/src/libcamera/pipeline/rkisp1/timeline.cpp b/src/libcamera/pipeline/rkisp1/timeline.cpp\nindex f6c6434d7b53..59e6de78c79d 100644\n--- a/src/libcamera/pipeline/rkisp1/timeline.cpp\n+++ b/src/libcamera/pipeline/rkisp1/timeline.cpp\n@@ -204,7 +204,7 @@ void Timeline::updateDeadline()\n \ttimer_.start(deadline);\n }\n \n-void Timeline::timeout(Timer *timer)\n+void Timeline::timeout(Timer * /*timer*/)\n {\n \tutils::time_point now = std::chrono::steady_clock::now();\n \ndiff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex fae0ffc4de30..94464c7c7f0c 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -208,7 +208,7 @@ int PipelineHandlerUVC::allocateBuffers(Camera *camera,\n }\n \n int PipelineHandlerUVC::freeBuffers(Camera *camera,\n-\t\t\t\t const std::set<Stream *> &streams)\n+\t\t\t\t const std::set<Stream *> & /*streams*/)\n {\n \tUVCCameraData *data = cameraData(camera);\n \treturn data->video_->releaseBuffers();\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex c16ae4cb76b5..7e325469f178 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -166,7 +166,7 @@ PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n {\n }\n \n-CameraConfiguration *PipelineHandlerVimc::generateConfiguration(Camera *camera,\n+CameraConfiguration *PipelineHandlerVimc::generateConfiguration(Camera * /*camera*/,\n \tconst StreamRoles &roles)\n {\n \tCameraConfiguration *config = new VimcCameraConfiguration();\n@@ -274,7 +274,7 @@ int PipelineHandlerVimc::allocateBuffers(Camera *camera,\n }\n \n int PipelineHandlerVimc::freeBuffers(Camera *camera,\n-\t\t\t\t const std::set<Stream *> &streams)\n+\t\t\t\t const std::set<Stream *> & /*streams*/)\n {\n \tVimcCameraData *data = cameraData(camera);\n \treturn data->video_->releaseBuffers();\ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 3b4d0f10da67..44ebfec178fe 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -89,7 +89,7 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n \n } /* namespace */\n \n-void ProcessManager::sighandler(EventNotifier *notifier)\n+void ProcessManager::sighandler(EventNotifier * /*notifier*/)\n {\n \tchar data;\n \tssize_t ret = read(pipe_[0], &data, sizeof(data));\ndiff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\nindex 4e6fa6899e07..d4ccf5112cd7 100644\n--- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n+++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n@@ -27,11 +27,11 @@ public:\n \t~IPAProxyLinux();\n \n \tint init() override { return 0; }\n-\tvoid configure(const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t const std::map<unsigned int, ControlInfoMap> &entityControls) override {}\n-\tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n-\tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n-\tvoid processEvent(const IPAOperationData &event) override {}\n+\tvoid configure(const std::map<unsigned int, IPAStream> & /*streamConfig*/,\n+\t\t const std::map<unsigned int, ControlInfoMap> & /*entityControls*/) override {}\n+\tvoid mapBuffers(const std::vector<IPABuffer> & /*buffers*/) override {}\n+\tvoid unmapBuffers(const std::vector<unsigned int> & /*ids*/) override {}\n+\tvoid processEvent(const IPAOperationData & /*event*/) override {}\n \n private:\n \tvoid readyRead(IPCUnixSocket *ipc);\n@@ -86,7 +86,7 @@ IPAProxyLinux::~IPAProxyLinux()\n \tdelete socket_;\n }\n \n-void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n+void IPAProxyLinux::readyRead(IPCUnixSocket * /*ipc*/)\n {\n }\n \ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 208ab54199b1..87d810d7cfa4 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1141,7 +1141,7 @@ Buffer *V4L2VideoDevice::dequeueBuffer()\n * For Capture video devices the Buffer will contain valid data.\n * For Output video devices the Buffer can be considered empty.\n */\n-void V4L2VideoDevice::bufferAvailable(EventNotifier *notifier)\n+void V4L2VideoDevice::bufferAvailable(EventNotifier * /*notifier*/)\n {\n \tBuffer *buffer = dequeueBuffer();\n \tif (!buffer)\ndiff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\nindex a7ff5c52663b..d8cfc1c3d76b 100644\n--- a/src/qcam/main.cpp\n+++ b/src/qcam/main.cpp\n@@ -17,7 +17,7 @@\n #include \"../cam/options.h\"\n #include \"qt_event_dispatcher.h\"\n \n-void signalHandler(int signal)\n+void signalHandler(int /*signal*/)\n {\n \tstd::cout << \"Exiting\" << std::endl;\n \tqApp->quit();\ndiff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nindex 791ccad15f70..a5fd0a641705 100644\n--- a/test/camera/capture.cpp\n+++ b/test/camera/capture.cpp\n@@ -19,7 +19,7 @@ protected:\n \tunsigned int completeBuffersCount_;\n \tunsigned int completeRequestsCount_;\n \n-\tvoid bufferComplete(Request *request, Buffer *buffer)\n+\tvoid bufferComplete(Request * /*request*/, Buffer *buffer)\n \t{\n \t\tif (buffer->status() != Buffer::BufferSuccess)\n \t\t\treturn;\ndiff --git a/test/libtest/test.h b/test/libtest/test.h\nindex ec08bf97c03d..193d7aa99f38 100644\n--- a/test/libtest/test.h\n+++ b/test/libtest/test.h\n@@ -26,11 +26,11 @@ public:\n protected:\n \tvirtual int init() { return 0; }\n \tvirtual int run() = 0;\n-\tvirtual void cleanup() { }\n+\tvirtual void cleanup() {}\n };\n \n #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\n-int main(int argc, char *argv[])\t\t\t\t\t\\\n+int main(int /*argc*/, char * /*argv*/[])\t\t\t\t\\\n {\t\t\t\t\t\t\t\t\t\\\n \treturn klass().execute();\t\t\t\t\t\\\n }\ndiff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex 2df4aa43713c..fa5639dde7cb 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -123,7 +123,8 @@ protected:\n \t}\n \n private:\n-\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n+\tvoid procFinished(Process * /*proc*/,\n+\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n \t{\n \t\texitStatus_ = exitStatus;\n \t\texitCode_ = exitCode;\ndiff --git a/test/message.cpp b/test/message.cpp\nindex 3775c30a20b3..3e2659c836e3 100644\n--- a/test/message.cpp\n+++ b/test/message.cpp\n@@ -35,7 +35,7 @@ public:\n \tvoid reset() { status_ = NoMessage; }\n \n protected:\n-\tvoid message(Message *msg)\n+\tvoid message(Message * /*msg*/)\n \t{\n \t\tif (thread() != Thread::current())\n \t\t\tstatus_ = InvalidThread;\ndiff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\nindex 7e7b3c2c8bf3..2ba3efd08457 100644\n--- a/test/process/process_test.cpp\n+++ b/test/process/process_test.cpp\n@@ -75,7 +75,8 @@ protected:\n \t}\n \n private:\n-\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n+\tvoid procFinished(Process * /*proc*/,\n+\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n \t{\n \t\texitStatus_ = exitStatus;\n \t\texitCode_ = exitCode;\ndiff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\nindex 32853b4e80ef..55b7abcbbeab 100644\n--- a/test/timer-thread.cpp\n+++ b/test/timer-thread.cpp\n@@ -39,7 +39,7 @@ public:\n \t}\n \n private:\n-\tvoid timeoutHandler(Timer *timer)\n+\tvoid timeoutHandler(Timer * /*timer*/)\n \t{\n \t\ttimeout_ = true;\n \t}\ndiff --git a/test/timer.cpp b/test/timer.cpp\nindex 2bdb006edccb..03df03aa8d69 100644\n--- a/test/timer.cpp\n+++ b/test/timer.cpp\n@@ -56,7 +56,7 @@ public:\n \t}\n \n private:\n-\tvoid timeoutHandler(Timer *timer)\n+\tvoid timeoutHandler(Timer * /*timer*/)\n \t{\n \t\texpiration_ = std::chrono::steady_clock::now();\n \t\tcount_++;\n", "prefixes": [ "libcamera-devel", "PATCH/RFC" ] }