Patch Detail
Show a patch.
GET /api/1.1/patches/2228/?format=api
{ "id": 2228, "url": "https://patchwork.libcamera.org/api/1.1/patches/2228/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2228/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191026211743.12963-1-laurent.pinchart@ideasonboard.com>", "date": "2019-10-26T21:17:43", "name": "[libcamera-devel] libcamera: bound_method: Fix compiler warning due to unused arguments", "commit_ref": "9d66ffc085e4e8fd8d24fd196b70d88c7d0b0b7e", "pull_url": null, "state": "accepted", "archived": false, "hash": "c29328ff7b899e2911cf9fb3608d0810275b08ce", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2228/mbox/", "series": [ { "id": 555, "url": "https://patchwork.libcamera.org/api/1.1/series/555/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=555", "date": "2019-10-26T21:17:43", "name": "[libcamera-devel] libcamera: bound_method: Fix compiler warning due to unused arguments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/555/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2228/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2228/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 223D760C0F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Oct 2019 23:17:55 +0200 (CEST)", "from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A044E325\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Oct 2019 23:17:54 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572124674;\n\tbh=Dp4A1x1byeU6mouraFKOQONhnDfYL9J1rVvsKQ8AlYE=;\n\th=From:To:Subject:Date:From;\n\tb=IPjoOaGhbVMFsahV9+A+P9nuVroHKMKuyQeoD7uSQ6jAW19VlZzv9mQ4pP6qkGlTb\n\tO8iLo0usElhs8N0Rtxowo8e6KVx8385Rs2F0S13Q/W39igzshyyEkEEebxC7TkhnYH\n\tyE53MYb9MqSzUbG9JZ9LK9106A/i0V01wV1OWyRQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 27 Oct 2019 00:17:43 +0300", "Message-Id": "<20191026211743.12963-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: bound_method: Fix compiler\n\twarning due to unused arguments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 26 Oct 2019 21:17:55 -0000" }, "content": "The BoundStaticMethod::invoke() method is never used, but must still be\nimplemented as the base class defines it as pure virtual. As it doesn't\nuse its arguments, the compiler generates a warning. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/bound_method.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex 54c40fc52e3b..8ebaadbec887 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -119,7 +119,7 @@ public:\n \tbool match(void (*func)(Args...)) const { return func == func_; }\n \n \tvoid activate(Args... args) { (*func_)(args...); }\n-\tvoid invoke(Args... args) {}\n+\tvoid invoke(Args...) {}\n \n private:\n \tvoid (*func_)(Args...);\n", "prefixes": [ "libcamera-devel" ] }