Patch Detail
Show a patch.
GET /api/1.1/patches/22254/?format=api
{ "id": 22254, "url": "https://patchwork.libcamera.org/api/1.1/patches/22254/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22254/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241206183036.107837-1-jacopo.mondi@ideasonboard.com>", "date": "2024-12-06T18:30:35", "name": "[v4] libcamera: stream: Add operator<<(StreamConfiguration)", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fb23a9e6d53a0283a5afb995084e6cccc0252f1c", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22254/mbox/", "series": [ { "id": 4862, "url": "https://patchwork.libcamera.org/api/1.1/series/4862/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4862", "date": "2024-12-06T18:30:35", "name": "[v4] libcamera: stream: Add operator<<(StreamConfiguration)", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4862/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22254/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22254/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73EFBBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Dec 2024 18:30:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51B3967E3C;\n\tFri, 6 Dec 2024 19:30:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BEA3618B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Dec 2024 19:30:44 +0100 (CET)", "from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0B4DB2B;\n\tFri, 6 Dec 2024 19:30:14 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BMSDq1lG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733509815;\n\tbh=tlCiCVsWM/KHaFwXfpVs9RnN9F9AeC8pr3J50dbiSxM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=BMSDq1lGiXe5Orn9dLaXDCpEgD4HLtCMwn/LkC/bIX3bhjJlq9n6sqF5cLY3RCNBK\n\tJMiRmRjCj0NkdLFxqLaxHdKBgecstD8vdTZMuQse4SXV4uCA0SG5Hn0TiGJzkp0hEq\n\tX6gCHd5ntQenlpTijgY+e4xmU35xc1rH7cMHBYDo=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v4] libcamera: stream: Add operator<<(StreamConfiguration)", "Date": "Fri, 6 Dec 2024 19:30:35 +0100", "Message-ID": "<20241206183036.107837-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The StreamConfiguration class only implements toString() but doesn't\noffer an overload of operator<<() which is more convenient to use.\n\nAdd an overload for operator<<(StreamConfiguration) and re-implement\nStreamConfiguration::toString() on top of it.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/stream.h | 2 ++\n src/libcamera/stream.cpp | 18 +++++++++++++++++-\n 2 files changed, 19 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 071b71698acb..ea228aea7d56 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -61,6 +61,8 @@ private:\n \tStreamFormats formats_;\n };\n \n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n+\n enum class StreamRole {\n \tRaw,\n \tStillCapture,\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 1f75dbbc5b64..eb92cb69df31 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -392,7 +392,23 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n */\n std::string StreamConfiguration::toString() const\n {\n-\treturn size.toString() + \"-\" + pixelFormat.toString();\n+\tstd::stringstream ss;\n+\tss << *this;\n+\n+\treturn ss.str();\n+}\n+\n+/**\n+ * \\brief Insert a text representation of a StreamConfiguration into an output\n+ * stream\n+ * \\param[in] out The output stream\n+ * \\param[in] cfg The StreamConfiguration\n+ * \\return The output stream \\a out\n+ */\n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n+{\n+\tout << cfg.size << \"-\" << cfg.pixelFormat;\n+\treturn out;\n }\n \n /**\n", "prefixes": [ "v4" ] }