Patch Detail
Show a patch.
GET /api/1.1/patches/22231/?format=api
{ "id": 22231, "url": "https://patchwork.libcamera.org/api/1.1/patches/22231/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22231/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241206160747.97176-6-jacopo.mondi@ideasonboard.com>", "date": "2024-12-06T16:07:43", "name": "[5/8] libcamera: request: Add function to reset metadata", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b381d63d45dbe9a719f359eeec9e751f082066ca", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22231/mbox/", "series": [ { "id": 4858, "url": "https://patchwork.libcamera.org/api/1.1/series/4858/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4858", "date": "2024-12-06T16:07:38", "name": "libcamera: Support partial metadata completion", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4858/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22231/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22231/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5AA5DBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Dec 2024 16:08:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DAC467E32;\n\tFri, 6 Dec 2024 17:08:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0A2B67E23\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Dec 2024 17:07:56 +0100 (CET)", "from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20B9CB2B;\n\tFri, 6 Dec 2024 17:07:27 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l4t4zwog\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733501247;\n\tbh=0JI3J9rPo6b0oNYB/P6YFJNiSKC94wj9/MyHeBre318=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l4t4zwog3VDxY628BcnWb7A5DfAs2+XPeB3aWwHVDl8GDZWtwEnZ//fOV4QQTHq5D\n\tJOxdySRpDw6whOI+0fId9w4BlRfxOK1fUp/UDkbFo30Y6PphyVVeA2WjJAfpw3n1GF\n\t4ii3JUXWstGu75j/RAu7m228P9yfJXR2UM/N88R4=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tHan-Lin Chen <hanlinchen@chromium.org>", "Subject": "[PATCH 5/8] libcamera: request: Add function to reset metadata", "Date": "Fri, 6 Dec 2024 17:07:43 +0100", "Message-ID": "<20241206160747.97176-6-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "In-Reply-To": "<20241206160747.97176-1-jacopo.mondi@ideasonboard.com>", "References": "<20241206160747.97176-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to prepare to restrict access to the metadata list stored\nin a request, provide a function that allows pipeline handlers to\nreset the metadata pack.\n\nThe only user is at the moment the vc4 pipeline handler.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/request.h | 5 +++++\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-\n 2 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 4e7d05b1e028..98b7c6d6dfdf 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -40,6 +40,11 @@ public:\n \tvoid cancel();\n \tvoid reset();\n \n+\tvoid resetMetadata()\n+\t{\n+\t\t_o<Request>()->metadata().clear();\n+\t}\n+\n \tvoid prepare(std::chrono::milliseconds timeout = 0ms);\n \tSignal<> prepared;\n \ndiff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\nindex fd8d84b14f15..bddc8a87d9e1 100644\n--- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n+++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n@@ -945,7 +945,7 @@ void Vc4CameraData::tryRunPipeline()\n \t * related controls. We clear it first because the request metadata\n \t * may have been populated if we have dropped the previous frame.\n \t */\n-\trequest->metadata().clear();\n+\trequest->_d()->resetMetadata();\n \tfillRequestMetadata(bayerFrame.controls, request);\n \n \t/* Set our state to say the pipeline is active. */\n", "prefixes": [ "5/8" ] }