Patch Detail
Show a patch.
GET /api/1.1/patches/2223/?format=api
{ "id": 2223, "url": "https://patchwork.libcamera.org/api/1.1/patches/2223/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2223/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191025213255.2751-1-laurent.pinchart@ideasonboard.com>", "date": "2019-10-25T21:32:54", "name": "[libcamera-devel,1/2] test: controls: Add ControlInfoMap test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "94f4b326fb925116357d5897282d53ee294103dc", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2223/mbox/", "series": [ { "id": 551, "url": "https://patchwork.libcamera.org/api/1.1/series/551/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=551", "date": "2019-10-25T21:32:54", "name": "[libcamera-devel,1/2] test: controls: Add ControlInfoMap test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/551/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2223/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2223/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8878761375\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Oct 2019 23:33:07 +0200 (CEST)", "from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AF7C813\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Oct 2019 23:33:06 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572039187;\n\tbh=aJCNH2u5jO0bFjeNJYWHSM24201u2AkbphOSMmt40Ss=;\n\th=From:To:Subject:Date:From;\n\tb=O/+hajqgJ7CDRExF2bZjzZnt9/AoyyJS+uREEh+BG9YwbzAWV8j18EeYgqvING4j6\n\tvbv3d5/iq1MtXFFbEgr19msd9GS5HV2mrjtwTVScLKCnHsdagzMJZ681Y1FYnRqrA2\n\tF5tEOfyTxKVGUxn2KXhoJrjVt/Gbsrc20lxAFVLk=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 26 Oct 2019 00:32:54 +0300", "Message-Id": "<20191025213255.2751-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] test: controls: Add ControlInfoMap\n\ttest", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 25 Oct 2019 21:33:07 -0000" }, "content": "Add a test to exercise the ControlInfoMap API. This currently tests\nat(), count(), find() and end().\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/controls/control_info.cpp | 102 +++++++++++++++++++++++++++++++++\n test/controls/meson.build | 1 +\n 2 files changed, 103 insertions(+)\n create mode 100644 test/controls/control_info.cpp", "diff": "diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\nnew file mode 100644\nindex 000000000000..f5ba1caec7bf\n--- /dev/null\n+++ b/test/controls/control_info.cpp\n@@ -0,0 +1,102 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * control_info.cpp - ControlInfoMap tests\n+ */\n+\n+#include <iostream>\n+\n+#include <libcamera/camera.h>\n+#include <libcamera/camera_manager.h>\n+#include <libcamera/control_ids.h>\n+#include <libcamera/controls.h>\n+\n+#include \"camera_controls.h\"\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class ControlInfoMapTest : public Test\n+{\n+protected:\n+\tint init()\n+\t{\n+\t\tcm_ = new CameraManager();\n+\n+\t\tif (cm_->start()) {\n+\t\t\tcout << \"Failed to start camera manager\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tcamera_ = cm_->get(\"VIMC Sensor B\");\n+\t\tif (!camera_) {\n+\t\t\tcout << \"Can not find VIMC camera\" << endl;\n+\t\t\treturn TestSkip;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\tconst ControlInfoMap &info = camera_->controls();\n+\n+\t\t/* Test looking up a valid control by ControlId. */\n+\t\tif (info.count(&controls::Brightness) != 1) {\n+\t\t\tcout << \"count() on valid control failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (info.find(&controls::Brightness) == info.end()) {\n+\t\t\tcout << \"find() on valid control failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tinfo.at(&controls::Brightness);\n+\n+\t\t/* Test looking up a valid control by numerical ID. */\n+\t\tif (info.count(controls::Brightness.id()) != 1) {\n+\t\t\tcout << \"count() on valid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (info.find(controls::Brightness.id()) == info.end()) {\n+\t\t\tcout << \"find() on valid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tinfo.at(controls::Brightness.id());\n+\n+\t\t/* Test looking up an invalid control by numerical ID. */\n+\t\tif (info.count(12345) != 0) {\n+\t\t\tcout << \"count() on invalid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (info.find(12345) != info.end()) {\n+\t\t\tcout << \"find() on invalid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup()\n+\t{\n+\t\tif (camera_) {\n+\t\t\tcamera_->release();\n+\t\t\tcamera_.reset();\n+\t\t}\n+\n+\t\tcm_->stop();\n+\t\tdelete cm_;\n+\t}\n+\n+private:\n+\tCameraManager *cm_;\n+\tstd::shared_ptr<Camera> camera_;\n+};\n+\n+TEST_REGISTER(ControlInfoMapTest)\ndiff --git a/test/controls/meson.build b/test/controls/meson.build\nindex 9f0f005a2759..f0850df28c8a 100644\n--- a/test/controls/meson.build\n+++ b/test/controls/meson.build\n@@ -1,4 +1,5 @@\n control_tests = [\n+ [ 'control_info', 'control_info.cpp' ],\n [ 'control_list', 'control_list.cpp' ],\n [ 'control_range', 'control_range.cpp' ],\n [ 'control_value', 'control_value.cpp' ],\n", "prefixes": [ "libcamera-devel", "1/2" ] }