Patch Detail
Show a patch.
GET /api/1.1/patches/22218/?format=api
{ "id": 22218, "url": "https://patchwork.libcamera.org/api/1.1/patches/22218/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22218/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241206145242.827886-2-stefan.klug@ideasonboard.com>", "date": "2024-12-06T14:52:21", "name": "[v5,1/8] libcamera: controls: Update the ColourTemperature control to be writable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d01cef0d9384b7b25beb55efdcab2d0d78525cfb", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22218/mbox/", "series": [ { "id": 4857, "url": "https://patchwork.libcamera.org/api/1.1/series/4857/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4857", "date": "2024-12-06T14:52:20", "name": "rkisp1: Add manual colour temperature control", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4857/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22218/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22218/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2AC1BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Dec 2024 14:52:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 680666615F;\n\tFri, 6 Dec 2024 15:52:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CF0A6614C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Dec 2024 15:52:50 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3543:aebe:e043:ef86])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBFAB641;\n\tFri, 6 Dec 2024 15:52:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g0GFToL6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733496740;\n\tbh=OD6S88E9NiwAvWE9IB9CFpL4roYQ0zm9YER3Y/+TXgM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g0GFToL6UZd87UCIuSneaxSXEHU8wgU4BpACscwPkKjodUQtodEhFT4wsaAGsG1Mg\n\tCpd5MPSYE0s2ZdXvz/rzhOg0gHh+rlbE3t5glWVIxrtp7bIXaOh1UgDDhpVaCL8Ytm\n\tEQkeNtsf/B6UwtUdhPCPvNAfueLIXKA5JOmbO9dc=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 1/8] libcamera: controls: Update the ColourTemperature\n\tcontrol to be writable", "Date": "Fri, 6 Dec 2024 15:52:21 +0100", "Message-ID": "<20241206145242.827886-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241206145242.827886-1-stefan.klug@ideasonboard.com>", "References": "<20241206145242.827886-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For manual control it is helpful to be able to specify a fixed colour\ntemperature. It also provides an easy way to apply the temperature\nspecific CCMs and colour gains that are contained in the tuning files.\n\nDocument this and update the control dependencies.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v5:\n- Improve documentation\n---\n src/libcamera/control_ids_core.yaml | 29 +++++++++++++++++++++++++++--\n 1 file changed, 27 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex d45cf8e56187..3795f7169911 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -283,7 +283,19 @@ controls:\n description: |\n Enable or disable the AWB.\n \n+ When AWB is enabled, the algorithm estimates the colour temperature of\n+ the scene, and computes colour gains and the colour correction matrix\n+ automatically. The computed colour temperate, gains and correction\n+ matrix are reported in metadata. The corresponding controls are ignored\n+ if set in a request.\n+\n+ When AWB is disabled, the colour temperature, gains and correction\n+ matrix are not updated automatically and can be set manually in\n+ requests.\n+\n+ \\sa ColourCorrectionMatrix\n \\sa ColourGains\n+ \\sa ColourTemperature\n \n # AwbMode needs further attention:\n # - Auto-generate max enum value.\n@@ -341,14 +353,25 @@ controls:\n ColourGains can only be applied in a Request when the AWB is disabled.\n \n \\sa AwbEnable\n+ \\sa ColourTemperature\n size: [2]\n \n - ColourTemperature:\n type: int32_t\n description: |\n- Report the estimate of the colour temperature for the frame, in kelvin.\n+ Report the current estimate of the colour temperature, in kelvin, for\n+ this frame. An implementation may allow this control to be set when AWB\n+ is disabled. In that case ColourGains and the ColourCorrectionMatrix get\n+ set accordingly. If ColourGains and ColourTemperature are specified at\n+ the same time, ColourGains takes precedence. The same applies to\n+ ColourCorrectionMatrix.\n+\n+ The metadata will only report measured colour temperature values when\n+ available, even if set manually.\n \n- The ColourTemperature control can only be returned in metadata.\n+ \\sa AwbEnable\n+ \\sa ColourCorrectionMatrix\n+ \\sa ColourGains\n \n - Saturation:\n type: float\n@@ -405,6 +428,8 @@ controls:\n stored in conventional reading order in an array of 9 floating point\n values.\n \n+ \\sa AwbEnable\n+ \\sa ColourTemperature\n size: [3,3]\n \n - ScalerCrop:\n", "prefixes": [ "v5", "1/8" ] }