Patch Detail
Show a patch.
GET /api/1.1/patches/22168/?format=api
{ "id": 22168, "url": "https://patchwork.libcamera.org/api/1.1/patches/22168/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22168/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241204164137.3938891-7-chenghaoyang@chromium.org>", "date": "2024-12-04T16:36:31", "name": "[v3,6/7] android: notify CAMERA3_MSG_ERROR_REQUEST out of order", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "457bce82f4725f88fc8800026ff59e1b99763bee", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22168/mbox/", "series": [ { "id": 4847, "url": "https://patchwork.libcamera.org/api/1.1/series/4847/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4847", "date": "2024-12-04T16:36:25", "name": "Refactor Android HAL before supporting partial result", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4847/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22168/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22168/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BE70BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Dec 2024 16:42:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C0B1660F3;\n\tWed, 4 Dec 2024 17:41:59 +0100 (CET)", "from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com\n\t[IPv6:2607:f8b0:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B8AA660E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Dec 2024 17:41:54 +0100 (CET)", "by mail-pf1-x42a.google.com with SMTP id\n\td2e1a72fcca58-7252fba4de1so42745b3a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 04 Dec 2024 08:41:54 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-725417725e9sm12551779b3a.80.2024.12.04.08.41.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 04 Dec 2024 08:41:50 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"RQ22hJ8v\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1733330511; x=1733935311;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=37nnvTi9vvdECb0kx0poJ2dB18jSK5vuzdObv0ENTJg=;\n\tb=RQ22hJ8vZyl/QIdqKpu9waswyinhyXegJu0MNHysH2YHl7HlnvPlNRU74afFZCoiwm\n\tkBKgTH9ba5okxYrWbVGLRlNvV/DST12sJhDJBABwYuJVUIQKqt550ILr4m77fx6guE+3\n\tjgbDsw8VsbWDx1Tu+1ve0dP9yqJVTdciTVNHI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733330511; x=1733935311;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=37nnvTi9vvdECb0kx0poJ2dB18jSK5vuzdObv0ENTJg=;\n\tb=cC2w037/DjnSFSO9Hw3/B7QNL/2X7c8kMWABJUUX3d6QQB5k9WK3J5zsHyDAY4gSkZ\n\tq70GHgsBhu++JuwxpOQat5tNNrqScMDPFrcKjKJ3hHZRLwnmw2Ywn/cPWvK1qWAGjv9v\n\t2OBTIzxeVhTjvVl3J+yLtQyJ7KPRYT9RS7cAoqPFzQYl1fXoDnzwgSEIwa1yn24SLo0i\n\tzrrPyu6a/zWHZXT0xzKjwuX2Er0PS3yefZsnJ6AXAHOyiLte/CETkKk2tOb43FoOBTY1\n\trbqf9q4/cRfLx969oANY6V+W34jJ16FUkkK4WiK5GYGjqdFYJyQ7v9gh0Kf8Af4UMCwH\n\tCe3Q==", "X-Gm-Message-State": "AOJu0YzMaxiiCRwxsgxyRvil5GBpLJ1QuX1EFq62YXE05t0ZWRcYDFCG\n\tuoeTrzcX7eNA+lXey+JCaP8x2MNuZLiuhwvXgkF1LGSXWUA8mgg+GgVoVtkPtkJWeHU6sUhr58s\n\t=", "X-Gm-Gg": "ASbGncsxf0SeJRqGDuPw/vnGUX4XDtlHkoiBqK8BxrQw7tRfcr4qUt2UjsXfNMCgl7w\n\tSEVQUh8ZvJARwnFwEhOph/SpA2fdhnX/YHawQbsBGj8wKKZC9JPAyfq/mH5weGr071rpIPAd1Q8\n\t02lfM+UKKRdZ7aQrofo3J/T0OY+SA1u3W10Sw9gIO5djDh11ENBqCS+Ava3C5Hp6lS2cVP+zfSy\n\tLjLA+IJdxzDswnRIfDvmmuQoIInLcYbvQbqO5h0agIj3EcKVqfyndIullJcgcJpvPhLWpeFWzyh\n\tpFWnxgHc83GixjLgQQcN4ZUTxA+EkybkTnnn76bUY9aeGAMC9TPW42TJ", "X-Google-Smtp-Source": "AGHT+IH9exai7cVZ1xtRic5GGuqexbN4H4apGhto6REw8K4B0fPJBqZh/pytnN7YTlOz1pYIfd7eQw==", "X-Received": "by 2002:a05:6a00:14d5:b0:71e:60fc:ad11 with SMTP id\n\td2e1a72fcca58-7257fcb04ddmr10464905b3a.16.1733330511625; \n\tWed, 04 Dec 2024 08:41:51 -0800 (PST)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>,\n\tHan-Lin Chen <hanlinchen@chromium.org>", "Subject": "[PATCH v3 6/7] android: notify CAMERA3_MSG_ERROR_REQUEST out of\n\torder", "Date": "Wed, 4 Dec 2024 16:36:31 +0000", "Message-ID": "<20241204164137.3938891-7-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.338.g60cca15819-goog", "In-Reply-To": "<20241204164137.3938891-1-chenghaoyang@chromium.org>", "References": "<20241204164137.3938891-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a request hasn't done any processing, CAMERA3_MSG_ERROR_REQUEST and\nthe following process_capture_result don't need to wait for the previous\nrequests' completion. This patch avoids pushing the aborted requests\ninto the request queue.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/android/camera_device.cpp | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex dd2c603e0..18e974f56 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -867,6 +867,8 @@ void CameraDevice::abortRequest(Camera3RequestDescriptor *descriptor) const\n \t\tbuffer.status = StreamBuffer::Status::Error;\n \n \tdescriptor->status_ = Camera3RequestDescriptor::Status::Error;\n+\n+\tsendCaptureResult(descriptor);\n }\n \n bool CameraDevice::isValidRequest(camera3_capture_request_t *camera3Request) const\n@@ -1136,14 +1138,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \tMutexLocker stateLock(stateMutex_);\n \n \tif (state_ == State::Flushing) {\n-\t\tCamera3RequestDescriptor *rawDescriptor = descriptor.get();\n-\t\t{\n-\t\t\tMutexLocker descriptorsLock(descriptorsMutex_);\n-\t\t\tdescriptors_.push(std::move(descriptor));\n-\t\t}\n-\t\tabortRequest(rawDescriptor);\n-\t\tcompleteDescriptor(rawDescriptor);\n-\n+\t\tabortRequest(descriptor.get());\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "v3", "6/7" ] }