Patch Detail
Show a patch.
GET /api/1.1/patches/22141/?format=api
{ "id": 22141, "url": "https://patchwork.libcamera.org/api/1.1/patches/22141/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22141/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241129123032.2957763-2-chenghaoyang@chromium.org>", "date": "2024-11-29T12:27:49", "name": "[v7,1/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties", "commit_ref": "407620187398724fadee5dea2adeb6dc72173ce0", "pull_url": null, "state": "accepted", "archived": false, "hash": "c9f6f4800e3feb78a69f7d6db9707741c59f7106", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22141/mbox/", "series": [ { "id": 4834, "url": "https://patchwork.libcamera.org/api/1.1/series/4834/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4834", "date": "2024-11-29T12:27:48", "name": "Add camera sensor properties for ciri", "version": 7, "mbox": "https://patchwork.libcamera.org/series/4834/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22141/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22141/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31AD0BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Nov 2024 12:30:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CFC166032;\n\tFri, 29 Nov 2024 13:30:43 +0100 (CET)", "from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n\t[IPv6:2607:f8b0:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA3EA6600C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Nov 2024 13:30:40 +0100 (CET)", "by mail-pg1-x52e.google.com with SMTP id\n\t41be03b00d2f7-7e6cbf6cd1dso878558a12.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Nov 2024 04:30:40 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7fc9c2d3e28sm3017469a12.17.2024.11.29.04.30.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Nov 2024 04:30:38 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mTZrR7r0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732883439; x=1733488239;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BCzlqBtgz57zUrJdOaIck/Ya9bpeZNRRZ6Hw2VUu3Hc=;\n\tb=mTZrR7r0qQvteVdrvH4Qjy/kl4cJY26JKa+8fTTyh2pmfekdImRebry6w/PBc2nWLM\n\t4JlIycSIDdJH6izQOM8CSUUBA/WTUuWOepFUdKnt28qOB18UaPFYLhHh7wAbKQrElV8P\n\tYrnjliUk0gfO9KXZ60ZklTP0RQgbSTccBcqJ8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732883439; x=1733488239;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=BCzlqBtgz57zUrJdOaIck/Ya9bpeZNRRZ6Hw2VUu3Hc=;\n\tb=Sz8LAB735uxJT38RWGYYgdbu/hdXAJgkNJbfxVXubwqzk0TGHXLFyqZHyalwqqDMTA\n\tvSirCy1GOFNVjHBNSW9FYJtTLiVTwKM6Pon5/DRZfvJrdDaw4IIwMJdvyMV2VuxUuTI3\n\ttd5sK4ooEUtKfwgEmgwxdXWm6JW/fnXn/xiybz4/M1qpbn9BpfnoQFOzws6ky83ck6Ki\n\tqa9f/hvlL1P3n3Xeq8hQ6THPyTxMi+YXklx9yq11QfNLg7KbiZLs0lqRodpNCTnGU80F\n\tUIw1EzkfoR/5BtomhQVDSvSZgEyV0JZjQcgLTcG5vbTn126HymbpGgMalXCn/cBKSy0m\n\tLLyQ==", "X-Gm-Message-State": "AOJu0YyizQLJqzSC7WNCo96xldd5mH1GhO8TGK4aycZYWt275OKeC/fx\n\tgjxQjZ6irfe0rx2fhj8V7Kc05NfsQwqkqNYRO4OBF1iakEE8Rz96z1RPxS7TqV5u+SuiwAQtTRs\n\t=", "X-Gm-Gg": "ASbGnctR0cNvydR+MHcRSKJ5zpyB56A2H7FrxQ2tpaZcBGXVDJDLlnera7tqAvU/njC\n\twAVjkXch3XhomplmBkMJ/tITIWfmwN/YAacKpj+/aIXtM+NUGERyccx5v7dB5M5eQ8Cgwd7ILqM\n\toTmnMlbHY9YuhDumaopsSFILklaOJqm286gwaDQbMKhjIB0lk65S2yqAcqQNG5OT9TPMheDXd/v\n\t3i/0kRvHzdhiu2SD8fGm6EmVyIFVFwhShpHYy77JfPTEPV0+Hz6lfCzfUQRpvaoaN9Dbm8bgPPM\n\t1tiDsawfNaiC5rrQ2LfIolCxGpoaTBO3J20ATs3lV2TAAdDu3C/oy/+i", "X-Google-Smtp-Source": "AGHT+IHevGXNFHj11vsGp2GAkIGarA7gGAWYsgMYaKmMu1GpAOPNzcSyXcwB5LBUY5jY5TSJdnNxsA==", "X-Received": "by 2002:a05:6a20:158a:b0:1e0:dac7:ecd6 with SMTP id\n\tadf61e73a8af0-1e0e0b2c759mr19409821637.21.1732883438964; \n\tFri, 29 Nov 2024 04:30:38 -0800 (PST)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>,\n\tHan-Lin Chen <hanlinchen@chromium.org>, Xing Gu <xinggu@chromium.org>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v7 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties", "Date": "Fri, 29 Nov 2024 12:27:49 +0000", "Message-ID": "<20241129123032.2957763-2-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.338.g60cca15819-goog", "In-Reply-To": "<20241129123032.2957763-1-chenghaoyang@chromium.org>", "References": "<20241129123032.2957763-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the GalaxyCore gc05a2 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Xing Gu <xinggu@chromium.org>\nSigned-off-by: Xing Gu <xinggu@chromium.org>\nCo-developed-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++\n 2 files changed, 26 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex a0a5437aa..9fb55bcfa 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -519,6 +519,19 @@ private:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ar0521\", CameraSensorHelperAr0521)\n \n+class CameraSensorHelperGc05a2 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperGc05a2()\n+\t{\n+\t\t/* From datasheet: 64 at 10bits. */\n+\t\tblackLevel_ = 4096;\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 100, 0, 0, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 3fe18c164..73c47b9a1 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -106,6 +106,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t},\n \t\t\t.sensorDelays = { },\n \t\t} },\n+\t\t{ \"gc05a2\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "v7", "1/2" ] }