Patch Detail
Show a patch.
GET /api/1.1/patches/22128/?format=api
{ "id": 22128, "url": "https://patchwork.libcamera.org/api/1.1/patches/22128/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22128/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241128125226.683249-2-mzamazal@redhat.com>", "date": "2024-11-28T12:52:22", "name": "[v5,1/4] ipa: software_isp: Add constructor to the IPA context", "commit_ref": "d2234560f844ba37440e565bd3b4b0c8d8266d02", "pull_url": null, "state": "accepted", "archived": false, "hash": "249488f8b27b87d0c8ead7cf8190ce06e4fa99ef", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22128/mbox/", "series": [ { "id": 4831, "url": "https://patchwork.libcamera.org/api/1.1/series/4831/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4831", "date": "2024-11-28T12:52:21", "name": "Add contrast control to software ISP", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4831/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22128/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22128/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 798C9BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 28 Nov 2024 12:52:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36E7865F6B;\n\tThu, 28 Nov 2024 13:52:43 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0FD3658A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Nov 2024 13:52:39 +0100 (CET)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-675-Q2RPgq4CNsmuxx24uSwXZw-1;\n\tThu, 28 Nov 2024 07:52:37 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3596D19560A3; Thu, 28 Nov 2024 12:52:36 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.146])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E3EF61955D47; Thu, 28 Nov 2024 12:52:33 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UxuuR7zE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1732798358;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=AJ/bhF6LH8e7W+qsAe5aPBsHhQNr70j3pSNwuAf7fAw=;\n\tb=UxuuR7zEDNXwex12ciaLSrM/CWlLrU9y+3swCJpKse0wGVv8jUs6rgX303zQnKubieZWFo\n\tBxc9bVKdJ9JyGrKBNwVxr9QR7jkTZ27SgWf7y/vw3lsuq38jepzQxqUqMpA4U1uQI3NsfB\n\t5nbZAP1TMRU99SwSugdVH2jIr8EQ4LM=", "X-MC-Unique": "Q2RPgq4CNsmuxx24uSwXZw-1", "X-Mimecast-MFC-AGG-ID": "Q2RPgq4CNsmuxx24uSwXZw", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v5 1/4] ipa: software_isp: Add constructor to the IPA context", "Date": "Thu, 28 Nov 2024 13:52:22 +0100", "Message-ID": "<20241128125226.683249-2-mzamazal@redhat.com>", "In-Reply-To": "<20241128125226.683249-1-mzamazal@redhat.com>", "References": "<20241128125226.683249-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "pTkLICiBZFi59cvjyQqZWu_-b5PE6QwNrYTzgr0tkOY_1732798356", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's have a constructor that takes just the non-default argument,\nwithout the need to specify the defaults.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/simple/ipa_context.h | 5 +++++\n src/ipa/simple/soft_simple.cpp | 2 +-\n 2 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex fd121eeb..fd7343e9 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -59,6 +59,11 @@ struct IPAFrameContext : public FrameContext {\n };\n \n struct IPAContext {\n+\tIPAContext(unsigned int frameContextSize)\n+\t\t: frameContexts(frameContextSize)\n+\t{\n+\t}\n+\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \tFCQueue<IPAFrameContext> frameContexts;\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex ac2a9421..67ccc9ae 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -41,7 +41,7 @@ class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n {\n public:\n \tIPASoftSimple()\n-\t\t: context_({ {}, {}, { kMaxFrameContexts } })\n+\t\t: context_(kMaxFrameContexts)\n \t{\n \t}\n \n", "prefixes": [ "v5", "1/4" ] }