Patch Detail
Show a patch.
GET /api/1.1/patches/22110/?format=api
{ "id": 22110, "url": "https://patchwork.libcamera.org/api/1.1/patches/22110/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22110/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241127085017.2192069-5-paul.elder@ideasonboard.com>", "date": "2024-11-27T08:50:17", "name": "[v2,4/4] apps: cam: Print control direction information", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7eab01faec5bdc6c31baf9df6b17f1c1de3e001c", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22110/mbox/", "series": [ { "id": 4827, "url": "https://patchwork.libcamera.org/api/1.1/series/4827/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4827", "date": "2024-11-27T08:50:13", "name": "Add direction field to ControlId", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4827/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22110/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22110/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05FDDC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Nov 2024 08:50:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55256660BA;\n\tWed, 27 Nov 2024 09:50:38 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 351A1660A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Nov 2024 09:50:34 +0100 (CET)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:7dcc:a4ea:e361:d355])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B99B78C;\n\tWed, 27 Nov 2024 09:50:09 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"caEjc5r9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732697411;\n\tbh=cX5nQSRcDWO83OY0jrG9fUL+Knpo/lbJOy42ShydeSE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=caEjc5r9maS3LqQCmtqxpICkSV+MWveQaJjFXlySvQ2cTC01nlsWeqf66opImNu3K\n\tGlxaWBYc15vcq6M8Qt0M6y58uy4UtGfDhwz04nb7L/jO7x9rDV5+OQZZxM5hFslX4X\n\tsRXCx5aai09DgeNnylpebq12aKgb6/PAueURIgVc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v2 4/4] apps: cam: Print control direction information", "Date": "Wed, 27 Nov 2024 17:50:17 +0900", "Message-Id": "<20241127085017.2192069-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20241127085017.2192069-1-paul.elder@ideasonboard.com>", "References": "<20241127085017.2192069-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that there is support for retrieving the allowed directions of a\ncontrol, print this information when listing controls.\n\nSample output:\n$ cam --list-controls -c 2\nUsing camera Virtual0 as cam0\nControl: [inout] draft::FaceDetectMode:\n - FaceDetectModeOff (0)\nControl: [in ] libcamera::FrameDurationLimits: [16666..33333]\n Size: 2\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- s/i/in/, s/o/out/ so that the output is easier to read\n---\n src/apps/cam/camera_session.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 6e9890ccfda1..9e93482775c3 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -159,12 +159,18 @@ CameraSession::~CameraSession()\n void CameraSession::listControls() const\n {\n \tfor (const auto &[id, info] : camera_->controls()) {\n+\t\tstd::stringstream io;\n+\t\tio << \"[\"\n+\t\t << (id->isInput() ? \"in\" : \" \")\n+\t\t << (id->isOutput() ? \"out\" : \" \")\n+\t\t << \"] \";\n+\n \t\tif (info.values().empty()) {\n-\t\t\tstd::cout << \"Control: \"\n+\t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t << id->vendor() << \"::\" << id->name() << \": \"\n \t\t\t\t << info.toString() << std::endl;\n \t\t} else {\n-\t\t\tstd::cout << \"Control: \"\n+\t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n \t\t\t\t << std::endl;\n \t\t\tfor (const auto &value : info.values()) {\n", "prefixes": [ "v2", "4/4" ] }