Patch Detail
Show a patch.
GET /api/1.1/patches/22093/?format=api
{ "id": 22093, "url": "https://patchwork.libcamera.org/api/1.1/patches/22093/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22093/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241126091509.89677-3-mzamazal@redhat.com>", "date": "2024-11-26T09:15:03", "name": "[v4,2/4] ipa: ipu3: Add constructor to the IPA context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c75c0d5ba6058dd0a4abdb11b3a028e4e965ebdb", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22093/mbox/", "series": [ { "id": 4821, "url": "https://patchwork.libcamera.org/api/1.1/series/4821/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4821", "date": "2024-11-26T09:15:01", "name": "Add contrast control to software ISP", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4821/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22093/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22093/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7616EC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Nov 2024 09:15:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E3FC65FD0;\n\tTue, 26 Nov 2024 10:15:31 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5123265F9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Nov 2024 10:15:25 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-607-ArToJL86O4-EYILrg0Tlaw-1;\n\tTue, 26 Nov 2024 04:15:22 -0500", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 894B519560B1; Tue, 26 Nov 2024 09:15:21 +0000 (UTC)", "from nuthatch.brq.redhat.com (unknown [10.43.17.31])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5D8881955F3E; Tue, 26 Nov 2024 09:15:20 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Th7mhgRw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1732612524;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=CaWLT54OfqD1XF4OV1Z8sRA7V0D3V3Sy/fK7f+VrdrA=;\n\tb=Th7mhgRwCYo490RXJaiwH149rgOX5BKAKM5+yDVpQ+nUoXbEcJ2fhZ3/trdX69Qbbe948P\n\tax0ew+ziLOC0OoI2ptclpGRFCfYfXFFxoj0jTVJW8qpCJEr/NBBpsWNeYR1Df0pWC6prF4\n\tF+dir/37j41hs8+lLZPUatfWdiuqKRU=", "X-MC-Unique": "ArToJL86O4-EYILrg0Tlaw-1", "X-Mimecast-MFC-AGG-ID": "ArToJL86O4-EYILrg0Tlaw", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 2/4] ipa: ipu3: Add constructor to the IPA context", "Date": "Tue, 26 Nov 2024 10:15:03 +0100", "Message-ID": "<20241126091509.89677-3-mzamazal@redhat.com>", "In-Reply-To": "<20241126091509.89677-1-mzamazal@redhat.com>", "References": "<20241126091509.89677-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "TnnQ4FDuwAHHQFtSvo6S520cPBQPRYsWTNdbkcHZarQ_1732612521", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's have a constructor that takes just the non-default argument,\nwithout the need to specify the defaults.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/ipu3/ipa_context.cpp | 4 ++++\n src/ipa/ipu3/ipa_context.h | 5 +++++\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 917d06541..76eeb52fe 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -39,6 +39,10 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAContext\n * \\brief Global IPA context data shared between all algorithms\n *\n+ * \\fn IPAContext::IPAContext\n+ * \\brief Initialize the instance with the given number of frame contexts\n+ * \\param[in] frameContextSize Size of the frame context ring buffer\n+ *\n * \\var IPAContext::configuration\n * \\brief The IPA session configuration, immutable during the session\n *\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex c85d1e34e..24f51a296 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -84,6 +84,11 @@ struct IPAFrameContext : public FrameContext {\n };\n \n struct IPAContext {\n+\tIPAContext(unsigned int frameContextSize)\n+\t\t: frameContexts(frameContextSize)\n+\t{\n+\t}\n+\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 89c3192c6..b65dea122 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -187,7 +187,7 @@ private:\n };\n \n IPAIPU3::IPAIPU3()\n-\t: context_({ {}, {}, { kMaxFrameContexts }, {} })\n+\t: context_(kMaxFrameContexts)\n {\n }\n \n", "prefixes": [ "v4", "2/4" ] }