Patch Detail
Show a patch.
GET /api/1.1/patches/22083/?format=api
{ "id": 22083, "url": "https://patchwork.libcamera.org/api/1.1/patches/22083/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22083/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241125180310.1254519-3-mzamazal@redhat.com>", "date": "2024-11-25T18:03:03", "name": "[v2,2/9] libcamera: software_isp: Store color temperature to metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3bb6c1c88896b5e8ece61683afd8c362e7e060e3", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22083/mbox/", "series": [ { "id": 4820, "url": "https://patchwork.libcamera.org/api/1.1/series/4820/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4820", "date": "2024-11-25T18:03:01", "name": "Software ISP support for CCM", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4820/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22083/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22083/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16329BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Nov 2024 18:03:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5C6E6603A;\n\tMon, 25 Nov 2024 19:03:32 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 295DE65F7C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 19:03:31 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-661-3Ctdf95PPcqP1hCLdY-AcQ-1;\n\tMon, 25 Nov 2024 13:03:26 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id DC901195604F; Mon, 25 Nov 2024 18:03:25 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.109])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 544551956086; Mon, 25 Nov 2024 18:03:24 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"KsyBHa2T\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1732557810;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=QNJCpZOST9RzzDb5ZifNelAOmIVM9PCUEa8YDg/JSuU=;\n\tb=KsyBHa2TaAMwvv1sgNPjJbTNObc95dreWk5YAEavapgoKJB9IN5wy84rGRI+JeqSxbkbu/\n\t3PS0GEHrLOTM+FC1A6BJ+sob5Yv8Tjqqh6lWMKLSg8T4oBAYFnexhk77WNMLzluzMjIouV\n\t9+b0a+lwHciBpHgAV8xz8LHolr3l4Pg=", "X-MC-Unique": "3Ctdf95PPcqP1hCLdY-AcQ-1", "X-Mimecast-MFC-AGG-ID": "3Ctdf95PPcqP1hCLdY-AcQ", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v2 2/9] libcamera: software_isp: Store color temperature to\n\tmetadata", "Date": "Mon, 25 Nov 2024 19:03:03 +0100", "Message-ID": "<20241125180310.1254519-3-mzamazal@redhat.com>", "In-Reply-To": "<20241125180310.1254519-1-mzamazal@redhat.com>", "References": "<20241125180310.1254519-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "F7ie-uf5Lonkh07CARiSwqLhenozC_U7aTnjoPIlv8U_1732557806", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Image color temperature is a piece of information that should be\nreported in metadata, let's put it there.\n\nMetadata is currently not reported in simple pipeline but we should make\nat least newly added information ready to be reported.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex db384c3fa..eef8277fc 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -12,6 +12,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include <libcamera/control_ids.h>\n+\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n@@ -34,7 +36,7 @@ void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n-\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t ControlList &metadata)\n {\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n@@ -60,8 +62,10 @@ void Awb::process(IPAContext &context,\n \tgains.blue = sumB <= sumG / 4 ? 4.0 : static_cast<double>(sumG) / sumB;\n \t/* Green gain is fixed to 1.0 */\n \n-\tcontext.activeState.awb.temperatureK =\n+\tuint32_t temperature =\n \t\testimateCCT(1 / gains.red, 1 / gains.green, 1 / gains.blue);\n+\tcontext.activeState.awb.temperatureK = temperature;\n+\tmetadata.set(controls::ColourTemperature, temperature);\n \n \tLOG(IPASoftAwb, Debug)\n \t\t<< \"gain R/B: \" << gains.red << \"/\" << gains.blue\n", "prefixes": [ "v2", "2/9" ] }