Patch Detail
Show a patch.
GET /api/1.1/patches/22060/?format=api
{ "id": 22060, "url": "https://patchwork.libcamera.org/api/1.1/patches/22060/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22060/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241124192950.542686-2-geoffrey.vl@gmail.com>", "date": "2024-11-24T19:29:46", "name": "[v3,1/5] libcamera: libipa: camera_sensor: Provide helper and properties for Sony IMX462", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "86a3823c113c038bbb33d6d0764c8355f8b5637a", "submitter": { "id": 214, "url": "https://patchwork.libcamera.org/api/1.1/people/214/?format=api", "name": "Geoffrey Van Landeghem", "email": "geoffrey.vl@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22060/mbox/", "series": [ { "id": 4815, "url": "https://patchwork.libcamera.org/api/1.1/series/4815/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4815", "date": "2024-11-24T19:29:45", "name": "Add support for Sony IMX327 and IMX462 sensors", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4815/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22060/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22060/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73A91C3309\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Nov 2024 19:29:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F3EF65FFB;\n\tSun, 24 Nov 2024 20:29:57 +0100 (CET)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1C2165FF5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Nov 2024 20:29:55 +0100 (CET)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-4349e4e252dso3658045e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Nov 2024 11:29:55 -0800 (PST)", "from localhost.localdomain\n\t(ptr-gh3gmp9ck9bx99mg7lb.18120a2.ip6.access.telenet.be.\n\t[2a02:1812:2512:400:400a:4d18:885b:f46f])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-433b463ab6csm169691645e9.35.2024.11.24.11.29.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 24 Nov 2024 11:29:53 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PwESr7pn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1732476595; x=1733081395;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VcDkuKRT4ytbvIib0/Z6yjLecAw8Etv2b5r9B+/ciRY=;\n\tb=PwESr7pnTlh9HGliJg2RoENJaqtd7UTI/2GvVQilDB0Lflxm3BmwGHItkgoY6Bzm2y\n\t5nMatga600NTC/MAr3mH2XtVrAmx0K3e5NehCEJtKg92MzXhVc2j3UrSl/uD680xkRp2\n\thG5yd84XthvS6YrWJ2RAJm7Ujn0bUzqpzExkQRx25UuSrCkl11N/cMfC7kgfF5qTBr/1\n\talTp/wT8mubl3QNrWgpveN9Utw+2vqFA0xdPjA2wl78wBoS52ke5a9rslChog/cnktLd\n\tehOlHSpFNPXC97C4oqoKG+hw6D8qtfd9sEKx1vGZ1xFwDFan/IQjGzLGsIXqwpeT40d9\n\tPQNQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732476595; x=1733081395;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=VcDkuKRT4ytbvIib0/Z6yjLecAw8Etv2b5r9B+/ciRY=;\n\tb=J1rX1WcUqvoaYNPx06TikGqXN7MLNxmJ4KvJfi4Zi/b/UwQWI350iGLUor8kLWU/r0\n\tge4h2uk+3VOXuKyZxFH5WTzzM5EVxaBntaRPbE9ids/MgDCGBp6fJxjjS8aajCZ+PRPd\n\tWfxu3BZIKgM+i1Zx/pNkZeM8kS12enJLQT3n1p1shv9Gy1POrq6c+bwJkHnATzE5GAuc\n\tBY4F+zYQ7rs6CJobKEGrwZ+QjG2bTvkvXYPHYsBKNgW4pgsHS8ED7yRmmgwS9O0aeWpE\n\tVTERhISXVuAxqoSu5zv0FeaYw4wyzpvI7HCT/EU69+tS7ETkLK6ym1vqGMM7R6AzlBec\n\t1hNQ==", "X-Gm-Message-State": "AOJu0Yy945w1LmwAu+u05f6ZFW9L2p8RkIWeGr+MQHeg3oxAXfak8mSu\n\tDJeyqKP6MbskNbNS+OFeVboTb3AoU8R+AJ4f0LwquiXEY4J0pgvYks1TtQ==", "X-Gm-Gg": "ASbGncvgHeHB4qd7wGXPFX0BC1HPnk9lsiyqzyePbSQqkQb32yvGnqv0Jt2mYKLmudy\n\tvJK/0H9k1Odq61nijoQwc7co2mcd4YThgcY56KOMDfJl2lvvGgY+qR0Fldv2HzS7nm4PgeyP+Sw\n\tbE1wrb+qBfO3RhMhW6ZbMPZzlVl5vL4MWjesyqINTnat1Y0SUCU8d+A6XoINocOPrj+9UJ+VxUh\n\tkWqcbfp3qZOLOPn6fjE49006PuffwOWRoycJA39KHDZ5b9gg/zRnb0p8GLNygEiwPMCtD3hyXCL\n\t4ODftOQsu/62nxWkQHXf4rGjD423eOPV91+ctayUERjfU47d/FU1GG0=", "X-Google-Smtp-Source": "AGHT+IEfYNvXDNXrSLrIoyu1/X2fvx5KgKtobQhp6f7iNidjTb30/5T+N7A3tdk2ufUH1sBJpMIvBA==", "X-Received": "by 2002:a05:600c:4704:b0:431:5a0e:fa2e with SMTP id\n\t5b1f17b1804b1-433ce49128cmr83961095e9.21.1732476595206; \n\tSun, 24 Nov 2024 11:29:55 -0800 (PST)", "From": "Geoffrey Van Landeghem <geoffrey.vl@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Geoffrey Van Landeghem <geoffrey.vl@gmail.com>", "Subject": "[PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper and\n\tproperties for Sony IMX462", "Date": "Sun, 24 Nov 2024 20:29:46 +0100", "Message-ID": "<20241124192950.542686-2-geoffrey.vl@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241124192950.542686-1-geoffrey.vl@gmail.com>", "References": "<20241124192950.542686-1-geoffrey.vl@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensor is largely compatible with the already supported\nSony IMX290 so we can reuse the same helpers for the analogue\ngain conversion functions.\n\nSigned-off-by: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex c6169bdc..f870dc28 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -622,6 +622,11 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n \n+class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\nindex e57ab538..0cc24a6d 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n@@ -73,3 +73,4 @@ static CamHelper *create()\n }\n \n static RegisterCamHelper reg(\"imx290\", &create);\n+static RegisterCamHelper reg462(\"imx462\", &create);\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6d4136d0..e2305166 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 1450, 1450 },\n \t\t\t.testPatternModes = {},\n \t\t} },\n+\t\t{ \"imx462\", {\n+\t\t\t.unitCellSize = { 2900, 2900 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n", "prefixes": [ "v3", "1/5" ] }