Patch Detail
Show a patch.
GET /api/1.1/patches/22021/?format=api
{ "id": 22021, "url": "https://patchwork.libcamera.org/api/1.1/patches/22021/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22021/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241120073806.3552478-3-chenghaoyang@chromium.org>", "date": "2024-11-20T07:37:00", "name": "[v4,2/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "391daf8be4a9f703048ac0592a0ada2f90334166", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22021/mbox/", "series": [ { "id": 4806, "url": "https://patchwork.libcamera.org/api/1.1/series/4806/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4806", "date": "2024-11-20T07:36:58", "name": "Add camera sensor properties for ciri", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4806/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22021/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22021/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87D0FC32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Nov 2024 07:38:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1974D65F3B;\n\tWed, 20 Nov 2024 08:38:20 +0100 (CET)", "from mail-ot1-x334.google.com (mail-ot1-x334.google.com\n\t[IPv6:2607:f8b0:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE05965F2E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Nov 2024 08:38:15 +0100 (CET)", "by mail-ot1-x334.google.com with SMTP id\n\t46e09a7af769-718186b5c4eso1773698a34.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 23:38:15 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7f8c1c16ef0sm8943445a12.1.2024.11.19.23.38.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 Nov 2024 23:38:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"MTBRueaQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732088294; x=1732693094;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pq9w8fCN7GOmaurR02IrcLHNIs7g7dAAqnTgBMOCv48=;\n\tb=MTBRueaQyUWrbXautdo4H8aTrsIrnAlrNHDsIFSYc1mKSbS22AYCbO7DtNtaaI3UOz\n\tC/z6cz3EXFj85LY65Ik71lRMpNhnDN/sjpYQCVmM0nivJKUIPmCNK/yQ5t9N68OQ0prz\n\tZQlAkbw4QQJbZKZRDNyd9j8ysPMPIfA/PbLLs=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732088294; x=1732693094;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pq9w8fCN7GOmaurR02IrcLHNIs7g7dAAqnTgBMOCv48=;\n\tb=YqRLjT0twsE0U8bjZeU6F9G17gK98d+tP09U3fMB0DF87i2RfcVQuOBEffrqxmpTPr\n\toQs22pCkDyPgIvG2fxUPhdNFAgnthcJdot8DezbSO1l4Cfmz4TcvK/WpT/rWu0kex3nr\n\tQIKue8JwcnlBz6jyKiiSlc/OCT+K4naZchf2EQfAj543HtHKLIacDeF5ngRLIhbJfesC\n\tvCnPe1KlLGQ8kOnf2keJPAnnbDVNVQ0ft9T/VxAof70R++QcFbCBoxWgcKBIxHf+cbXz\n\t7+0qqkD/xLUe6CbEYoxbPxy3tv1QygwaYtLGHwSj+WmIMVq8Aj+8z73cgfWCBeN0yIFH\n\twZhA==", "X-Gm-Message-State": "AOJu0Yyrzv5rKfpIhkGSzVmFXrxTJTi4n+aaPgXakmApdZjJySyl3BHa\n\t1vtVEb9XRuolYehIy0LwVqDYISbLM2xgkYJ/oYATx4tAe+0XbKzp2ySOWhGYQt0oETBle/cAsww\n\t=", "X-Google-Smtp-Source": "AGHT+IHKHoFaF4CRjq3kMUUlViKhN9GDwPFfmAXNL0WmhKnmkIp+Ql62K1gTKk6ru1aB+ROsCn8qXw==", "X-Received": "by 2002:a9d:6d01:0:b0:718:75f:9321 with SMTP id\n\t46e09a7af769-71ab31d209cmr1549663a34.18.1732088294447; \n\tTue, 19 Nov 2024 23:38:14 -0800 (PST)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHan-Lin Chen <hanlinchen@chromium.org>, Xing Gu <xinggu@chromium.org>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH v4 2/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc08a3 sensor properties", "Date": "Wed, 20 Nov 2024 07:37:00 +0000", "Message-ID": "<20241120073806.3552478-3-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.338.g60cca15819-goog", "In-Reply-To": "<20241120073806.3552478-1-chenghaoyang@chromium.org>", "References": "<20241120073806.3552478-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@google.com>\n\nProvide the GalaxyCore gc08a3 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Xing Gu <xinggu@chromium.org>\nCo-developed-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 7 +++++++\n 2 files changed, 19 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 904d5c978..6a2694953 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -531,6 +531,18 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n \n+class CameraSensorHelperGc08a3 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperGc08a3()\n+\t{\n+\t\tblackLevel_ = 64;\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 100, 0, 0, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 2f048d4a3..a15004341 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -77,6 +77,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"gc08a3\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "v4", "2/2" ] }