Patch Detail
Show a patch.
GET /api/1.1/patches/22001/?format=api
{ "id": 22001, "url": "https://patchwork.libcamera.org/api/1.1/patches/22001/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22001/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241119121928.30939-4-laurent.pinchart@ideasonboard.com>", "date": "2024-11-19T12:19:14", "name": "[v4,03/17] ipa: libipa: vector: Add scalar constructor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c8263712719c7aa379a762268521b97d1aefeb6a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22001/mbox/", "series": [ { "id": 4804, "url": "https://patchwork.libcamera.org/api/1.1/series/4804/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4804", "date": "2024-11-19T12:19:11", "name": "Improve linear algebra helpers in libipa", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4804/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22001/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22001/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2026C32F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Nov 2024 12:19:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56E9565F1C;\n\tTue, 19 Nov 2024 13:19:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4099065F0F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 13:19:49 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD3C93A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 13:19:31 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KJtqClml\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732018771;\n\tbh=x3yyJY2biqM3CiP/7f3m9bMOWo28lJ2IylXIXguAGUI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=KJtqClmligz8D8MATt6bWIX0LdpqOEps8wDvvXY1fjbxxbpfHIXjsLmjv/TjaKIr9\n\tXjLK3cuzk391D9877Ri+4iKCVLua/z9uIdESf2EzvsE3UHcz0opKQFD0GMnXFeCHS0\n\tqn18A1i7dzLhJYaYT88inibHcWfq4aVRecfFBV88=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v4 03/17] ipa: libipa: vector: Add scalar constructor", "Date": "Tue, 19 Nov 2024 14:19:14 +0200", "Message-ID": "<20241119121928.30939-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>", "References": "<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default constructor leaves the vector data uninitialized. Add a\nconstructor to fill the vector with copies of a scalar value, and fix\nthe documentation of the default constructor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v3:\n\n- Make the constructor explicit\n---\n src/ipa/libipa/vector.cpp | 8 +++++++-\n src/ipa/libipa/vector.h | 5 +++++\n 2 files changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 0f0511da151f..5851b9ae2ed3 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -29,7 +29,13 @@ namespace ipa {\n \n /**\n * \\fn Vector::Vector()\n- * \\brief Construct a zero vector\n+ * \\brief Construct an uninitialized vector\n+ */\n+\n+/**\n+ * \\fn Vector::Vector(T scalar)\n+ * \\brief Construct a vector filled with a \\a scalar value\n+ * \\param[in] scalar The scalar value\n */\n \n /**\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 3168835bc13d..5fb7ad7c95dd 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -35,6 +35,11 @@ class Vector\n public:\n \tconstexpr Vector() = default;\n \n+\tconstexpr explicit Vector(T scalar)\n+\t{\n+\t\tdata_.fill(scalar);\n+\t}\n+\n \tconstexpr Vector(const std::array<T, Rows> &data)\n \t{\n \t\tfor (unsigned int i = 0; i < Rows; i++)\n", "prefixes": [ "v4", "03/17" ] }