Patch Detail
Show a patch.
GET /api/1.1/patches/22000/?format=api
{ "id": 22000, "url": "https://patchwork.libcamera.org/api/1.1/patches/22000/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22000/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241119121928.30939-3-laurent.pinchart@ideasonboard.com>", "date": "2024-11-19T12:19:13", "name": "[v4,02/17] ipa: libipa: vector: Add r(), g() and b() accessors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "21a34c6f19a8e5ad201de3983f5df179e077e5bd", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22000/mbox/", "series": [ { "id": 4804, "url": "https://patchwork.libcamera.org/api/1.1/series/4804/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4804", "date": "2024-11-19T12:19:11", "name": "Improve linear algebra helpers in libipa", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4804/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22000/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22000/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA1D5C32F3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Nov 2024 12:19:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A81B65F18;\n\tTue, 19 Nov 2024 13:19:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68AD365F0B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 13:19:46 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA86622E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 13:19:28 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XPdfS2+X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732018768;\n\tbh=MsyZUPW6Dl4rDkqqA+BVqylCjodf0/V3CUtu7MoYCCg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=XPdfS2+X+WRIlPfMveYydUpJK3S+ZBblmgbGExmZvARbqjcbBcMVXRg17oJ0L+JX3\n\t4i8I+ra2yVJjmjsn5pW1yUoK6TJ/rUFps6A9hR136sG2FBfdCJpIDmGLwhypxsuLsF\n\tPZF909+PW+8v4Bo8hOxJlVo0ARu5S+o+jT7yptHE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v4 02/17] ipa: libipa: vector: Add r(), g() and b() accessors", "Date": "Tue, 19 Nov 2024 14:19:13 +0200", "Message-ID": "<20241119121928.30939-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>", "References": "<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Vector class can be useful to represent RGB pixel values. Add r(),\ng() and b() accessors, similar to x(), y() and z(), along with an RGB\ntype that aliases Vector<T, 3>.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n---\nChanges since v3:\n\n- Make non-const accessors constexpr\n---\n src/ipa/libipa/vector.cpp | 38 ++++++++++++++++++++++++++++++++++++++\n src/ipa/libipa/vector.h | 28 ++++++++++++++++++++++++++++\n 2 files changed, 66 insertions(+)", "diff": "diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex b650fcc1fe35..0f0511da151f 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -126,6 +126,39 @@ namespace ipa {\n * \\copydoc Vector::z()\n */\n \n+/**\n+ * \\fn constexpr T &Vector::r()\n+ * \\brief Convenience function to access the first element of the vector\n+ * \\return The first element of the vector\n+ */\n+\n+/**\n+ * \\fn constexpr T &Vector::g()\n+ * \\brief Convenience function to access the second element of the vector\n+ * \\return The second element of the vector\n+ */\n+\n+/**\n+ * \\fn constexpr T &Vector::b()\n+ * \\brief Convenience function to access the third element of the vector\n+ * \\return The third element of the vector\n+ */\n+\n+/**\n+ * \\fn constexpr const T &Vector::r() const\n+ * \\copydoc Vector::r()\n+ */\n+\n+/**\n+ * \\fn constexpr const T &Vector::g() const\n+ * \\copydoc Vector::g()\n+ */\n+\n+/**\n+ * \\fn constexpr const T &Vector::b() const\n+ * \\copydoc Vector::b()\n+ */\n+\n /**\n * \\fn Vector::length2()\n * \\brief Get the squared length of the vector\n@@ -149,6 +182,11 @@ namespace ipa {\n * \\return Product of matrix \\a m and vector \\a v\n */\n \n+/**\n+ * \\typedef RGB\n+ * \\brief A Vector of 3 elements representing an RGB pixel value\n+ */\n+\n /**\n * \\fn bool operator==(const Vector<T, Rows> &lhs, const Vector<T, Rows> &rhs)\n * \\brief Compare vectors for equality\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex b91e50b2e0ca..3168835bc13d 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -126,6 +126,31 @@ public:\n #endif /* __DOXYGEN__ */\n \tconstexpr T &z() { return data_[2]; }\n \n+#ifndef __DOXYGEN__\n+\ttemplate<bool Dependent = false, typename = std::enable_if_t<Dependent || Rows >= 1>>\n+#endif /* __DOXYGEN__ */\n+\tconstexpr const T &r() const { return data_[0]; }\n+#ifndef __DOXYGEN__\n+\ttemplate<bool Dependent = false, typename = std::enable_if_t<Dependent || Rows >= 2>>\n+#endif /* __DOXYGEN__ */\n+\tconstexpr const T &g() const { return data_[1]; }\n+#ifndef __DOXYGEN__\n+\ttemplate<bool Dependent = false, typename = std::enable_if_t<Dependent || Rows >= 3>>\n+#endif /* __DOXYGEN__ */\n+\tconstexpr const T &b() const { return data_[2]; }\n+#ifndef __DOXYGEN__\n+\ttemplate<bool Dependent = false, typename = std::enable_if_t<Dependent || Rows >= 1>>\n+#endif /* __DOXYGEN__ */\n+\tconstexpr T &r() { return data_[0]; }\n+#ifndef __DOXYGEN__\n+\ttemplate<bool Dependent = false, typename = std::enable_if_t<Dependent || Rows >= 2>>\n+#endif /* __DOXYGEN__ */\n+\tconstexpr T &g() { return data_[1]; }\n+#ifndef __DOXYGEN__\n+\ttemplate<bool Dependent = false, typename = std::enable_if_t<Dependent || Rows >= 3>>\n+#endif /* __DOXYGEN__ */\n+\tconstexpr T &b() { return data_[2]; }\n+\n \tconstexpr double length2() const\n \t{\n \t\tdouble ret = 0;\n@@ -143,6 +168,9 @@ private:\n \tstd::array<T, Rows> data_;\n };\n \n+template<typename T>\n+using RGB = Vector<T, 3>;\n+\n template<typename T, unsigned int Rows, unsigned int Cols>\n Vector<T, Rows> operator*(const Matrix<T, Rows, Cols> &m, const Vector<T, Cols> &v)\n {\n", "prefixes": [ "v4", "02/17" ] }