Patch Detail
Show a patch.
GET /api/1.1/patches/21976/?format=api
{ "id": 21976, "url": "https://patchwork.libcamera.org/api/1.1/patches/21976/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21976/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241118221618.13953-17-laurent.pinchart@ideasonboard.com>", "date": "2024-11-18T22:16:17", "name": "[v3,16/17] ipa: rkisp1: awb: Use Vector and Matrix for linear algebra", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f0af1b1421506169468c644c6acf11fc046b3f6e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21976/mbox/", "series": [ { "id": 4798, "url": "https://patchwork.libcamera.org/api/1.1/series/4798/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4798", "date": "2024-11-18T22:16:01", "name": "Improve linear algebra helpers in libipa", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4798/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21976/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21976/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E4CEC32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Nov 2024 22:17:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D043F65EE3;\n\tMon, 18 Nov 2024 23:17:04 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16B71658F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2024 23:16:50 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0353E8DB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2024 23:16:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rwuWEl2r\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731968193;\n\tbh=RNPG53cFIFiGz2WIvN4/531MeaV0mTQfhxjMRxaZ+DA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rwuWEl2r96rXNTZJGQ1PQrpXFw5oncuhMBA3e2Vrf9x/f6lLPd0lEM3pfFv0BP7Yj\n\tjKYVYmz11dGUvYx7kMDrmCZqJzvu2qHH3WmkcbPkAf1vEPAz3igLWBpNmzosUfjW8l\n\tBXKmWxSwWjBnaMzLX/ekiUUNMobX2pGJKZ/+QPdo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 16/17] ipa: rkisp1: awb: Use Vector and Matrix for linear\n\talgebra", "Date": "Tue, 19 Nov 2024 00:16:17 +0200", "Message-ID": "<20241118221618.13953-17-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>", "References": "<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace the manual vector and matrix calculations with usage of the\nVector and Matrix classes. This simplifies the code and improves\nreadability.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n---\nChanges since v2:\n\n- Split colour temperature estimation to separate patch\n- Update commit message\n\nChanges since v1:\n\n- Adapt to Vector::normalize() being dropped\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex c330feff9f5d..26d7b8138f17 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -203,9 +203,11 @@ void Awb::process(IPAContext &context,\n \t\t}};\n \t} else {\n \t\t/* Get the YCbCr mean values */\n-\t\tdouble yMean = awb->awb_mean[0].mean_y_or_g;\n-\t\tdouble cbMean = awb->awb_mean[0].mean_cb_or_b;\n-\t\tdouble crMean = awb->awb_mean[0].mean_cr_or_r;\n+\t\tVector<double, 3> yuvMeans({\n+\t\t\tstatic_cast<double>(awb->awb_mean[0].mean_y_or_g),\n+\t\t\tstatic_cast<double>(awb->awb_mean[0].mean_cb_or_b),\n+\t\t\tstatic_cast<double>(awb->awb_mean[0].mean_cr_or_r)\n+\t\t});\n \n \t\t/*\n \t\t * Convert from YCbCr to RGB.\n@@ -219,14 +221,16 @@ void Awb::process(IPAContext &context,\n \t\t * [1,1636, -0,4045, -0,7949]\n \t\t * [1,1636, 1,9912, -0,0250]]\n \t\t */\n-\t\tyMean -= 16;\n-\t\tcbMean -= 128;\n-\t\tcrMean -= 128;\n-\t\trgbMeans = {{\n-\t\t\t1.1636 * yMean - 0.0623 * cbMean + 1.6008 * crMean,\n-\t\t\t1.1636 * yMean - 0.4045 * cbMean - 0.7949 * crMean,\n-\t\t\t1.1636 * yMean + 1.9912 * cbMean - 0.0250 * crMean\n-\t\t}};\n+\t\tstatic const Matrix<double, 3, 3> yuv2rgbMatrix({\n+\t\t\t1.1636, -0.0623, 1.6008,\n+\t\t\t1.1636, -0.4045, -0.7949,\n+\t\t\t1.1636, 1.9912, -0.0250\n+\t\t});\n+\t\tstatic const Vector<double, 3> yuv2rgbOffset({\n+\t\t\t16, 128, 128\n+\t\t});\n+\n+\t\trgbMeans = yuv2rgbMatrix * (yuvMeans - yuv2rgbOffset);\n \n \t\t/*\n \t\t * Due to hardware rounding errors in the YCbCr means, the\n", "prefixes": [ "v3", "16/17" ] }