Patch Detail
Show a patch.
GET /api/1.1/patches/21968/?format=api
{ "id": 21968, "url": "https://patchwork.libcamera.org/api/1.1/patches/21968/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21968/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241118221618.13953-9-laurent.pinchart@ideasonboard.com>", "date": "2024-11-18T22:16:09", "name": "[v3,08/17] ipa: libipa: vector: Add compound assignment operators", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5a6a2a6bd62f912dd95d66534bf14f97fc2ca721", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21968/mbox/", "series": [ { "id": 4798, "url": "https://patchwork.libcamera.org/api/1.1/series/4798/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4798", "date": "2024-11-18T22:16:01", "name": "Improve linear algebra helpers in libipa", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4798/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21968/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21968/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7341BC32F0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Nov 2024 22:16:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 815A465ED9;\n\tMon, 18 Nov 2024 23:16:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 361EF65902\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2024 23:16:39 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DC0F6DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2024 23:16:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aI4wdJlB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731968182;\n\tbh=WZPXj2Nuz3Z3KOJiIMd6JFdDT9rTF9Sb3WJ1nfRI+jI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=aI4wdJlBRpjWh+nF04xxyKCQ9IXrHH+2gPQlqYrx+cWLZfg8QL1pXWjcRUq14NgnW\n\tY+WrzAbYPck6baUIsFSi5y5R6XoEWI6OgpgsfEP3+Rf4JQRT3jK85BMzqX0BnvpWHu\n\tR9gFCEPNbqxD6GAq8pop/Hd+9ZHMMWKUJlnUK3sE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 08/17] ipa: libipa: vector: Add compound assignment\n\toperators", "Date": "Tue, 19 Nov 2024 00:16:09 +0200", "Message-ID": "<20241118221618.13953-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>", "References": "<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Extend the Vector class with compound assignment operators that match\nthe binary arithmetic operators.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n---\nChanges since v2:\n\n- Use std::plus, std::minus, std::multiplies and std::divides\n---\n src/ipa/libipa/vector.cpp | 56 ++++++++++++++++++++++++++++++++++++++\n src/ipa/libipa/vector.h | 57 +++++++++++++++++++++++++++++++++++++++\n 2 files changed, 113 insertions(+)", "diff": "diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex d8f7ce951d60..64ffcf5036a4 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -133,6 +133,62 @@ namespace ipa {\n * \\return The element-wise division of this vector by \\a scalar\n */\n \n+/**\n+ * \\fn Vector::operator+=(Vector const &other)\n+ * \\brief Add \\a other element-wise to this vector\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator+=(T scalar)\n+ * \\brief Add \\a scalar element-wise to this vector\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator-=(Vector const &other)\n+ * \\brief Subtract \\a other element-wise from this vector\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator-=(T scalar)\n+ * \\brief Subtract \\a scalar element-wise from this vector\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator*=(const Vector &other)\n+ * \\brief Multiply this vector by \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator*=(T scalar)\n+ * \\brief Multiply this vector by \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator/=(const Vector &other)\n+ * \\brief Divide this vector by \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator/=(T scalar)\n+ * \\brief Divide this vector by \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n /**\n * \\fn Vector::dot(const Vector<T, Rows> &other) const\n * \\brief Compute the dot product\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 88f2a03fe579..15f511653b60 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -120,6 +120,46 @@ public:\n \t\treturn apply(*this, scalar, std::divides<>{});\n \t}\n \n+\tVector &operator+=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a + b; });\n+\t}\n+\n+\tVector &operator+=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a + b; });\n+\t}\n+\n+\tVector &operator-=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a - b; });\n+\t}\n+\n+\tVector &operator-=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a - b; });\n+\t}\n+\n+\tVector &operator*=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a * b; });\n+\t}\n+\n+\tVector &operator*=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a * b; });\n+\t}\n+\n+\tVector &operator/=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a / b; });\n+\t}\n+\n+\tVector &operator/=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a / b; });\n+\t}\n+\n \tconstexpr T dot(const Vector<T, Rows> &other) const\n \t{\n \t\tT ret = 0;\n@@ -212,6 +252,23 @@ private:\n \t\treturn result;\n \t}\n \n+\tVector &apply(const Vector &other, std::function<T(T, T)> func)\n+\t{\n+\t\tauto itOther = other.data_.begin();\n+\t\tstd::for_each(data_.begin(), data_.end(),\n+\t\t\t [&func, &itOther](T &v) { v = func(v, *itOther++); });\n+\n+\t\treturn *this;\n+\t}\n+\n+\tVector &apply(T scalar, std::function<T(T, T)> func)\n+\t{\n+\t\tstd::for_each(data_.begin(), data_.end(),\n+\t\t\t [&func, scalar](T &v) { v = func(v, scalar); });\n+\n+\t\treturn *this;\n+\t}\n+\n \tstd::array<T, Rows> data_;\n };\n \n", "prefixes": [ "v3", "08/17" ] }