Patch Detail
Show a patch.
GET /api/1.1/patches/21936/?format=api
{ "id": 21936, "url": "https://patchwork.libcamera.org/api/1.1/patches/21936/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21936/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241117221712.29616-7-laurent.pinchart@ideasonboard.com>", "date": "2024-11-17T22:17:07", "name": "[RFC,06/11] ipa: libipa: vector: Add missing binary arithemtic operators", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "063ba1f6a9aadf3c739fa1cf8f2dd25a8c2f8259", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21936/mbox/", "series": [ { "id": 4795, "url": "https://patchwork.libcamera.org/api/1.1/series/4795/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4795", "date": "2024-11-17T22:17:01", "name": "Improve linear algebra helpers in libipa", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4795/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21936/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21936/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4424DC32DF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 17 Nov 2024 22:17:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B60C658B7;\n\tSun, 17 Nov 2024 23:17:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5898C658AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 17 Nov 2024 23:17:30 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B3447FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 17 Nov 2024 23:17:13 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sr+6yPy9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731881834;\n\tbh=9MiINevDfChBdv5qVOrHFrk3D/8r4l9JnlU7vz9WSx8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Sr+6yPy9IrQICMMnT3hftXw16c9TE1LRPKOKuXij/cS1aTsgPHK/UFTo2mMqymQm5\n\tJs4OVgUQmyLJW2iEBaqVDZHf6lgKUUa8KSkcY5WK20sWrWa0lTWqQtQq9gJa8O8ueq\n\ts8b9ucZfszlSZPATVH1v3VgaG50WRvNTjD+NDBwk=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH 06/11] ipa: libipa: vector: Add missing binary arithemtic\n\toperators", "Date": "Mon, 18 Nov 2024 00:17:07 +0200", "Message-ID": "<20241117221712.29616-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241117221712.29616-1-laurent.pinchart@ideasonboard.com>", "References": "<20241117221712.29616-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Vector class defines multiple element-wise arithmetic operators\nbetween vectors or between a vector and a scalar. A few variants are\nmissing. Add them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/vector.cpp | 54 +++++++++++++++++++++++++++++----------\n src/ipa/libipa/vector.h | 38 ++++++++++++++++++++-------\n 2 files changed, 70 insertions(+), 22 deletions(-)", "diff": "diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex b2794c200b05..d0e38f402220 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -71,32 +71,60 @@ namespace ipa {\n * \\return The negated vector\n */\n \n+/**\n+ * \\fn Vector::operator+(Vector const &other) const\n+ * \\brief Calculate the sum of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise sum of this vector and \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::operator+(T scalar) const\n+ * \\brief Calculate the sum of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise sum of this vector and \\a other\n+ */\n+\n /**\n * \\fn Vector::operator-(Vector const &other) const\n- * \\brief Subtract one vector from another\n+ * \\brief Calculate the difference of this vector and \\a other element-wise\n * \\param[in] other The other vector\n- * \\return The difference of \\a other from this vector\n+ * \\return The element-wise subtraction of \\a other from this vector\n */\n \n /**\n- * \\fn Vector::operator+()\n- * \\brief Add two vectors together\n+ * \\fn Vector::operator-(T scalar) const\n+ * \\brief Calculate the difference of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise subtraction of \\a scalar from this vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator*(const Vector &other) const\n+ * \\brief Calculate the product of this vector and \\a other element-wise\n * \\param[in] other The other vector\n- * \\return The sum of the two vectors\n+ * \\return The element-wise product of this vector and \\a other\n */\n \n /**\n- * \\fn Vector::operator*(T factor) const\n- * \\brief Multiply the vector by a scalar\n- * \\param[in] factor The factor\n- * \\return The vector multiplied by \\a factor\n+ * \\fn Vector::operator*(T scalar) const\n+ * \\brief Calculate the product of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise product of this vector and \\a scalar\n */\n \n /**\n- * \\fn Vector::operator/()\n- * \\brief Divide the vector by a scalar\n- * \\param[in] factor The factor\n- * \\return The vector divided by \\a factor\n+ * \\fn Vector::operator/(const Vector &other) const\n+ * \\brief Calculate the quotient of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise division of this vector by \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::operator/(T scalar) const\n+ * \\brief Calculate the quotient of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise division of this vector by \\a scalar\n */\n \n /**\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 8c4edfbaf85f..dda49b1f468b 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -74,24 +74,44 @@ public:\n \t\treturn ret;\n \t}\n \n-\tconstexpr Vector operator-(const Vector &other) const\n-\t{\n-\t\treturn apply(*this, other, [](T a, T b) { return a - b; });\n-\t}\n-\n \tconstexpr Vector operator+(const Vector &other) const\n \t{\n \t\treturn apply(*this, other, [](T a, T b) { return a + b; });\n \t}\n \n-\tconstexpr Vector operator*(T factor) const\n+\tconstexpr Vector operator+(T scalar) const\n \t{\n-\t\treturn apply(*this, factor, [](T a, T b) { return a * b; });\n+\t\treturn apply(*this, scalar, [](T a, T b) { return a + b; });\n \t}\n \n-\tconstexpr Vector operator/(T factor) const\n+\tconstexpr Vector operator-(const Vector &other) const\n \t{\n-\t\treturn apply(*this, factor, [](T a, T b) { return a / b; });\n+\t\treturn apply(*this, other, [](T a, T b) { return a - b; });\n+\t}\n+\n+\tconstexpr Vector operator-(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) { return a - b; });\n+\t}\n+\n+\tconstexpr Vector operator*(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, [](T a, T b) { return a * b; });\n+\t}\n+\n+\tconstexpr Vector operator*(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) { return a * b; });\n+\t}\n+\n+\tconstexpr Vector operator/(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, [](T a, T b) { return a / b; });\n+\t}\n+\n+\tconstexpr Vector operator/(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) { return a / b; });\n \t}\n \n \tconstexpr T dot(const Vector<T, Rows> &other) const\n", "prefixes": [ "RFC", "06/11" ] }