Patch Detail
Show a patch.
GET /api/1.1/patches/21908/?format=api
{ "id": 21908, "url": "https://patchwork.libcamera.org/api/1.1/patches/21908/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21908/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241115101334.453104-5-dan.scally@ideasonboard.com>", "date": "2024-11-15T10:13:24", "name": "[v6,04/14] libcamera: mali-c55: Simplify bufferReady()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9c8ac22179241956c6f87fbeeef692ede126f6b6", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21908/mbox/", "series": [ { "id": 4793, "url": "https://patchwork.libcamera.org/api/1.1/series/4793/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4793", "date": "2024-11-15T10:13:20", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4793/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21908/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21908/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB0C9C32CE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Nov 2024 10:14:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B47E65886;\n\tFri, 15 Nov 2024 11:13:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFF036586C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Nov 2024 11:13:48 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43EE21114;\n\tFri, 15 Nov 2024 11:13:34 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PFQRkBPT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731665614;\n\tbh=hquK9PGF8VK4hnbDPiF0tdxZq2zhcxSdUi1q/tVBgd8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PFQRkBPTXVPjd4poh8nxpT2ji7Y0qitZGIt9Fsm3H9uZcvVA/Lwv3fqM+0RwV4zHN\n\tQX6dtX1A8JzxzO4ckq3qg3xVKiJuaJV9+TI9CHDMQisYB+y/Tfsq0wBKAEaQKDzVoz\n\tK7nSHbmRUQubf3AJ1yK7tqcyLJueUDfpt70kGcWs=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Anthony.McGivern@arm.com, Daniel Scally <dan.scally@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v6 04/14] libcamera: mali-c55: Simplify bufferReady()", "Date": "Fri, 15 Nov 2024 10:13:24 +0000", "Message-Id": "<20241115101334.453104-5-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241115101334.453104-1-dan.scally@ideasonboard.com>", "References": "<20241115101334.453104-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The PipelineHandler::completeBuffer() base class function returns\na boolean to indicate if there still are pending buffers in the\nRequest.\n\nSimplify the bufferReady() function in the Mali-C55 pipeline handler\nusing the completeBuffer() return value.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v6:\n\n\t- None\n\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 80cd98b3..7d0d0293 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -893,12 +893,8 @@ void PipelineHandlerMaliC55::imageBufferReady(FrameBuffer *buffer)\n {\n \tRequest *request = buffer->request();\n \n-\tcompleteBuffer(request, buffer);\n-\n-\tif (request->hasPendingBuffers())\n-\t\treturn;\n-\n-\tcompleteRequest(request);\n+\tif (completeBuffer(request, buffer))\n+\t\tcompleteRequest(request);\n }\n \n void PipelineHandlerMaliC55::registerMaliCamera(std::unique_ptr<MaliC55CameraData> data,\n", "prefixes": [ "v6", "04/14" ] }