Patch Detail
Show a patch.
GET /api/1.1/patches/2187/?format=api
{ "id": 2187, "url": "https://patchwork.libcamera.org/api/1.1/patches/2187/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2187/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191013232755.3292-6-laurent.pinchart@ideasonboard.com>", "date": "2019-10-13T23:27:51", "name": "[libcamera-devel,05/10] test: v4l2_videodevice: controls: Use correct control range in check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "13262e9aa975f1569c73da24e8c63ea10b8f4d25", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2187/mbox/", "series": [ { "id": 534, "url": "https://patchwork.libcamera.org/api/1.1/series/534/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=534", "date": "2019-10-13T23:27:46", "name": "Merge V4L2ControlInfoMap and ControlInfoMap", "version": 1, "mbox": "https://patchwork.libcamera.org/series/534/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2187/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2187/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C67D6196E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Oct 2019 01:28:04 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28D7133A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Oct 2019 01:28:04 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1571009284;\n\tbh=/H7aqonVgd5lCv5aiG8/6QeUPuxnfX0i39jGFD3TiPw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tjdA7i0IqGUSjDhpDhyjqJw7Xo/J92welx/GuyKJBsCpCdAJ+Z1ggqQtGr65bcDJZ\n\thgJWloCbqusxOb9E797c7U6hBdpfI3txbqjMjVQe99Pt1FItFv5wzYfHayzTMjg/uO\n\tKtXtHVwXpJelwD3UV33ts7NLq51kby6qQZ2gOw/A=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 14 Oct 2019 02:27:51 +0300", "Message-Id": "<20191013232755.3292-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>", "References": "<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 05/10] test: v4l2_videodevice: controls:\n\tUse correct control range in check", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 13 Oct 2019 23:28:04 -0000" }, "content": "A value check on the V4L2_CID_CONTRAST control is using the brightness\ncontrol range. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/controls.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\nindex e59387ab9eba..3add6e67d2cf 100644\n--- a/test/v4l2_videodevice/controls.cpp\n+++ b/test/v4l2_videodevice/controls.cpp\n@@ -87,7 +87,7 @@ protected:\n \t\t}\n \n \t\tif (ctrls.get(V4L2_CID_BRIGHTNESS) != brightness.range().min() ||\n-\t\t ctrls.get(V4L2_CID_CONTRAST) != brightness.range().max() ||\n+\t\t ctrls.get(V4L2_CID_CONTRAST) != contrast.range().max() ||\n \t\t ctrls.get(V4L2_CID_SATURATION) != saturation.range().min().get<int32_t>() + 1) {\n \t\t\tcerr << \"Controls not updated when set\" << endl;\n \t\t\treturn TestFail;\n", "prefixes": [ "libcamera-devel", "05/10" ] }