Patch Detail
Show a patch.
GET /api/1.1/patches/21839/?format=api
{ "id": 21839, "url": "https://patchwork.libcamera.org/api/1.1/patches/21839/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21839/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241107105846.52287-7-dan.scally@ideasonboard.com>", "date": "2024-11-07T10:58:39", "name": "[v5,06/13] libcamera: mali-c55: Add stride and size to rawConfig", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cf43e8a19d82d68a5505a8d189dd94e114579283", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21839/mbox/", "series": [ { "id": 4776, "url": "https://patchwork.libcamera.org/api/1.1/series/4776/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4776", "date": "2024-11-07T10:58:33", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4776/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21839/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21839/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25CDCBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Nov 2024 10:59:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C2766546E;\n\tThu, 7 Nov 2024 11:59:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D142D65476\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Nov 2024 11:58:55 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8537F88;\n\tThu, 7 Nov 2024 11:58:46 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hjn4FsHh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977127;\n\tbh=KAiE/Dgl3oWDSyV/BXFyzqAc3ukv4LCM//njqjaXIgw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hjn4FsHhjdwzVLNDaKj1Gtf5xjDNesdPKRRpGmlNDUFptbg1/nZGlchUS6+5YA2aw\n\tAm6b8VslN+LHo49ERlEV8t7JRTtaIQI24Tnn40jUjBpOnnxob84uwi6SOoktY6SEmg\n\tbT7d5r+y6xzJ9tNIhXiTuSCilqeAuFIRw7DH32ec=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v5 06/13] libcamera: mali-c55: Add stride and size to\n\trawConfig", "Date": "Thu, 7 Nov 2024 10:58:39 +0000", "Message-Id": "<20241107105846.52287-7-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241107105846.52287-1-dan.scally@ideasonboard.com>", "References": "<20241107105846.52287-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Complete the RAW StreamConfiguration by populating the frame stride and\nthe frame size.\n\nSet the minimum required alignment to 4 bytes as the Mali C55 ISP output\nexpands RAW output to 16 bits and a RAW Bayer macro-pixel requires\ntwo samples to be complete.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 877a156c..28ad0172 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -367,6 +367,10 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \n \t\tmaxSize = rawSize;\n \n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n+\t\trawConfig->stride = info.stride(rawConfig->size.width, 0, 4);\n+\t\trawConfig->frameSize = info.frameSize(rawConfig->size, 4);\n+\n \t\trawConfig->setStream(const_cast<Stream *>(&data_->frStream_));\n \t\tfrPipeAvailable = false;\n \t}\n", "prefixes": [ "v5", "06/13" ] }