Patch Detail
Show a patch.
GET /api/1.1/patches/21834/?format=api
{ "id": 21834, "url": "https://patchwork.libcamera.org/api/1.1/patches/21834/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21834/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241107105846.52287-2-dan.scally@ideasonboard.com>", "date": "2024-11-07T10:58:34", "name": "[v5,01/13] libcamera: mali-c55: Limit max size to sensor resolution", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0d1de27224076e1ea206f122fdcbb4eb8341642b", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21834/mbox/", "series": [ { "id": 4776, "url": "https://patchwork.libcamera.org/api/1.1/series/4776/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4776", "date": "2024-11-07T10:58:33", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4776/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21834/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21834/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36864BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Nov 2024 10:59:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A4CF6547A;\n\tThu, 7 Nov 2024 11:58:56 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1227665466\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Nov 2024 11:58:54 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EC8E792;\n\tThu, 7 Nov 2024 11:58:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZhnqoFvF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977125;\n\tbh=Tgo1+go4F2Ac1dNvJhPZYUg4DRFXhEp89K5a7BvzrwQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZhnqoFvF8Tq7gtZdCpAvq37GeCkoc9nlIqY5Cl2rvPENe0EXxn0rwYyuZEIEk8LXT\n\tAFFA0v8G0q2aB1BVPOzyLuKSsSg9VSspFYdNr0/AIYQQ5sbISqMLb6hxIeR9zEmHBM\n\toBpcLqv7t1HYv151QCLrCFze+ScV4odqQslzfKM0=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 01/13] libcamera: mali-c55: Limit max size to sensor\n\tresolution", "Date": "Thu, 7 Nov 2024 10:58:34 +0000", "Message-Id": "<20241107105846.52287-2-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241107105846.52287-1-dan.scally@ideasonboard.com>", "References": "<20241107105846.52287-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThe Mali C55 ISP cannot upscale. The maximum allowed output size\nis the sensor's resolution.\n\nFor RAW streams this is already handled in adjustRawSizes(), while\nfor processed streams the maximum allowed resolution was wrongly\nset to the ISP maximum output size (8192x8192).\n\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 45c71c1d..1c1fef23 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -342,7 +342,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\trawConfig = &config;\n \t}\n \n-\tSize maxSize = kMaliC55MaxSize;\n+\t/*\n+\t * The C55 can not upscale. Limit the configuration to the ISP\n+\t * capabilities and the sensor resolution.\n+\t */\n+\tSize maxSize = kMaliC55MaxSize.boundedTo(data_->resolution());\n \tif (rawConfig) {\n \t\t/*\n \t\t * \\todo Take into account the Bayer components ordering once\n", "prefixes": [ "v5", "01/13" ] }