Patch Detail
Show a patch.
GET /api/1.1/patches/21830/?format=api
{ "id": 21830, "url": "https://patchwork.libcamera.org/api/1.1/patches/21830/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21830/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241107102508.48322-5-dan.scally@ideasonboard.com>", "date": "2024-11-07T10:25:06", "name": "[v2,4/6] ipa: rpi: Use centralised libipa helpers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9984f6a32159ef00c3d8e0907d063d4216e9d128", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21830/mbox/", "series": [ { "id": 4775, "url": "https://patchwork.libcamera.org/api/1.1/series/4775/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4775", "date": "2024-11-07T10:25:03", "name": "Centralise common functions in IPA modules", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4775/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21830/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21830/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2BBEBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Nov 2024 10:25:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D4396547A;\n\tThu, 7 Nov 2024 11:25:31 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DBC765466\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Nov 2024 11:25:25 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83DF35B3;\n\tThu, 7 Nov 2024 11:25:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v6CnzBal\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730975116;\n\tbh=mD+Z0ouAQECHnuk0+cWyhyDiBcfqd4axufnS7EXoZo4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=v6CnzBalIdmc9J/SNUpwlJNaAZ9TJOxuvh3bIbh3wXMZXD99DLYBB9JPUvhlFe5zn\n\t7z/cPhcnB1lg+bzrd3gXJhjBSzdCL2QCg+pekSXamPJ2ubmNkLuBr+C21T0OY9lMSE\n\tgWGlAryXFTqjBouV3ihpZPhhUygAtoW2OSE4kFWc=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "mike.rudenko@gmail.com,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v2 4/6] ipa: rpi: Use centralised libipa helpers", "Date": "Thu, 7 Nov 2024 10:25:06 +0000", "Message-Id": "<20241107102508.48322-5-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241107102508.48322-1-dan.scally@ideasonboard.com>", "References": "<20241107102508.48322-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the centralised libipa helpers rather than open coding common\nfunctions.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges in v2:\n\n\t- None. Jacopo; this isn't in the libcamera::ipa namespace. As an\n\t alternative to the prefix I could \"using namespace libcamera::ipa\" if\n\t that's better?\n\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\nindex c9df9b5b..30e94b9b 100644\n--- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n@@ -12,6 +12,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include \"libipa/helpers.h\"\n+\n #include \"../awb_status.h\"\n #include \"../device_status.h\"\n #include \"../histogram.h\"\n@@ -694,11 +696,11 @@ static double computeInitialY(StatisticsPtr &stats, AwbStatus const &awb,\n \tdouble ySum;\n \t/* Factor in the AWB correction if needed. */\n \tif (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb) {\n-\t\tySum = rSum * awb.gainR * .299 +\n-\t\t gSum * awb.gainG * .587 +\n-\t\t bSum * awb.gainB * .114;\n+\t\tySum = ipa::rec601LuminanceFromRGB(rSum * awb.gainR,\n+\t\t\t\t\t gSum * awb.gainG,\n+\t\t\t\t\t bSum * awb.gainB);\n \t} else\n-\t\tySum = rSum * .299 + gSum * .587 + bSum * .114;\n+\t\tySum = ipa::rec601LuminanceFromRGB(rSum, gSum, bSum);\n \n \treturn ySum / pixelSum / (1 << 16);\n }\n", "prefixes": [ "v2", "4/6" ] }