Patch Detail
Show a patch.
GET /api/1.1/patches/21771/?format=api
{ "id": 21771, "url": "https://patchwork.libcamera.org/api/1.1/patches/21771/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21771/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241029161117.1197603-2-chenghaoyang@chromium.org>", "date": "2024-10-29T16:07:12", "name": "[v5,1/2] libcamera: Extend u32 control type", "commit_ref": "86902b39d7cd6701139f3de3a4ef4da57f2502ed", "pull_url": null, "state": "accepted", "archived": false, "hash": "64878aa1363e2290f2decd89d71a07201ab19207", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21771/mbox/", "series": [ { "id": 4753, "url": "https://patchwork.libcamera.org/api/1.1/series/4753/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4753", "date": "2024-10-29T16:07:11", "name": "Add U16 & U32 support in controls", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4753/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21771/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21771/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B63EEC32C8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Oct 2024 16:11:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9EDB653AB;\n\tTue, 29 Oct 2024 17:11:28 +0100 (CET)", "from mail-pl1-x633.google.com (mail-pl1-x633.google.com\n\t[IPv6:2607:f8b0:4864:20::633])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C74F8618C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Oct 2024 17:11:24 +0100 (CET)", "by mail-pl1-x633.google.com with SMTP id\n\td9443c01a7336-20cdbe608b3so45849285ad.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Oct 2024 09:11:24 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(199.211.81.34.bc.googleusercontent.com. [34.81.211.199])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-210bc04575esm68048695ad.235.2024.10.29.09.11.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 29 Oct 2024 09:11:22 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"THjTIEB+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1730218283; x=1730823083;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Xz9kMxCBhl9gscklDV7eb8zlWMgTXtTcQB2iyl2YEPA=;\n\tb=THjTIEB+gQtf7fINF7XQnFLJ9joSTTq50InRgskLuMuUa6SRn1ESMebj9ljKIvmZNe\n\tM5att5za79x2TQ7txYxiUcnk2OjNZpfyqy43ZUlTLYGlYZMuPu+Js93/ImdCrbmU0lu6\n\toKgonY4qVx5AuFLtNOJmSE1Z/8efCAapvCsLE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730218283; x=1730823083;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Xz9kMxCBhl9gscklDV7eb8zlWMgTXtTcQB2iyl2YEPA=;\n\tb=pAMQGNEZ9QL/ay/wVQvhNQWy92GMEj+vQhojXB2k9ASf5t6+wIjECnCMjoEXM6Yg30\n\t1CqrYk6uVvGl1/n8S2FX+suseyeQzPxs5aw5Z60ZrTlbmj1n4vFEiN5+Ve+oCI1FXQOa\n\tRIqdgGYf8FIYz50WeDGzJpxjkXJOns0m8EQ+Lfqfrmin4JjpliXl9zHHDcp6JWBfX9YB\n\tG6ko3hNEQhbmQ+eFEyBAmyhWnG1N128rK1rk3/mRWQO2KYYTKwP7rDX8kqg1cWOvXxqz\n\t6kq9FBAUe/h2xkkTRWlrW4fvqCrIMi7s+ncFoo/z1abLRtEHX4Vf2HO7to2Y7oBIvviL\n\tPUeQ==", "X-Gm-Message-State": "AOJu0YwMY2bFB3fgzDLli19xxsoQhQ01YJeepkQlyBQZGpCBgJHYXpcq\n\tKeKyK9ITOggjCJZ5jSp95PSBvVX1k+NQ4qNwscFzkMdNkOPiOWzxUSjkgl6JawTREJvj31H7RSY\n\t=", "X-Google-Smtp-Source": "AGHT+IHpRHiZOZyJJphN5kaRfnFW8p8324MTlkL5PwDfMdhyJLvN32moxw5q+3PPV5FVUEQKs2agxg==", "X-Received": "by 2002:a17:902:ecd0:b0:20c:5cdd:a91 with SMTP id\n\td9443c01a7336-210c6c69506mr160340675ad.41.1730218282982; \n\tTue, 29 Oct 2024 09:11:22 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Yudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH v5 1/2] libcamera: Extend u32 control type", "Date": "Tue, 29 Oct 2024 16:07:12 +0000", "Message-ID": "<20241029161117.1197603-2-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.163.g1226f6d8fa-goog", "In-Reply-To": "<20241029161117.1197603-1-chenghaoyang@chromium.org>", "References": "<20241029161117.1197603-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Yudhistira Erlandinata <yerlandinata@chromium.org>\n\nV4L2 Controls support a wide variety of types not yet supported by the\nControlValue type system.\n\nExtend the libcamera ControlValue types to support an explicit 32 bit\nunsigned integer type, and map that to the corresponding\nV4L2_CTRL_TYPE_U32 type within the v4l2_device support class.\n\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/controls.h | 7 ++++++\n src/libcamera/controls.cpp | 12 ++++++++--\n src/libcamera/v4l2_device.cpp | 39 +++++++++++++++++++++++++++-----\n test/controls/control_value.cpp | 40 +++++++++++++++++++++++++++++++++\n 4 files changed, 91 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ca60bbaca..6da8ad2c3 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -29,6 +29,7 @@ enum ControlType {\n \tControlTypeNone,\n \tControlTypeBool,\n \tControlTypeByte,\n+\tControlTypeUnsigned32,\n \tControlTypeInteger32,\n \tControlTypeInteger64,\n \tControlTypeFloat,\n@@ -62,6 +63,12 @@ struct control_type<uint8_t> {\n \tstatic constexpr std::size_t size = 0;\n };\n \n+template<>\n+struct control_type<uint32_t> {\n+\tstatic constexpr ControlType value = ControlTypeUnsigned32;\n+\tstatic constexpr std::size_t size = 0;\n+};\n+\n template<>\n struct control_type<int32_t> {\n \tstatic constexpr ControlType value = ControlTypeInteger32;\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 62185d643..8ae295191 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -54,6 +54,7 @@ static constexpr size_t ControlValueSize[] = {\n \t[ControlTypeNone]\t\t= 0,\n \t[ControlTypeBool]\t\t= sizeof(bool),\n \t[ControlTypeByte]\t\t= sizeof(uint8_t),\n+\t[ControlTypeUnsigned32]\t\t= sizeof(uint32_t),\n \t[ControlTypeInteger32]\t\t= sizeof(int32_t),\n \t[ControlTypeInteger64]\t\t= sizeof(int64_t),\n \t[ControlTypeFloat]\t\t= sizeof(float),\n@@ -74,10 +75,12 @@ static constexpr size_t ControlValueSize[] = {\n * The control stores a boolean value\n * \\var ControlTypeByte\n * The control stores a byte value as an unsigned 8-bit integer\n+ * \\var ControlTypeUnsigned32\n+ * The control stores an unsigned 32-bit integer value\n * \\var ControlTypeInteger32\n- * The control stores a 32-bit integer value\n+ * The control stores a signed 32-bit integer value\n * \\var ControlTypeInteger64\n- * The control stores a 64-bit integer value\n+ * The control stores a signed 64-bit integer value\n * \\var ControlTypeFloat\n * The control stores a 32-bit floating point value\n * \\var ControlTypeString\n@@ -230,6 +233,11 @@ std::string ControlValue::toString() const\n \t\t\tstr += std::to_string(*value);\n \t\t\tbreak;\n \t\t}\n+\t\tcase ControlTypeUnsigned32: {\n+\t\t\tconst uint32_t *value = reinterpret_cast<const uint32_t *>(data);\n+\t\t\tstr += std::to_string(*value);\n+\t\t\tbreak;\n+\t\t}\n \t\tcase ControlTypeInteger32: {\n \t\t\tconst int32_t *value = reinterpret_cast<const int32_t *>(data);\n \t\t\tstr += std::to_string(*value);\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 68add4f2e..90fa6b278 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -9,6 +9,7 @@\n \n #include <fcntl.h>\n #include <map>\n+#include <stdint.h>\n #include <stdlib.h>\n #include <string.h>\n #include <sys/ioctl.h>\n@@ -204,10 +205,22 @@ ControlList V4L2Device::getControls(const std::vector<uint32_t> &ids)\n \n \t\tif (info.flags & V4L2_CTRL_FLAG_HAS_PAYLOAD) {\n \t\t\tControlType type;\n+\t\t\tControlValue &value = ctrl.second;\n+\t\t\tSpan<uint8_t> data;\n \n \t\t\tswitch (info.type) {\n \t\t\tcase V4L2_CTRL_TYPE_U8:\n \t\t\t\ttype = ControlTypeByte;\n+\t\t\t\tvalue.reserve(type, true, info.elems);\n+\t\t\t\tdata = value.data();\n+\t\t\t\tv4l2Ctrl.p_u8 = data.data();\n+\t\t\t\tbreak;\n+\n+\t\t\tcase V4L2_CTRL_TYPE_U32:\n+\t\t\t\ttype = ControlTypeUnsigned32;\n+\t\t\t\tvalue.reserve(type, true, info.elems);\n+\t\t\t\tdata = value.data();\n+\t\t\t\tv4l2Ctrl.p_u32 = reinterpret_cast<uint32_t *>(data.data());\n \t\t\t\tbreak;\n \n \t\t\tdefault:\n@@ -217,11 +230,6 @@ ControlList V4L2Device::getControls(const std::vector<uint32_t> &ids)\n \t\t\t\treturn {};\n \t\t\t}\n \n-\t\t\tControlValue &value = ctrl.second;\n-\t\t\tvalue.reserve(type, true, info.elems);\n-\t\t\tSpan<uint8_t> data = value.data();\n-\n-\t\t\tv4l2Ctrl.p_u8 = data.data();\n \t\t\tv4l2Ctrl.size = data.size();\n \t\t}\n \t}\n@@ -299,6 +307,18 @@ int V4L2Device::setControls(ControlList *ctrls)\n \t\t/* Set the v4l2_ext_control value for the write operation. */\n \t\tControlValue &value = ctrl->second;\n \t\tswitch (iter->first->type()) {\n+\t\tcase ControlTypeUnsigned32: {\n+\t\t\tif (value.isArray()) {\n+\t\t\t\tSpan<uint8_t> data = value.data();\n+\t\t\t\tv4l2Ctrl.p_u32 = reinterpret_cast<uint32_t *>(data.data());\n+\t\t\t\tv4l2Ctrl.size = data.size();\n+\t\t\t} else {\n+\t\t\t\tv4l2Ctrl.value = value.get<uint32_t>();\n+\t\t\t}\n+\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tcase ControlTypeInteger32: {\n \t\t\tif (value.isArray()) {\n \t\t\t\tSpan<uint8_t> data = value.data();\n@@ -488,6 +508,9 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType)\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\treturn ControlTypeBool;\n \n+\tcase V4L2_CTRL_TYPE_U32:\n+\t\treturn ControlTypeUnsigned32;\n+\n \tcase V4L2_CTRL_TYPE_INTEGER:\n \t\treturn ControlTypeInteger32;\n \n@@ -536,6 +559,11 @@ std::optional<ControlInfo> V4L2Device::v4l2ControlInfo(const v4l2_query_ext_ctrl\n \t\t\t\t static_cast<uint8_t>(ctrl.maximum),\n \t\t\t\t static_cast<uint8_t>(ctrl.default_value));\n \n+\tcase V4L2_CTRL_TYPE_U32:\n+\t\treturn ControlInfo(static_cast<uint32_t>(ctrl.minimum),\n+\t\t\t\t static_cast<uint32_t>(ctrl.maximum),\n+\t\t\t\t static_cast<uint32_t>(ctrl.default_value));\n+\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\treturn ControlInfo(static_cast<bool>(ctrl.minimum),\n \t\t\t\t static_cast<bool>(ctrl.maximum),\n@@ -622,6 +650,7 @@ void V4L2Device::listControls()\n \t\tcase V4L2_CTRL_TYPE_BITMASK:\n \t\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n \t\tcase V4L2_CTRL_TYPE_U8:\n+\t\tcase V4L2_CTRL_TYPE_U32:\n \t\t\tbreak;\n \t\t/* \\todo Support other control types. */\n \t\tdefault:\ndiff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\nindex 344107fae..6ca85b739 100644\n--- a/test/controls/control_value.cpp\n+++ b/test/controls/control_value.cpp\n@@ -109,6 +109,46 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/*\n+\t\t * Unsigned Integer32 type.\n+\t\t */\n+\t\tvalue.set(static_cast<uint32_t>(42));\n+\t\tif (value.isNone() || value.isArray() ||\n+\t\t value.type() != ControlTypeUnsigned32) {\n+\t\t\tcerr << \"Control type mismatch after setting to uint32_t\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (value.get<uint32_t>() != 42) {\n+\t\t\tcerr << \"Control value mismatch after setting to uint32_t\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (value.toString() != \"42\") {\n+\t\t\tcerr << \"Control string mismatch after setting to uint32_t\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tstd::array<uint32_t, 4> uint32s{ 3, 14, 15, 9 };\n+\t\tvalue.set(Span<uint32_t>(uint32s));\n+\t\tif (value.isNone() || !value.isArray() ||\n+\t\t value.type() != ControlTypeUnsigned32) {\n+\t\t\tcerr << \"Control type mismatch after setting to uint32_t array\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tSpan<const uint32_t> uint32sResult = value.get<Span<const uint32_t>>();\n+\t\tif (uint32s.size() != uint32sResult.size() ||\n+\t\t !std::equal(uint32s.begin(), uint32s.end(), uint32sResult.begin())) {\n+\t\t\tcerr << \"Control value mismatch after setting to uint32_t array\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n+\t\t\tcerr << \"Control string mismatch after setting to uint32_t array\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\t/*\n \t\t * Integer32 type.\n \t\t */\n", "prefixes": [ "v5", "1/2" ] }