Patch Detail
Show a patch.
GET /api/1.1/patches/21731/?format=api
{ "id": 21731, "url": "https://patchwork.libcamera.org/api/1.1/patches/21731/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21731/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241022074544.3790451-8-chenghaoyang@chromium.org>", "date": "2024-10-22T07:43:43", "name": "[v16,7/7] libcamera: software_isp: Refactor SoftwareIsp to use DmaBufAllocator::exportBuffers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5f98528d63df8d5fec95e0c9da3bdff582bbd04e", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21731/mbox/", "series": [ { "id": 4733, "url": "https://patchwork.libcamera.org/api/1.1/series/4733/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4733", "date": "2024-10-22T07:43:36", "name": "Add VirtualPipelineHandler", "version": 16, "mbox": "https://patchwork.libcamera.org/series/4733/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21731/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21731/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41CC1C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Oct 2024 07:46:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47050653A1;\n\tTue, 22 Oct 2024 09:46:11 +0200 (CEST)", "from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com\n\t[IPv6:2607:f8b0:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B52456539F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Oct 2024 09:46:04 +0200 (CEST)", "by mail-pf1-x42b.google.com with SMTP id\n\td2e1a72fcca58-71e467c3996so3415802b3a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Oct 2024 00:46:04 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71ec13d75aesm4091024b3a.124.2024.10.22.00.46.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Oct 2024 00:46:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Uby7vJZC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729583163; x=1730187963;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=HrmXusUJJiZzQBUgzs8QoLmpgKh+y0IJMlqn1YYNqmA=;\n\tb=Uby7vJZC6/q+xx9RsxS/i6wWiP/FmNjfRxX/0ss07tgxSWPYRx8w+HrODbka98frCN\n\tc1s03H9tUSUV3oDzNlrsxuzbvyWwMjoP3SqkcSdnwfl3XZufGrjh1iEN87qR8m+prdqj\n\tGvXE0k7oO0GYPBwlVT0SBEKznKRVvwFzy05I0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729583163; x=1730187963;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=HrmXusUJJiZzQBUgzs8QoLmpgKh+y0IJMlqn1YYNqmA=;\n\tb=c0L0TiAG6dDXhKKku1poHfMPsTBiGSuwN3c9ocFigiytJV6ZQIlRHuiQrcEcQNcMDl\n\tULFwoBOVoAIpSEKteE5+J5FEVsNlrfcTt797YSao/R0nvRKwbNnCxO9OKM9f8N2j1Q5K\n\t8bCUYDgLeDkROM2FHrgKcf+bnhZwrfUFYQlI1dheA0OAgQXR0Y/DDksE6RhBYGrvtoX3\n\tQIjKHkO9+hdi3Zubr82HGHnUVac+u4Z1bjUQsX7WnXnZL8VAf0wfgc0C57WM/hdYox2U\n\tFs2amZQNyeFimmQZSiggTNLWb/AqHfUWIPqqP68kjGQ+WuM8KaytU/uV619F5ld2fNXR\n\ti6XA==", "X-Gm-Message-State": "AOJu0YwPjHRV7geMASLZLpU1br752OA4FkBrlsUFHFLybUGGTm1Jm8cP\n\tA4S/O5FFXKhBbrMtu0bYH8XiM8FcsQT/JDfSYqpj/zkG7WY9l3FA7laUG3RVOVnze2ppTg6uEvw\n\t=", "X-Google-Smtp-Source": "AGHT+IEZkbQX0NLERwh56u1tGvlCUkwNp53bwoslZ32UF56MVq5FwQ9ORJzs4Tp/aQ64ELHxTfsTzg==", "X-Received": "by 2002:a05:6a21:e8d:b0:1d9:6a6b:faf4 with SMTP id\n\tadf61e73a8af0-1d96a6bfb3fmr2910487637.15.1729583162982; \n\tTue, 22 Oct 2024 00:46:02 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v16 7/7] libcamera: software_isp: Refactor SoftwareIsp to use\n\tDmaBufAllocator::exportBuffers", "Date": "Tue, 22 Oct 2024 07:43:43 +0000", "Message-ID": "<20241022074544.3790451-8-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.105.g07ac214952-goog", "In-Reply-To": "<20241022074544.3790451-1-chenghaoyang@chromium.org>", "References": "<20241022074544.3790451-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As the helper function DmaBufAllocator::exportBuffers is added, we can\navoid some code duplication in SoftwareIsp as well.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 20 +-------------------\n 1 file changed, 1 insertion(+), 19 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 47677784d..5f58e5e40 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -256,25 +256,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n \tif (stream == nullptr)\n \t\treturn -EINVAL;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n-\t\tconst std::string name = \"frame-\" + std::to_string(i);\n-\t\tconst size_t frameSize = debayer_->frameSize();\n-\n-\t\tFrameBuffer::Plane outPlane;\n-\t\toutPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));\n-\t\tif (!outPlane.fd.isValid()) {\n-\t\t\tLOG(SoftwareIsp, Error)\n-\t\t\t\t<< \"failed to allocate a dma_buf\";\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t\toutPlane.offset = 0;\n-\t\toutPlane.length = frameSize;\n-\n-\t\tstd::vector<FrameBuffer::Plane> planes{ outPlane };\n-\t\tbuffers->emplace_back(std::make_unique<FrameBuffer>(std::move(planes)));\n-\t}\n-\n-\treturn count;\n+\treturn dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);\n }\n \n /**\n", "prefixes": [ "v16", "7/7" ] }