Patch Detail
Show a patch.
GET /api/1.1/patches/21669/?format=api
{ "id": 21669, "url": "https://patchwork.libcamera.org/api/1.1/patches/21669/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21669/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241018075942.1150378-5-chenghaoyang@chromium.org>", "date": "2024-10-18T07:57:37", "name": "[4/4] libcamera: Make Camera::Private::isAcquired() protected", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "347091236f15ea00e287045d29bea48053d07bff", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21669/mbox/", "series": [ { "id": 4715, "url": "https://patchwork.libcamera.org/api/1.1/series/4715/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4715", "date": "2024-10-18T07:57:33", "name": "IPC disconnect signals", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4715/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21669/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21669/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04299C32FF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Oct 2024 08:00:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5506465391;\n\tFri, 18 Oct 2024 10:00:03 +0200 (CEST)", "from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n\t[IPv6:2607:f8b0:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83A1E65396\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Oct 2024 09:59:56 +0200 (CEST)", "by mail-pg1-x52e.google.com with SMTP id\n\t41be03b00d2f7-7163489149eso1452971a12.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Oct 2024 00:59:56 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71ea345b0c3sm901274b3a.172.2024.10.18.00.59.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Oct 2024 00:59:54 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"iMiv3Jig\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729238395; x=1729843195;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=hfrj4edOfJQQuugH+68k4Cui4kLDvuRKByjOOu3KAFw=;\n\tb=iMiv3JigucTUJMriKyn4UPF83ubgM3eyZGgQSXPoTwihTKGlETp+b79QLGNvr7bkBD\n\tLfcB7NVrF4dLKlCkz7ks29iYJQu21ubkfvnBdR9+Rzq1PZnIRIwjbGzyavMCmTM1zxZr\n\tVJZG/RK6o+Ty61W2ci9RR3/UpkTTPvvyw1tdw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729238395; x=1729843195;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=hfrj4edOfJQQuugH+68k4Cui4kLDvuRKByjOOu3KAFw=;\n\tb=R63bZIGmLhSwjj3WlBXmUJV3AjhMKd01aUTci5enc6w6vvkMUC4NaQmmeSfggMr0p7\n\tYml/A+amYc9C/fXy2/2Vdaen5ctS4BmHuJeKDUgrg+biZUOaIM75isMleJKLPZj0h2Gx\n\tMqlmSSMxgMWEyV3btXfpcvE+pWUt7g0BFVsX2pNEp7FLwi0rihBXeEeqMHmF1zkMed5o\n\t9EpBDX3cjUPSCdskWweHNWRUI9OEjSX81+F681WA1nCLvMmbHX59IX/EMvfDKaEotWGG\n\t+n/EJcXV+/6qOuT0z2gGqraj+m75FFuX7Oq8mEVkv7HRjq5aEe3OkTN3/Fc9QD1LWcWL\n\t+uvg==", "X-Gm-Message-State": "AOJu0Yw5eeQFivyXe7FQLr2/zR1eZPlX4LIsZE7Mh2UvFMEiWaKu1nBL\n\tElilixmrO825n+9YkZ8z7WvuTi1IlCMtPXuO47VTX96HDsnL0ycELq421uT6zDtex4ps1M0I8ps\n\t=", "X-Google-Smtp-Source": "AGHT+IGMkGWtc4zZ0GJpKnPkLT9xm+q0yfOPE53hqYDrflXPHwAMVwHWqyaEzUy+FEjwVYhoncYyfQ==", "X-Received": "by 2002:a05:6a21:181a:b0:1d9:2846:997e with SMTP id\n\tadf61e73a8af0-1d92c4babf6mr1981600637.4.1729238394745; \n\tFri, 18 Oct 2024 00:59:54 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>", "Subject": "[PATCH 4/4] libcamera: Make Camera::Private::isAcquired() protected", "Date": "Fri, 18 Oct 2024 07:57:37 +0000", "Message-ID": "<20241018075942.1150378-5-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.rc1.288.g06298d1525-goog", "In-Reply-To": "<20241018075942.1150378-1-chenghaoyang@chromium.org>", "References": "<20241018075942.1150378-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As some pipeline handlers need to know if a CameraData is currently\nacquired, this patch makes the function protected, instead of private.\n\nFor example, the upcoming mtkisp7 needs the information to determine if\nit should send camera disconnect signal.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nCo-developed-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\n---\n include/libcamera/internal/camera.h | 4 +++-\n src/libcamera/camera.cpp | 3 +++\n 2 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 0bef0980e..fe47a49b7 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -43,6 +43,9 @@ public:\n \n \tconst CameraControlValidator *validator() const { return validator_.get(); }\n \n+protected:\n+\tbool isAcquired() const;\n+\n private:\n \tenum State {\n \t\tCameraAvailable,\n@@ -52,7 +55,6 @@ private:\n \t\tCameraRunning,\n \t};\n \n-\tbool isAcquired() const;\n \tbool isRunning() const;\n \tint isAccessAllowed(State state, bool allowDisconnected = false,\n \t\t\t const char *from = __builtin_FUNCTION()) const;\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex ef5a6725f..38aa4ad22 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -670,6 +670,9 @@ static const char *const camera_state_names[] = {\n \t\"Running\",\n };\n \n+/**\n+ * \\return True if the camera is acquired, false otherwise\n+ */\n bool Camera::Private::isAcquired() const\n {\n \treturn state_.load(std::memory_order_acquire) != CameraAvailable;\n", "prefixes": [ "4/4" ] }