Patch Detail
Show a patch.
GET /api/1.1/patches/2166/?format=api
{ "id": 2166, "url": "https://patchwork.libcamera.org/api/1.1/patches/2166/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2166/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191012184407.31684-6-laurent.pinchart@ideasonboard.com>", "date": "2019-10-12T18:43:58", "name": "[libcamera-devel,v2,05/14] libcamera: controls: Default ControlList validator argument to nullptr", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0a70958ee1796eb8809c4e39158147d0c0f8ca57", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2166/mbox/", "series": [ { "id": 531, "url": "https://patchwork.libcamera.org/api/1.1/series/531/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=531", "date": "2019-10-12T18:43:53", "name": "Use ControlList for both libcamera and V4L2 controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/531/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2166/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2166/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B1CD6196D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 12 Oct 2019 20:44:19 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC3A133A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 12 Oct 2019 20:44:18 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570905859;\n\tbh=vIQdsnSW8EKMO3MIx8ujNjFnihSBMuxBWiqf/RBv70M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=GlnC1GMsaamdQol8aXOPq5+tk3GvpxVvENtZMdpxAAkBwkjBN9SDXMW8v6FZ/B5Qs\n\tkawLTYzyu8dFIcboAT2GeyZTlu4lH7m6lCtUvyFPZVUUm3Hr0JURbGMIxSPGD+LLq7\n\t/grs97AVJbsEhl9um4lGpRZwOe2nkmE9/jepVZ6o=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 12 Oct 2019 21:43:58 +0300", "Message-Id": "<20191012184407.31684-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>", "References": "<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 05/14] libcamera: controls: Default\n\tControlList validator argument to nullptr", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 12 Oct 2019 18:44:19 -0000" }, "content": "The ControlList constructor takes a validator pointer that can be null.\nSet its default value to nullptr to simplify code in users of\nControlList.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/controls.h | 2 +-\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/request.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 342251c21018..12a13aacb198 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -126,7 +126,7 @@ private:\n \tusing ControlListMap = std::unordered_map<const ControlId *, ControlValue>;\n \n public:\n-\tControlList(ControlValidator *validator);\n+\tControlList(ControlValidator *validator = nullptr);\n \n \tusing iterator = ControlListMap::iterator;\n \tusing const_iterator = ControlListMap::const_iterator;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 02419e254f2d..80138f196184 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -220,7 +220,7 @@ void IPARkISP1::setControls(unsigned int frame)\n \n void IPARkISP1::metadataReady(unsigned int frame, unsigned int aeState)\n {\n-\tControlList ctrls(nullptr);\n+\tControlList ctrls;\n \n \tif (aeState)\n \t\tctrls.set(controls::AeLocked, aeState == 2);\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 23d3ab6f422c..e800f1449888 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -69,7 +69,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t/**\n \t * \\todo: Add a validator for metadata controls.\n \t */\n-\tmetadata_ = new ControlList(nullptr);\n+\tmetadata_ = new ControlList();\n }\n \n Request::~Request()\n", "prefixes": [ "libcamera-devel", "v2", "05/14" ] }