Patch Detail
Show a patch.
GET /api/1.1/patches/21649/?format=api
{ "id": 21649, "url": "https://patchwork.libcamera.org/api/1.1/patches/21649/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21649/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241017073948.353346-1-chenghaoyang@chromium.org>", "date": "2024-10-17T07:39:47", "name": "libcamera: Add open() and close() in CameraLens", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e6bba9d1bd7e6a34274f9a88ea20662ba0f373ed", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21649/mbox/", "series": [ { "id": 4709, "url": "https://patchwork.libcamera.org/api/1.1/series/4709/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4709", "date": "2024-10-17T07:39:47", "name": "libcamera: Add open() and close() in CameraLens", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4709/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21649/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21649/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E30CC32FC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 17 Oct 2024 07:39:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F0B665383;\n\tThu, 17 Oct 2024 09:39:56 +0200 (CEST)", "from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA6CE6537C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Oct 2024 09:39:54 +0200 (CEST)", "by mail-pl1-x62d.google.com with SMTP id\n\td9443c01a7336-20ce5e3b116so5051795ad.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Oct 2024 00:39:54 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(199.211.81.34.bc.googleusercontent.com. [34.81.211.199])\n\tby smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-2e3e090857esm1140882a91.52.2024.10.17.00.39.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 17 Oct 2024 00:39:52 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"TzMo8brM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729150793; x=1729755593;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=VM/WKi9FVow28rYGay+0y/3QPGhUCP41RYICm5TFSWA=;\n\tb=TzMo8brM63jJrZzMIBC9tQePTqGNKVCEZav4IThUPbG63FBfqUdVMfDPM84e4/rBUJ\n\tmQv8XNaUEqv6WMaH14Yt/1/W0tDxCxNqOw02t6TznphTiLqN9FWQwC2OvwRDucuL8yyi\n\tgA6vO7XSN4o6WbrqPoQRvgiC8DdZIuVfUuVNM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729150793; x=1729755593;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=VM/WKi9FVow28rYGay+0y/3QPGhUCP41RYICm5TFSWA=;\n\tb=EaAh17Hjy8QilgWGLeCKAYMxISwQ3n4cuhhvs17Ls+djtdHnOZvsJM/J7P2k0G3HXV\n\tZs/xdf3hVUTI/eaIbTquYwgu19K76c1vZfxpk6wtypNQxoQ4p7Abmto+8jwvrEr4uGSl\n\tdVPUJThsA+iRgU7sc89Eh4UnfZ8i1bCsHsVXnT4MvGtE8z8pL7AN0vy9SaSPKDD3FJ7y\n\tDbKwGmO1zYZ+U0IrPQh/6fHlORGCGIgedEaZcxrdsNO0qIiSe1GRdxW+rxr69L8xP8/7\n\tFxwDWNeVhOCLtE6IB4h97T+rm84MoHh1l73yPxfYavvZT/kpzswmKkdcg+UOv+cWS8y5\n\ttNFQ==", "X-Gm-Message-State": "AOJu0Yyekc7Oz4oSivtuwih7KVK7IuaUWr763H17l327D/ouZxHn4CoP\n\toHrfDoJG4yvw2pDz74//GY3vHNVYBFkajumiIiSEP39hOEdj0XMhgOe81OsQiVMLdYdi0qgvu70\n\t=", "X-Google-Smtp-Source": "AGHT+IHce183lWT/qqAv1nNLbVztaqi2WVx2DKR0ipPKfL3AVvbqmrUtSHOfZz4Tq8W/maaMQ20o/Q==", "X-Received": "by 2002:a17:90b:1914:b0:2e3:b168:70f5 with SMTP id\n\t98e67ed59e1d1-2e3b168726dmr6296736a91.21.1729150792946; \n\tThu, 17 Oct 2024 00:39:52 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Han-Lin Chen <hanlinchen@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH] libcamera: Add open() and close() in CameraLens", "Date": "Thu, 17 Oct 2024 07:39:47 +0000", "Message-ID": "<20241017073948.353346-1-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.rc1.288.g06298d1525-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Han-Lin Chen <hanlinchen@chromium.org>\n\nThis allows pipeline handlers to save some power when a camera is close.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/internal/camera_lens.h | 4 ++++\n src/libcamera/camera_lens.cpp | 17 +++++++++++++++++\n 2 files changed, 21 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\nindex 5a4b993bb..095056791 100644\n--- a/include/libcamera/internal/camera_lens.h\n+++ b/include/libcamera/internal/camera_lens.h\n@@ -26,6 +26,10 @@ public:\n \t~CameraLens();\n \n \tint init();\n+\n+\tint open();\n+\tvoid close();\n+\n \tint setFocusPosition(int32_t position);\n \n \tconst std::string &model() const { return model_; }\ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\nindex ccc2a6a65..039f5ad2a 100644\n--- a/src/libcamera/camera_lens.cpp\n+++ b/src/libcamera/camera_lens.cpp\n@@ -76,6 +76,23 @@ int CameraLens::init()\n \treturn 0;\n }\n \n+/**\n+ * \\brief Open the subdev\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+int CameraLens::open()\n+{\n+\treturn subdev_->open();\n+}\n+\n+/**\n+ * \\brief Close the subdev\n+ */\n+void CameraLens::close()\n+{\n+\tsubdev_->close();\n+}\n+\n /**\n * \\brief This function sets the focal point of the lens to a specific position.\n * \\param[in] position The focal point of the lens\n", "prefixes": [] }