Patch Detail
Show a patch.
GET /api/1.1/patches/21633/?format=api
{ "id": 21633, "url": "https://patchwork.libcamera.org/api/1.1/patches/21633/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21633/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241015203820.574326-4-stefan.klug@ideasonboard.com>", "date": "2024-10-15T20:38:14", "name": "[v1,3/4] libcamera: controls: Add missing size to control_type<Point>", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "041b78b891cd135d0c0d1f032ba5d6956e011fd4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21633/mbox/", "series": [ { "id": 4702, "url": "https://patchwork.libcamera.org/api/1.1/series/4702/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4702", "date": "2024-10-15T20:38:11", "name": "A few small fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4702/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21633/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21633/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9882AC326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Oct 2024 20:38:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37E3565388;\n\tTue, 15 Oct 2024 22:38:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E04A760537\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Oct 2024 22:38:32 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:64d4:9f74:8308:300d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23471A27;\n\tTue, 15 Oct 2024 22:36:51 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v/xdKilW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729024611;\n\tbh=9LIrdCjdczDr2LZBzey4V/CLGZUbzZXGAey/qJFr534=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=v/xdKilWl002Ugfqe4mO6OK8OvVw05+Lc1ww5wfAAfe/rwESCcxFqDSkncgKLRv9I\n\tlBk6hE+cgBXOZqoYrEXxe0B3uir143yB+zFgILJMcl0C6e2NM9QUdvbYdSdcc0Jccm\n\tZyc3Tsr059O+KqqXpwQT48RUjOGgl4OqgnOmP7zk=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type<Point>", "Date": "Tue, 15 Oct 2024 22:38:14 +0200", "Message-ID": "<20241015203820.574326-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241015203820.574326-1-stefan.klug@ideasonboard.com>", "References": "<20241015203820.574326-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The size member is missing in control_type<Point>. Add it.\n\nFixes: 200d535ca85f (\"libcamera: controls: Add ControlTypePoint\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n include/libcamera/controls.h | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ca60bbacad17..28fec767fae1 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -101,6 +101,7 @@ struct control_type<Size> {\n template<>\n struct control_type<Point> {\n \tstatic constexpr ControlType value = ControlTypePoint;\n+\tstatic constexpr std::size_t size = 0;\n };\n \n template<typename T, std::size_t N>\n", "prefixes": [ "v1", "3/4" ] }