Patch Detail
Show a patch.
GET /api/1.1/patches/21632/?format=api
{ "id": 21632, "url": "https://patchwork.libcamera.org/api/1.1/patches/21632/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21632/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241015203820.574326-3-stefan.klug@ideasonboard.com>", "date": "2024-10-15T20:38:13", "name": "[v1,2/4] ipa: rkisp1: algorithms: awb: Check for correct stats type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "df449c5fdd0cf13c95495af5c38ee1fee115d7b7", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21632/mbox/", "series": [ { "id": 4702, "url": "https://patchwork.libcamera.org/api/1.1/series/4702/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4702", "date": "2024-10-15T20:38:11", "name": "A few small fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4702/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21632/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21632/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE209C32F9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Oct 2024 20:38:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80CBD65389;\n\tTue, 15 Oct 2024 22:38:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39E3360537\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Oct 2024 22:38:30 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:64d4:9f74:8308:300d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62243A2F;\n\tTue, 15 Oct 2024 22:36:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Khu/PueQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729024608;\n\tbh=p1riyG/LTntAVP1PqslNRVZai5xYT3WAenywG3UB/3Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Khu/PueQV1VHEYFJ5YW/QhplmcLCLFr/zD41Iw6x4H9eoFnDU23it3XiClN0h6B3z\n\t/5zrD5bZacG0dibMZ31k/YYxhWE+hadi361EBe+TwyH4SdKUweh5H8kz3d+8yYPep8\n\tfRfX92iL16Mad7mMr0Qt2pu5X3oqwB9R93aNP3G0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 2/4] ipa: rkisp1: algorithms: awb: Check for correct stats\n\ttype", "Date": "Tue, 15 Oct 2024 22:38:13 +0200", "Message-ID": "<20241015203820.574326-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241015203820.574326-1-stefan.klug@ideasonboard.com>", "References": "<20241015203820.574326-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sometimes the ISP produces statistics only with a subset of statistic\ntypes being valid. It doesn't happen often, but it happens. Check for\nthe RKISP1_CIF_ISP_STAT_AWB bit to prevent using invalid or outdated\ndata.\n\nFor simpler code structure, the ColourTemperature metadata entry gets\nwritten unconditionally and overwritten later if needed.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 955a9ff4a897..86bcf20f6527 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -215,6 +215,10 @@ void Awb::process(IPAContext &context,\n \t\t\tstatic_cast<float>(frameContext.awb.gains.red),\n \t\t\tstatic_cast<float>(frameContext.awb.gains.blue)\n \t\t});\n+\tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n+\n+\tif (!(stats && stats->meas_type & RKISP1_CIF_ISP_STAT_AWB))\n+\t\treturn;\n \n \tif (rgbMode_) {\n \t\tgreenMean = awb->awb_mean[0].mean_y_or_g;\n@@ -270,10 +274,8 @@ void Awb::process(IPAContext &context,\n \t * meaningfully calculate gains. Freeze the algorithm in that case.\n \t */\n \tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n-\t blueMean < kMeanMinThreshold) {\n-\t\tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n+\t blueMean < kMeanMinThreshold)\n \t\treturn;\n-\t}\n \n \tactiveState.awb.temperatureK = estimateCCT(redMean, greenMean, blueMean);\n \n", "prefixes": [ "v1", "2/4" ] }