Patch Detail
Show a patch.
GET /api/1.1/patches/21629/?format=api
{ "id": 21629, "url": "https://patchwork.libcamera.org/api/1.1/patches/21629/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21629/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241015165006.1547318-2-libcamerabmw+ml@lsmod.de>", "date": "2024-10-15T16:50:07", "name": "[PATCHv3] Fix copyright year", "commit_ref": "ae51d304685787041fdc862d1391d53c2df7d0da", "pull_url": null, "state": "accepted", "archived": false, "hash": "f07cbe67aacd176c84abb096b4438748c597b5e1", "submitter": { "id": 209, "url": "https://patchwork.libcamera.org/api/1.1/people/209/?format=api", "name": "Bernhard M. Wiedemann", "email": "libcamerabmw+ml@lsmod.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21629/mbox/", "series": [ { "id": 4701, "url": "https://patchwork.libcamera.org/api/1.1/series/4701/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4701", "date": "2024-10-15T16:50:07", "name": "[PATCHv3] Fix copyright year", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4701/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21629/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21629/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62FE8C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Oct 2024 16:50:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C00C6537E;\n\tTue, 15 Oct 2024 18:50:28 +0200 (CEST)", "from mail.bmwiedemann.de (mail.bmwiedemann.de [188.40.142.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E17C660537\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Oct 2024 18:50:25 +0200 (CEST)", "from mail.bmwiedemann.de (localhost [127.0.0.1])\n\tby mail.bmwiedemann.de (Postfix) with ESMTP id AC7C39C4;\n\tTue, 15 Oct 2024 16:50:21 +0000 (UTC)", "from adrian.zq1.de (unknown [10.8.5.20])\n\tby mail.bmwiedemann.de (Postfix) with ESMTP;\n\tTue, 15 Oct 2024 16:50:21 +0000 (UTC)", "by adrian.zq1.de (Postfix, from userid 1000)\n\tid 63C39E00A6; Tue, 15 Oct 2024 18:50:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=lsmod.de header.i=@lsmod.de header.b=\"Ht48lD8h\";\n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=lsmod.de; s=202205;\n\tt=1729011025; bh=fw5ZVMl1X3f4Ev7HuA7pJDAXWkEl5BSqh+uYMuLH+7Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ht48lD8hgdnBMRUmywgsq6A6bgtwwN1KwFk9TyY5pxno26P7EzPv7X1NYRrPjRKku\n\txHZU3mudwMMfkX5mz8PqmRJQQtMsO21OoWC3bfygZN92XEoVLSlEhKIrWRk5M2wGB2\n\tLAC+xzLj+nK4WYVexbGD7ARTfFzaT8087kNRYyBlzYyTN/zfsphdQ9dOly+NkqBM74\n\tJzXFli1FC1T+IeOPHfX6D6hfM7HGi+HyzzSo0H33X27RZ2zxryxSz70VakMOsw43c9\n\tj2LRgRbIIoTShi70xYhbEA7Xz1DgvkreSJd049U1oz36g1mhXvo5kJzf6ESkArJg1E\n\txpGmTHnuVsTLQ==", "X-Spam-Checker-Version": "SpamAssassin 3.4.5 (2021-03-20) on vm4c.zq1.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00\n\tautolearn=ham autolearn_force=no version=3.4.5", "From": "libcamerabmw+ml@lsmod.de", "To": "libcamera-devel@lists.libcamera.org", "Cc": "\"Bernhard M. Wiedemann\" <bwiedemann@suse.de>", "Subject": "[PATCHv3] Fix copyright year", "Date": "Tue, 15 Oct 2024 18:50:07 +0200", "Message-ID": "<20241015165006.1547318-2-libcamerabmw+ml@lsmod.de>", "X-Mailer": "git-send-email 2.46.1", "In-Reply-To": "<20241014181640.GA5522@pendragon.ideasonboard.com>", "References": "<20241014181640.GA5522@pendragon.ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: \"Bernhard M. Wiedemann\" <bwiedemann@suse.de>\n\nwithout this patch, openSUSE's debugsource package would vary over time,\nbreaking reproducible builds.\nAlso a copyright of 2025 is factually wrong,\nbecause nobody did anything copyright-worthy in that year.\nIf updating the year manually is too hard (it is optional anyway),\nusing the mtime of input file(s) could work as well.\n\nBy moving the year to tracepoints.h.in it can easily be updated\nalong with the content.\n\nThe diff was:\n/usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) 2024, Google Inc.\n+ * Copyright (C) 2025, Google Inc.\n\nSigned-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>\n---\n include/libcamera/internal/tracepoints.h.in | 2 +-\n utils/codegen/gen-tp-header.py | 4 +---\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in\nindex f0962091..385f9f54 100644\n--- a/include/libcamera/internal/tracepoints.h.in\n+++ b/include/libcamera/internal/tracepoints.h.in\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) {{year}}, Google Inc.\n+ * Copyright (C) 2020, Google Inc.\n *\n * Tracepoints with lttng\n *\ndiff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py\nindex 83606c32..6769c7ce 100755\n--- a/utils/codegen/gen-tp-header.py\n+++ b/utils/codegen/gen-tp-header.py\n@@ -6,7 +6,6 @@\n #\n # Generate header file to contain lttng tracepoints\n \n-import datetime\n import jinja2\n import pathlib\n import os\n@@ -20,7 +19,6 @@ def main(argv):\n output = argv[2]\n template = argv[3]\n \n- year = datetime.datetime.now().year\n path = pathlib.Path(output).absolute().relative_to(argv[1])\n \n source = ''\n@@ -28,7 +26,7 @@ def main(argv):\n source += open(fname, 'r', encoding='utf-8').read() + '\\n\\n'\n \n template = jinja2.Template(open(template, 'r', encoding='utf-8').read())\n- string = template.render(year=year, path=path, source=source)\n+ string = template.render(path=path, source=source)\n \n f = open(output, 'w', encoding='utf-8').write(string)\n \n", "prefixes": [ "PATCHv3" ] }