Patch Detail
Show a patch.
GET /api/1.1/patches/21606/?format=api
{ "id": 21606, "url": "https://patchwork.libcamera.org/api/1.1/patches/21606/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21606/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241013175719.187166-1-robert.mader@collabora.com>", "date": "2024-10-13T17:57:19", "name": "[v2] libcamera: software_isp: Clear IPA context on configure and stop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "926219c2914d8ad42d49dbf4e331a0bd916aff6e", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/1.1/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21606/mbox/", "series": [ { "id": 4692, "url": "https://patchwork.libcamera.org/api/1.1/series/4692/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4692", "date": "2024-10-13T17:57:19", "name": "[v2] libcamera: software_isp: Clear IPA context on configure and stop", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4692/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21606/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21606/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 263ADC32F4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 13 Oct 2024 17:58:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C8F96537B;\n\tSun, 13 Oct 2024 19:58:01 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A55426536C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 13 Oct 2024 19:57:58 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 172884227388238.28706110889277;\n\tSun, 13 Oct 2024 10:57:53 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"gNKjeLYX\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1728842275; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=IPhyxdzpTVwVI9mMqM2rh1wezjzb8HS62M5XxEOtZO5F64Bpxt3onTuc8MesRTlXg5C+UQtEuvdx0RovUrfn0iyDQXlSmegKv76e7FOLZ5gvruPjBGHIpLac9y3pidSGDZOAwnDkAw+OpZqDA/1bTL9xZ5C7GgIFcogTX8BAOpg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1728842275;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=qq2M3lm2UNIBlxht18U7LCo+/FcXf0RSsbqz+27FrEw=; \n\tb=RDyKYgfWMcZ1I7xxz1SfYo3Y7WmrBedP5xIzZkNjDXgta/OUqM3mZs/6pL9hNT6lyNVEJcv2LspTgd/iSwyfRQ9fMI/Q9nNKtd9AASHjDnpAa2BhcOZN8t7agKgeHAmJUGH6sZu0uXG/UR93pxuon72wf37TY/th42ELlsVMMME=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1728842275;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=qq2M3lm2UNIBlxht18U7LCo+/FcXf0RSsbqz+27FrEw=;\n\tb=gNKjeLYX8mo5bWqw6uF0+BzoPFt+ytkdC2fnRm/dBXny5DyOmobu6T2KqdGXvqBU\n\to6z4v0aTdm0nv68+A0Xlp1FQAt1PxbXqM1zlSBrDCHoj3xUU8QSJl5lJU+gWpZyazY1\n\togEnYxgbk+hPFKvjY7j6IS31oGcSCBZ02QRiLGoM=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v2] libcamera: software_isp: Clear IPA context on configure\n\tand stop", "Date": "Sun, 13 Oct 2024 19:57:19 +0200", "Message-ID": "<20241013175719.187166-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.47.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Like the hardware pipelines do. Not clearing frameContexts otherwise can\ntrigger asserts like \"Frame context for ... has been overwritten by ...\"\nwhen switching between cameras using the swISP, e.g. on phones.\n\nClearing the configuration and active state will become more important\nwith upcoming changes such as getting the black level from the camera\nhelper.\n\nFixes: 04d171e6 (\"libcamera: software_isp: Call Algorithm::queueRequest\")\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n\n---\n\nChanges in version 2:\n - Also clear frameContexts as well as other context data on configure\n - Change commit title and message accordingly, previous title:\n \"libcamera: software_isp: Clear frameContexts on Stop()\"\n---\n src/ipa/simple/soft_simple.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b28c7039..3b25d7d0 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -184,6 +184,11 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n \tconst ControlInfo &exposureInfo = sensorInfoMap_.find(V4L2_CID_EXPOSURE)->second;\n \tconst ControlInfo &gainInfo = sensorInfoMap_.find(V4L2_CID_ANALOGUE_GAIN)->second;\n \n+\t/* Clear the IPA context before the streaming session. */\n+\tcontext_.configuration = {};\n+\tcontext_.activeState = {};\n+\tcontext_.frameContexts.clear();\n+\n \tcontext_.configuration.agc.exposureMin = exposureInfo.min().get<int32_t>();\n \tcontext_.configuration.agc.exposureMax = exposureInfo.max().get<int32_t>();\n \tif (!context_.configuration.agc.exposureMin) {\n@@ -245,6 +250,7 @@ int IPASoftSimple::start()\n \n void IPASoftSimple::stop()\n {\n+ context_.frameContexts.clear();\n }\n \n void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &controls)\n", "prefixes": [ "v2" ] }