Patch Detail
Show a patch.
GET /api/1.1/patches/21602/?format=api
{ "id": 21602, "url": "https://patchwork.libcamera.org/api/1.1/patches/21602/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21602/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241011184600.17118-1-robert.mader@collabora.com>", "date": "2024-10-11T18:46:00", "name": "pipeline: simple: Consider output sizes when choosing pipe config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "261d3c25b0a7dc2e7737dc4fb41f0caf70a21328", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/1.1/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21602/mbox/", "series": [ { "id": 4689, "url": "https://patchwork.libcamera.org/api/1.1/series/4689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4689", "date": "2024-10-11T18:46:00", "name": "pipeline: simple: Consider output sizes when choosing pipe config", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21602/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21602/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0FB2C326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 11 Oct 2024 18:46:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D6716539F;\n\tFri, 11 Oct 2024 20:46:41 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2A8165393\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Oct 2024 20:46:38 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1728672392909844.9142306216343;\n\tFri, 11 Oct 2024 11:46:32 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"fkFNwYx0\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1728672395; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=VqI2pKdlOc3sUOsWnmDzCpnzmX2akMoU7ONHVEUHS5+bJHXQ+j6IbeYb3XOlnYXI5tAnqZWBMRlJOxKHqKmF+Un8FV5z0txXkdgISZD21NvH4WZXRLdHNbNThs8iRAx9SJu7J5LaWhcfqgeCJGJh8248A6awjw9+pDHHGj+F26g=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1728672395;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=Da02uDy0TYwajcpfyOeVb5Yo1O7mDq+rMUSHk70MY+o=; \n\tb=bekLX13zyeKfXcU8eYz1G7ceaf0m5gq+ppDeSiDI+YyQnhI7BBPHz4O+tgVr8ZHphee53VkgC+iExX0A2qKJnlFpT/zJfYIqV4+2exn4NuLja5xDbY1zyDjhjo2S5dBu6rw1mFxZopGT1TZVR8zcDbxkdcpst4AYqvlDQ2X3AzU=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1728672395;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=Da02uDy0TYwajcpfyOeVb5Yo1O7mDq+rMUSHk70MY+o=;\n\tb=fkFNwYx0ok8yVrLf+BSBswam+YHv9hykvQ8ul9hzCIvXYQeceX6gE5coxCYU24Rc\n\tYgRqEJQGmMHFo5Ca0H2JzMYyZYmryokrIVeJ5KiOZUJj+RZqKAaKD78QKdSdhHxRODe\n\tWDrXHlm8CU5iPK+KgD9/dlFMiulWxrB8Dk0ZXoiY=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH] pipeline: simple: Consider output sizes when choosing pipe\n\tconfig", "Date": "Fri, 11 Oct 2024 20:46:00 +0200", "Message-ID": "<20241011184600.17118-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.47.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to avoid having to adjust the size further down below which\nagain can break user assumptions. Notably, without this the capture size\nof 1920x1080 gets adjusted to 1912x1080 when used with the swISP using a\nbayer pattern width of 4, breaking users like Gstreamer down the line.\n\nCloses https://bugs.libcamera.org/show_bug.cgi?id=236\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n\n---\n\nI'm not really sure if this is the correct approach, but sending it out\nalready for feedback. So far this gives me promissing results on tested\ndevices.\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 3ddce71d..2d185b90 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1048,7 +1048,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\tconst Size &size = pipeConfig->captureSize;\n \n \t\tif (size.width >= maxStreamSize.width &&\n-\t\t size.height >= maxStreamSize.height) {\n+\t\t size.height >= maxStreamSize.height &&\n+\t\t pipeConfig->outputSizes.contains(maxStreamSize)) {\n \t\t\tif (!pipeConfig_ || size < pipeConfig_->captureSize)\n \t\t\t\tpipeConfig_ = pipeConfig;\n \t\t}\n", "prefixes": [] }