Patch Detail
Show a patch.
GET /api/1.1/patches/21589/?format=api
{ "id": 21589, "url": "https://patchwork.libcamera.org/api/1.1/patches/21589/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21589/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241011092222.537322-4-umang.jain@ideasonboard.com>", "date": "2024-10-11T09:22:22", "name": "[3/3] libcamera: rkisp1: Maintain alphabetical order of forward declarations", "commit_ref": "3299f84de7dd2c454342d19e0c4d7db662ead536", "pull_url": null, "state": "accepted", "archived": false, "hash": "569d65efb253edcad37f40b5ef4496da643094ca", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21589/mbox/", "series": [ { "id": 4684, "url": "https://patchwork.libcamera.org/api/1.1/series/4684/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4684", "date": "2024-10-11T09:22:19", "name": "libcamera: rkisp1: sensorConfig assorted fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4684/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21589/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21589/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 837FCC3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 11 Oct 2024 09:22:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3B6E6536F;\n\tFri, 11 Oct 2024 11:22:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E875B6536F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Oct 2024 11:22:39 +0200 (CEST)", "from umang.jain (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51A42CDB;\n\tFri, 11 Oct 2024 11:21:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kKbwzAaR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728638461;\n\tbh=8dEQVK472YHpbKOagFk135zcldiaSb5wXgO8VjrfJLY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kKbwzAaRQlLC1uvWDipaqlAsvziI6RPhZSOaXsL2Z87Ne5iqoOnjiU4AP1NYweuOl\n\t7Xx2FKOvtB/ichmTGQ2ucGn53Er8cDh+XKKF/CNwMlEkpA0T+ZpqYSINn8Hml3Ue8N\n\thrk7/lsVSv0fexrkYJUD+I4BsRMWRVyCJll5aN1o=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 3/3] libcamera: rkisp1: Maintain alphabetical order of\n\tforward declarations", "Date": "Fri, 11 Oct 2024 14:52:22 +0530", "Message-ID": "<20241011092222.537322-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241011092222.537322-1-umang.jain@ideasonboard.com>", "References": "<20241011092222.537322-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Alphabetical order of Forward declarations should be maintained hence,\n'class V4L2Subdevice' should come after 'class SensorConfiguration'.\nFix it.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\nindex 8461071f..45be8476 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n@@ -26,8 +26,8 @@ namespace libcamera {\n \n class CameraSensor;\n class MediaDevice;\n-class V4L2Subdevice;\n class SensorConfiguration;\n+class V4L2Subdevice;\n struct StreamConfiguration;\n struct V4L2SubdeviceFormat;\n \n", "prefixes": [ "3/3" ] }