Patch Detail
Show a patch.
GET /api/1.1/patches/21588/?format=api
{ "id": 21588, "url": "https://patchwork.libcamera.org/api/1.1/patches/21588/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21588/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241011092222.537322-3-umang.jain@ideasonboard.com>", "date": "2024-10-11T09:22:21", "name": "[2/3] libcamera: rkisp1: Rectify SensorConfiguration check", "commit_ref": "a2be725d2652ba71d23adf36bb8a1342947debbf", "pull_url": null, "state": "accepted", "archived": false, "hash": "bcdb6a00cc5699c1cbd7603fb0878612948d29e0", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21588/mbox/", "series": [ { "id": 4684, "url": "https://patchwork.libcamera.org/api/1.1/series/4684/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4684", "date": "2024-10-11T09:22:19", "name": "libcamera: rkisp1: sensorConfig assorted fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4684/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21588/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21588/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F99BC3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 11 Oct 2024 09:22:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CCAD565378;\n\tFri, 11 Oct 2024 11:22:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0FF16536C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Oct 2024 11:22:39 +0200 (CEST)", "from umang.jain (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E29D3220;\n\tFri, 11 Oct 2024 11:20:58 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iTWX0qCH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728638460;\n\tbh=beO8Ri0fxMAK2tCgCswVJDzfzzcfFrF4dIzLD6cbgAk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iTWX0qCHIxLX8YXjSoNSR6BhycUEFmA2AUQAM5q4Oqw1E8q1riejNBlkEhXQM4NZE\n\tQPHII+dghqZ4wyRqQR4mrxMcrV1IANQOYeN6+VtOv/Or1ZqC4lqxLtBovB3G77RpP4\n\t+ZQ0p9Mk8wfdy1PYwcH5XLlp+c7ML7DD1/lOtXgs=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 2/3] libcamera: rkisp1: Rectify SensorConfiguration check", "Date": "Fri, 11 Oct 2024 14:52:21 +0530", "Message-ID": "<20241011092222.537322-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241011092222.537322-1-umang.jain@ideasonboard.com>", "References": "<20241011092222.537322-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The 'found' flag was mistakenly understood that a compatible sensor\nformat has been found when a sensor configuration is passed in. However,\n'found' related to the stream configuration's pixelformat, whether it is\nsupported by the RkISP1Path video node or not. It does not relate to the\nsensor format, hence the check:\n\n\tif (sensorConfig && !found)\n\ndoesn't make sense.\n\nRectify the above check with:\n\n\tif (sensorConfig && !rawFormat.isValid())\n\nto ensure a sensor format compatible with sensor configuration has been\nset to rawFormat.\n\nFixes: 047d647452c4 (\"libcamera: rkisp1: Integrate SensorConfiguration support\")\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 4a3b779c..236d05af 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -304,7 +304,7 @@ RkISP1Path::validate(const CameraSensor *sensor,\n \t\t}\n \t}\n \n-\tif (sensorConfig && !found)\n+\tif (sensorConfig && !rawFormat.isValid())\n \t\treturn CameraConfiguration::Invalid;\n \n \tbool isRaw = PixelFormatInfo::info(cfg->pixelFormat).colourEncoding ==\n", "prefixes": [ "2/3" ] }