Patch Detail
Show a patch.
GET /api/1.1/patches/21584/?format=api
{ "id": 21584, "url": "https://patchwork.libcamera.org/api/1.1/patches/21584/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21584/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241010090210.757093-1-paul.elder@ideasonboard.com>", "date": "2024-10-10T09:02:10", "name": "py: Add bindings for ControlId array information", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "329888587ba2dd99195a914efc5d00ee443bcdab", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21584/mbox/", "series": [ { "id": 4682, "url": "https://patchwork.libcamera.org/api/1.1/series/4682/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4682", "date": "2024-10-10T09:02:10", "name": "py: Add bindings for ControlId array information", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4682/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21584/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21584/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CE15C32E0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Oct 2024 09:02:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4044463536;\n\tThu, 10 Oct 2024 11:02:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47CD663536\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Oct 2024 11:02:25 +0200 (CEST)", "from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:c738:203:8807:bdb1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F61F4D4;\n\tThu, 10 Oct 2024 11:00:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GIfk9hmT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728550847;\n\tbh=QIxxY6DHfbq2/gVLKO0zOSQthH0/76NsN2Pc4b8ghWs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=GIfk9hmT0EuXcjkOv7mvJmI/SqAF/IXmhHFWzf1/WxIKDP6ZHcLfwbwrtYWUmCKAG\n\thWaFHcdSG4Wn9/J9680Q5qPGsGTw8TB66JBXN5qWRJUgrOcrAjI3lKs1XTxjgZ5S4j\n\td+Pdxq+16RBBjliw7UhrGGuNXH6clsJMuagWtNp8=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] py: Add bindings for ControlId array information", "Date": "Thu, 10 Oct 2024 18:02:10 +0900", "Message-Id": "<20241010090210.757093-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add python bindings for querying whether or not a ControlId is an array\ntype, and the size.\n\nExample usage:\n>>> cid\nlibcamera.ControlId(28, FrameDurationLimits, ControlType.Integer64)\n>>> cid.isArray\nTrue\n>>> cid.size\n2\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/py/libcamera/py_main.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 983b76f6e998..898ef319dc69 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -400,6 +400,8 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.def_property_readonly(\"id\", &ControlId::id)\n \t\t.def_property_readonly(\"name\", &ControlId::name)\n \t\t.def_property_readonly(\"type\", &ControlId::type)\n+\t\t.def_property_readonly(\"isArray\", &ControlId::isArray)\n+\t\t.def_property_readonly(\"size\", &ControlId::size)\n \t\t.def(\"__str__\", [](const ControlId &self) { return self.name(); })\n \t\t.def(\"__repr__\", [](const ControlId &self) {\n \t\t\treturn py::str(\"libcamera.ControlId({}, {}, {})\")\n", "prefixes": [] }