Patch Detail
Show a patch.
GET /api/1.1/patches/21543/?format=api
{ "id": 21543, "url": "https://patchwork.libcamera.org/api/1.1/patches/21543/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21543/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241008153031.429906-6-stefan.klug@ideasonboard.com>", "date": "2024-10-08T15:29:43", "name": "[v3,5/7] ipa: rkisp1: Add debug metadata support to the rkisp1", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cbe9d3e19f70d18bc7ef75863567c05f189828a3", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21543/mbox/", "series": [ { "id": 4667, "url": "https://patchwork.libcamera.org/api/1.1/series/4667/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4667", "date": "2024-10-08T15:29:38", "name": "Add support for IPA debugging metadata", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4667/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21543/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21543/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DDD4BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 8 Oct 2024 15:30:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 189706536D;\n\tTue, 8 Oct 2024 17:30:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D7D46536A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Oct 2024 17:30:50 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d:f30b:aa60:fabf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ECE95DB2;\n\tTue, 8 Oct 2024 17:29:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A6CXNl4W\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728401354;\n\tbh=3+Lq6lsLzfFRTRA8BeNbNCHJn3NUYJxhESxu73Dh/EY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A6CXNl4Wf0fhQixHWqLM6zyAqxxD1n2baIFNu3pnvORo31tawb74uXZTBgd/B//UU\n\tzrfckRQGYJ/4J/fOCw8sH70tTnWpbg5uDIF2ond1dFs9ewJPlV6HPQa3hbVKUmkUha\n\tiXd84ubI3VshP9kGr5vozHv0WkwpsZaAXbHGHPPY=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 5/7] ipa: rkisp1: Add debug metadata support to the rkisp1", "Date": "Tue, 8 Oct 2024 17:29:43 +0200", "Message-ID": "<20241008153031.429906-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241008153031.429906-1-stefan.klug@ideasonboard.com>", "References": "<20241008153031.429906-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a DebugMetadata helper to the context and add the corresponding\nplumbing. This is all that is needed to support debug metadata in an\nIPA.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v3:\n- Whitespace changes\n\nChanges in v2:\n- Replace DebugMetadata::assignList by DebugMetadata::moveEntries\n---\n src/ipa/rkisp1/ipa_context.h | 5 +++++\n src/ipa/rkisp1/rkisp1.cpp | 3 +++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex d52e73ad2503..7b93a9e9461d 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -17,8 +17,11 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n #include <libcamera/geometry.h>\n+\n #include <libcamera/ipa/core_ipa_interface.h>\n \n+#include \"libcamera/internal/debug_controls.h\"\n+\n #include <libipa/camera_sensor_helper.h>\n #include <libipa/fc_queue.h>\n #include <libipa/matrix.h>\n@@ -194,6 +197,8 @@ struct IPAContext {\n \n \tControlInfoMap::Map ctrlMap;\n \n+\tDebugMetadata debugMetadata;\n+\n \t/* Interface to the Camera Helper */\n \tstd::unique_ptr<CameraSensorHelper> camHelper;\n };\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex a579f21de56f..03eae01baf54 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -117,6 +117,7 @@ const IPAHwSettings ipaHwSettingsV12{\n const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n+\t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n };\n@@ -326,6 +327,7 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)\n void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n {\n \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n+\tcontext_.debugMetadata.enableByControl(controls);\n \n \tfor (auto const &a : algorithms()) {\n \t\tAlgorithm *algo = static_cast<Algorithm *>(a.get());\n@@ -378,6 +380,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n \n \tsetControls(frame);\n \n+\tcontext_.debugMetadata.moveEntries(metadata);\n \tmetadataReady.emit(frame, metadata);\n }\n \n", "prefixes": [ "v3", "5/7" ] }