Patch Detail
Show a patch.
GET /api/1.1/patches/21504/?format=api
{ "id": 21504, "url": "https://patchwork.libcamera.org/api/1.1/patches/21504/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21504/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241004095946.264537-3-chenghaoyang@google.com>", "date": "2024-10-04T09:59:15", "name": "[15,2/7] libcamera: Remove PipelineHandler Fatal check of non-empty MediaDevices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "41a946d8020fdd8433230175f39bba0b6d992b1c", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21504/mbox/", "series": [ { "id": 4656, "url": "https://patchwork.libcamera.org/api/1.1/series/4656/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4656", "date": "2024-10-04T09:59:14", "name": "[15,1/7] libcamera: add DmaBufAllocator::exportBuffers()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4656/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21504/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21504/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BAFBC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Oct 2024 10:00:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E06863532;\n\tFri, 4 Oct 2024 12:00:00 +0200 (CEST)", "from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com\n\t[IPv6:2607:f8b0:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8861E6352D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Oct 2024 11:59:56 +0200 (CEST)", "by mail-pf1-x42c.google.com with SMTP id\n\td2e1a72fcca58-71b20ffd809so1731357b3a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 04 Oct 2024 02:59:56 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71ded2ad931sm316911b3a.41.2024.10.04.02.59.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 04 Oct 2024 02:59:53 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"NXXaqPqY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1728035994; x=1728640794;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=WjgHep/iOhTVamI1PFk3bNKyYMctjnfcztOa4A+1UwI=;\n\tb=NXXaqPqYJGLTGl28AkF6dh3U2z/JmssMxzP7vNNjVmLZ9d3VEr3huRi8GhQ6ilhVc8\n\tEDWLBL7H2L/mzygimzolx+eJa+B03XJjrQx7BqkhV+DJ/I3nmxOvBO9su6MxnwNxicW6\n\ttzxIYtOsnbfT7uVvjI/JEHkZ9xssNPJGm4kWU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1728035994; x=1728640794;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=WjgHep/iOhTVamI1PFk3bNKyYMctjnfcztOa4A+1UwI=;\n\tb=oQ94/e9EGlWNdj7HkFHyTpBxeTSPBmYYFvTcRVLNIsj/G2CsjKvfv1u+Qr3D7mtxkB\n\ts2+zrTeXmmgWidnwenRqeAh3ASr6TCpDIKj4tqeQloOjJCC8/qjH357FoOtkmQiBlrnc\n\tcfavTQiP10HqjTNXm0RZqELANchQ1JGIAZouSbBi4cK65mCGct0xjt1O+EO/+ZrZQTxi\n\tfJvKXDP3AuFv2q2cXxpsJHIxXCOHaCnlOD6jCkQXpPtGIHR+hb+X+0dVh9BrAOl8zuhJ\n\tkYnifCMOuOtA+bOdX5ycuItVsH+sVGGVI6AVTj7JtgDcEpXoWf/j9QS/WivJAO1d9G0k\n\tO6wg==", "X-Gm-Message-State": "AOJu0YzQnhbmyLkZZklROvr+INV5oRvvXtTIzipjFlpUJa7o52/h9aWK\n\taHIurGwxDpcF50IWqI78SBnv8pE6FdcUpinQ+kSE7N6KSVcChkxTsxZOUwvC//nt0/92p1OItJM\n\tsGA==", "X-Google-Smtp-Source": "AGHT+IEtSLVkyF7BnKe+cL0clSWF6Z65+cOKTH+4VgAPQXAPZFKBNpCPOid8o73nu8ujktBz7iHULg==", "X-Received": "by 2002:a05:6a00:886:b0:714:340c:b9ee with SMTP id\n\td2e1a72fcca58-71de23a5576mr3081486b3a.1.1728035994292; \n\tFri, 04 Oct 2024 02:59:54 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 15 2/7] libcamera: Remove PipelineHandler Fatal check of\n\tnon-empty MediaDevices", "Date": "Fri, 4 Oct 2024 09:59:15 +0000", "Message-ID": "<20241004095946.264537-3-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.47.0.rc0.187.ge670bccf7e-goog", "In-Reply-To": "<20241004095946.264537-1-chenghaoyang@google.com>", "References": "<20241004095946.264537-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Fatal check of having at least one MediaDevice was to prevent\npipeline handler implementations searching and owning media devices with\ncustom conventions, instead of using the base function\n|acquireMediaDevice|. It also has the assumption that there's at least\none media device to make a camera work.\n\nNow that the assumption will be broken by the virtual pipeline handler\nadded in the following patches, and developers should be aware of the\navailable functions in the base class to handle media devices, the Fatal\ncheck is no longer needed.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex e59404691..89a513e46 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -637,9 +637,14 @@ void PipelineHandler::registerCamera(std::shared_ptr<Camera> camera)\n {\n \tcameras_.push_back(camera);\n \n-\tif (mediaDevices_.empty())\n-\t\tLOG(Pipeline, Fatal)\n-\t\t\t<< \"Registering camera with no media devices!\";\n+\tif (mediaDevices_.empty()) {\n+\t\t/*\n+\t\t * For virtual devices with no MediaDevice, there are no system\n+\t\t * devices to register.\n+\t\t */\n+\t\tmanager_->_d()->addCamera(std::move(camera));\n+\t\treturn;\n+\t}\n \n \t/*\n \t * Walk the entity list and map the devnums of all capture video nodes\n", "prefixes": [ "15", "2/7" ] }