Patch Detail
Show a patch.
GET /api/1.1/patches/21498/?format=api
{ "id": 21498, "url": "https://patchwork.libcamera.org/api/1.1/patches/21498/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21498/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241003135741.60869-2-umang.jain@ideasonboard.com>", "date": "2024-10-03T13:57:39", "name": "[v2,1/2] libcamera rkisp1: Reduce scope of sensor max resolution variable", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "df8ecb048089328368ef07a009494b966b56795e", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21498/mbox/", "series": [ { "id": 4653, "url": "https://patchwork.libcamera.org/api/1.1/series/4653/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4653", "date": "2024-10-03T13:57:38", "name": "rkisp1: Integrate Sensorconfiguration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4653/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21498/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21498/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F5ACBD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Oct 2024 13:57:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88C536351F;\n\tThu, 3 Oct 2024 15:57:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B0D16351F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Oct 2024 15:57:49 +0200 (CEST)", "from umang.jain (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BF8E66F;\n\tThu, 3 Oct 2024 15:56:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ORf4o4OF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727963776;\n\tbh=6NwE6SlxNtgZyMy452TU7UIfycDDfIBGuNb9RWzVL+w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ORf4o4OFEv1bEP+gZR753I6PZlS8B50LeAQtBwhLIvPAqJld0m/FMKix8ZQH/OwUL\n\tWWeZMLoWjharFdwG+cshBotzgpFOa+st48HdS9zk0JFp6GpWreZBR9eLFHqXu8rGaL\n\tatBgCCC2neec8+czc248ntraWDDabWag/yvvLpiQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v2 1/2] libcamera rkisp1: Reduce scope of sensor max\n\tresolution variable", "Date": "Thu, 3 Oct 2024 19:27:39 +0530", "Message-ID": "<20241003135741.60869-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241003135741.60869-1-umang.jain@ideasonboard.com>", "References": "<20241003135741.60869-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Reduce the scope of sensor's max resolution variable in\nRkISP1Path::validate(), as it is only required to constraint the\nmaximum and minimum resolution bounds on the non-RAW code path.\n\nNo functional changes intended in this patch.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex cb6117b9..e7f1f12a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -254,7 +254,6 @@ CameraConfiguration::Status RkISP1Path::validate(const CameraSensor *sensor,\n \t\t\t\t\t\t StreamConfiguration *cfg)\n {\n \tconst std::vector<unsigned int> &mbusCodes = sensor->mbusCodes();\n-\tSize resolution = filterSensorResolution(sensor);\n \n \tconst StreamConfiguration reqCfg = *cfg;\n \tCameraConfiguration::Status status = CameraConfiguration::Valid;\n@@ -322,6 +321,8 @@ CameraConfiguration::Status RkISP1Path::validate(const CameraSensor *sensor,\n \t\tminResolution = sensorFormat.size;\n \t\tmaxResolution = sensorFormat.size;\n \t} else {\n+\t\tSize resolution = filterSensorResolution(sensor);\n+\n \t\t/*\n \t\t * Adjust the size based on the sensor resolution and absolute\n \t\t * limits of the ISP.\n", "prefixes": [ "v2", "1/2" ] }