Patch Detail
Show a patch.
GET /api/1.1/patches/21469/?format=api
{ "id": 21469, "url": "https://patchwork.libcamera.org/api/1.1/patches/21469/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21469/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241002055002.6271-4-jacopo.mondi@ideasonboard.com>", "date": "2024-10-02T05:50:01", "name": "[v10,4/5] libcamera: control_ids_draft: Add face detection controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cd30e90930bb230d08dd1488918949890d6ae133", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21469/mbox/", "series": [ { "id": 4647, "url": "https://patchwork.libcamera.org/api/1.1/series/4647/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4647", "date": "2024-10-01T19:13:44", "name": "Add Face Detection Controls", "version": 10, "mbox": "https://patchwork.libcamera.org/series/4647/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21469/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21469/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91A2ABD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Oct 2024 05:50:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54EE56352E;\n\tWed, 2 Oct 2024 07:50:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7220063529\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Oct 2024 07:50:18 +0200 (CEST)", "from ideasonboard.com (unknown [5.77.88.238])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAFA6D52;\n\tWed, 2 Oct 2024 07:48:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LeXr2cWm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727848125;\n\tbh=hcHSpTNPYJhc+NYbm+iZH/MUXm0wgDwtSsdUPpWvPXs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LeXr2cWmqRu9ZQPT86AFkyovIqJQoDmCFsi5YqY3JEkejIq/IUfYGM14Qci0xFcXo\n\toi6ZBUHqzo6ZT1z+jGyIIArWgXpqgL+BO9/XStMG8FlrlweJl1zUT+jBoLdP8JXVrW\n\t5EITIYgPOJyIFxIEX3vFz2rUfTuTzcOX7TtXJnZI=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tBecker Hsieh <beckerh@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v10 4/5] libcamera: control_ids_draft: Add face detection\n\tcontrols", "Date": "Wed, 2 Oct 2024 07:50:01 +0200", "Message-ID": "<20241002055002.6271-4-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.46.1", "In-Reply-To": "<20241002055002.6271-1-jacopo.mondi@ideasonboard.com>", "References": "<20241001191354.55056-1-jacopo.mondi@ideasonboard.com>\n\t<20241002055002.6271-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Yudhistira Erlandinata <yerlandinata@chromium.org>\n\nAdd FaceDetectMode, FaceDetectFaceRectangles, FaceDetectFaceScores,\nand FaceDetectFaceLandmark. Also add ControlTypePoint for supporting\nFaceDetectFaceLandmark.\n\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Becker Hsieh <beckerh@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/libcamera/control_ids_draft.yaml | 82 ++++++++++++++++++++++++++++\n 1 file changed, 82 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 9bef5bf15238..1b284257f601 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -227,4 +227,86 @@ controls:\n value. All of the custom test patterns will be static (that is the\n raw image must not vary from frame to frame).\n \n+ - FaceDetectMode:\n+ type: int32_t\n+ description: |\n+ Control to select the face detection mode used by the pipeline.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_DETECT_MODE.\n+\n+ \\sa FaceDetectFaceRectangles\n+ \\sa FaceDetectFaceScores\n+ \\sa FaceDetectFaceLandmarks\n+ \\sa FaceDetectFaceIds\n+\n+ enum:\n+ - name: FaceDetectModeOff\n+ value: 0\n+ description: |\n+ Pipeline doesn't perform face detection and doesn't report any\n+ control related to face detection.\n+ - name: FaceDetectModeSimple\n+ value: 1\n+ description: |\n+ Pipeline performs face detection and reports the\n+ FaceDetectFaceRectangles and FaceDetectFaceScores controls for each\n+ detected face. FaceDetectFaceLandmarks and FaceDetectFaceIds are\n+ optional.\n+ - name: FaceDetectModeFull\n+ value: 2\n+ description: |\n+ Pipeline performs face detection and reports all the controls\n+ related to face detection including FaceDetectFaceRectangles,\n+ FaceDetectFaceScores, FaceDetectFaceLandmarks, and\n+ FaceDeteceFaceIds for each detected face.\n+\n+ - FaceDetectFaceRectangles:\n+ type: Rectangle\n+ description: |\n+ Boundary rectangles of the detected faces. The number of values is\n+ the number of detected faces.\n+\n+ The FaceDetectFaceRectangles control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_RECTANGLES.\n+ size: [n]\n+\n+ - FaceDetectFaceScores:\n+ type: uint8_t\n+ description: |\n+ Confidence score of each of the detected faces. The range of score is\n+ [0, 100]. The number of values should be the number of faces reported\n+ in FaceDetectFaceRectangles.\n+\n+ The FaceDetectFaceScores control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_SCORES.\n+ size: [n]\n+\n+ - FaceDetectFaceLandmarks:\n+ type: Point\n+ description: |\n+ Array of human face landmark coordinates in format [..., left_eye_i,\n+ right_eye_i, mouth_i, left_eye_i+1, ...], with i = index of face. The\n+ number of values should be 3 * the number of faces reported in\n+ FaceDetectFaceRectangles.\n+\n+ The FaceDetectFaceLandmarks control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_LANDMARKS.\n+ size: [n]\n+\n+ - FaceDetectFaceIds:\n+ type: int32_t\n+ description: |\n+ Each detected face is given a unique ID that is valid for as long as the\n+ face is visible to the camera device. A face that leaves the field of\n+ view and later returns may be assigned a new ID. The number of values\n+ should be the number of faces reported in FaceDetectFaceRectangles.\n+\n+ The FaceDetectFaceIds control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_IDS.\n+ size: [n]\n+\n ...\n", "prefixes": [ "v10", "4/5" ] }