Patch Detail
Show a patch.
GET /api/1.1/patches/21421/?format=api
{ "id": 21421, "url": "https://patchwork.libcamera.org/api/1.1/patches/21421/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21421/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240930063342.3014837-8-chenghaoyang@google.com>", "date": "2024-09-30T06:29:48", "name": "[v14,7/7] libcamera: software_isp: Refactor SoftwareIsp to use DmaBufAllocator::exportBuffers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5f98528d63df8d5fec95e0c9da3bdff582bbd04e", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21421/mbox/", "series": [ { "id": 4637, "url": "https://patchwork.libcamera.org/api/1.1/series/4637/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4637", "date": "2024-09-30T06:29:41", "name": "Add VirtualPipelineHandler", "version": 14, "mbox": "https://patchwork.libcamera.org/series/4637/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21421/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21421/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C17CAC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Sep 2024 06:34:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2473C63518;\n\tMon, 30 Sep 2024 08:34:19 +0200 (CEST)", "from mail-pf1-x436.google.com (mail-pf1-x436.google.com\n\t[IPv6:2607:f8b0:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AC046351A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 08:34:03 +0200 (CEST)", "by mail-pf1-x436.google.com with SMTP id\n\td2e1a72fcca58-7179069d029so2803730b3a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 29 Sep 2024 23:34:03 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71b265166e2sm5487671b3a.131.2024.09.29.23.33.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 29 Sep 2024 23:33:59 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"QO//nQc+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727678040; x=1728282840;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=J+YuiKlLl25i31fSj+za+H/da90SiNNuNEdDtImyhDk=;\n\tb=QO//nQc+PGqX4GZ8UdPZsrNJEFIU69mFjDKYhZodW3BVt4iFY3GHm+Q+Q/1nTQbner\n\tvlNNqUTahsmSUhGmpHGWBnMUwZhLE6FlvollOfePhDPGmVD5biJeVzlT1+QKX8x96cxh\n\tOwsSztIhJM6W4M13qoIvCXNiKRWqAw94EtO+c=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727678040; x=1728282840;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=J+YuiKlLl25i31fSj+za+H/da90SiNNuNEdDtImyhDk=;\n\tb=lL7NW8MuX2scde1GByD48ORnBpj1vYthmODjqaS3DwwWc21Ai6ZtCq8UBOc/ExfqqN\n\t6DofAc6kq5N91eRDqlHhfhViLzkHgDL+bIWtb+3bZkJn1zAQAoKfbGEvYXo5dTV0s/C2\n\tfpZylh12rDpAKGu9U5AB7DPSpXKeCOAT40H4H4EUjRDq/AbBt3oRW1bqgldHhXJv7EZa\n\t+XzzDGl3ncPe5C9L87BCe5X5wmzgIh0clZgrNfeMr2btNPaRO5R3tft/urCdJomU5pV+\n\tJR4SLfc2H+BR9CuUbcQnrnjZAtx5ZIekAdqCMfPWc1bY1ipY1PkfCSFinI0+RnM8uf90\n\tUUlg==", "X-Gm-Message-State": "AOJu0YxQdmePePqRevlqD8Ool8GXGTjWLW9Q+w3HuajgsmaMF13BLLHS\n\tWVMQU52jEXjTUrQ9tK3/xBeBOxDPgfzm/nFKAIrArufPgMzmLgfJUWKtcWJvVft/YWDZJoyR8H4\n\t=", "X-Google-Smtp-Source": "AGHT+IH9C5HYiRDO8u5uOFieQ/GKCoYmbpYsHp57ZgxaMzkutq+0/ChroRieW/JboAY+1Vzr21A36w==", "X-Received": "by 2002:a05:6a00:181d:b0:717:8eca:95 with SMTP id\n\td2e1a72fcca58-71b2604919emr19214639b3a.17.1727678040438; \n\tSun, 29 Sep 2024 23:34:00 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v14 7/7] libcamera: software_isp: Refactor SoftwareIsp to use\n\tDmaBufAllocator::exportBuffers", "Date": "Mon, 30 Sep 2024 06:29:48 +0000", "Message-ID": "<20240930063342.3014837-8-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.1.824.gd892dcdcdd-goog", "In-Reply-To": "<20240930063342.3014837-1-chenghaoyang@google.com>", "References": "<20240930063342.3014837-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As the helper function DmaBufAllocator::exportBuffers is added, we can\navoid some code duplication in SoftwareIsp as well.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 20 +-------------------\n 1 file changed, 1 insertion(+), 19 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 1140372c..3455f13a 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -255,25 +255,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n \tif (stream == nullptr)\n \t\treturn -EINVAL;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n-\t\tconst std::string name = \"frame-\" + std::to_string(i);\n-\t\tconst size_t frameSize = debayer_->frameSize();\n-\n-\t\tFrameBuffer::Plane outPlane;\n-\t\toutPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));\n-\t\tif (!outPlane.fd.isValid()) {\n-\t\t\tLOG(SoftwareIsp, Error)\n-\t\t\t\t<< \"failed to allocate a dma_buf\";\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t\toutPlane.offset = 0;\n-\t\toutPlane.length = frameSize;\n-\n-\t\tstd::vector<FrameBuffer::Plane> planes{ outPlane };\n-\t\tbuffers->emplace_back(std::make_unique<FrameBuffer>(std::move(planes)));\n-\t}\n-\n-\treturn count;\n+\treturn dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);\n }\n \n /**\n", "prefixes": [ "v14", "7/7" ] }