Patch Detail
Show a patch.
GET /api/1.1/patches/21391/?format=api
{ "id": 21391, "url": "https://patchwork.libcamera.org/api/1.1/patches/21391/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21391/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240926163141.1593026-8-chenghaoyang@google.com>", "date": "2024-09-26T16:29:56", "name": "[v13,7/7] libcamera: software_isp: Refactor SoftwareIsp to use DmaBufAllocator::exportBuffers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5f98528d63df8d5fec95e0c9da3bdff582bbd04e", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21391/mbox/", "series": [ { "id": 4632, "url": "https://patchwork.libcamera.org/api/1.1/series/4632/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4632", "date": "2024-09-26T16:29:49", "name": "Add VirtualPipelineHandler", "version": 13, "mbox": "https://patchwork.libcamera.org/series/4632/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21391/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21391/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52E6DC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Sep 2024 16:32:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8A9F63518;\n\tThu, 26 Sep 2024 18:32:05 +0200 (CEST)", "from mail-pl1-x635.google.com (mail-pl1-x635.google.com\n\t[IPv6:2607:f8b0:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B9136351B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Sep 2024 18:31:59 +0200 (CEST)", "by mail-pl1-x635.google.com with SMTP id\n\td9443c01a7336-2059204f448so11345675ad.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Sep 2024 09:31:59 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-20b37e20dffsm469035ad.170.2024.09.26.09.31.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Sep 2024 09:31:57 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"YDu0xi4U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727368318; x=1727973118;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=J+YuiKlLl25i31fSj+za+H/da90SiNNuNEdDtImyhDk=;\n\tb=YDu0xi4UuciynYSDEh+aK5/nmadBsBE0o90WcfVcdz7a5ETs/oxlAH6AC43RukitJZ\n\ttQFAYPJ9AOgUuG78un5gQMRHB0W8S1IuS/XBd3R3D32QWv8CHUhice5koZ0UIeBSlsrt\n\tUUQrZOnRs0OLQcfk5jzZHaR9lZNCv4YMpSvJg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727368318; x=1727973118;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=J+YuiKlLl25i31fSj+za+H/da90SiNNuNEdDtImyhDk=;\n\tb=jT4j99RYHSmJPUZRriQNiYZRAUHS3KKIxGjWfu1OhW3nJq3EfwRUKIZY6rASaC/doO\n\tnN8r3y1/+9jpYMptdVCOyObSQLB3nzwgJ/eYCE4j3sXNwMJqeGNHQvO9FoxgIAuScLyp\n\tWo1/1b5e5BkwlxS4PobR3qtyu4MvyhpFr97nkrMEnxPS6LPtajBAugknoVTTM2GY5dae\n\tmDgeEmkFmyu1lOsMjTbQfrJ1N+hCfUNHkNFzu+SQbdK5irUAec0KTp05ctNduDYrDaaU\n\tPSYLwlhY50TIcfXnGhu1TnX20Qqn2a0c+kuZ+jDnwvcBRLXa2vMv+YYKqphOf0eyaT6Q\n\tAHhg==", "X-Gm-Message-State": "AOJu0YxBFfwGKQ2U5kF6wkP17GJCxfnsAkSRSkRCDSl4/MjRHbntEa1T\n\tmCyC8fIRl+k5vXcm3W9dx9cicoyjDA6vb6/RnYiOISQcPMMnDIjz2v/PWvsbw5iDIkY6ANz6XMo\n\t=", "X-Google-Smtp-Source": "AGHT+IFYhib904kxbtcU20JEhDcXxIAUTu4gRGw9QDzUOyHzVp/3z2E4tvgJCCwnyO/v2F8uXDHIoQ==", "X-Received": "by 2002:a17:902:db12:b0:206:998d:6ea0 with SMTP id\n\td9443c01a7336-20b37489283mr4159965ad.33.1727368317814; \n\tThu, 26 Sep 2024 09:31:57 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v13 7/7] libcamera: software_isp: Refactor SoftwareIsp to use\n\tDmaBufAllocator::exportBuffers", "Date": "Thu, 26 Sep 2024 16:29:56 +0000", "Message-ID": "<20240926163141.1593026-8-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.1.824.gd892dcdcdd-goog", "In-Reply-To": "<20240926163141.1593026-1-chenghaoyang@google.com>", "References": "<20240926163141.1593026-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As the helper function DmaBufAllocator::exportBuffers is added, we can\navoid some code duplication in SoftwareIsp as well.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 20 +-------------------\n 1 file changed, 1 insertion(+), 19 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 1140372c..3455f13a 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -255,25 +255,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n \tif (stream == nullptr)\n \t\treturn -EINVAL;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n-\t\tconst std::string name = \"frame-\" + std::to_string(i);\n-\t\tconst size_t frameSize = debayer_->frameSize();\n-\n-\t\tFrameBuffer::Plane outPlane;\n-\t\toutPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));\n-\t\tif (!outPlane.fd.isValid()) {\n-\t\t\tLOG(SoftwareIsp, Error)\n-\t\t\t\t<< \"failed to allocate a dma_buf\";\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t\toutPlane.offset = 0;\n-\t\toutPlane.length = frameSize;\n-\n-\t\tstd::vector<FrameBuffer::Plane> planes{ outPlane };\n-\t\tbuffers->emplace_back(std::make_unique<FrameBuffer>(std::move(planes)));\n-\t}\n-\n-\treturn count;\n+\treturn dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);\n }\n \n /**\n", "prefixes": [ "v13", "7/7" ] }