Patch Detail
Show a patch.
GET /api/1.1/patches/21375/?format=api
{ "id": 21375, "url": "https://patchwork.libcamera.org/api/1.1/patches/21375/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21375/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240926002427.27703-1-laurent.pinchart@ideasonboard.com>", "date": "2024-09-26T00:24:27", "name": "libcamera: controls: Handle enum values without a cast", "commit_ref": "e6da224926b0d18dc4ad814843f2561e4e16a027", "pull_url": null, "state": "accepted", "archived": false, "hash": "c65fc7a544ce38ecca0858469f9257d446735617", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21375/mbox/", "series": [ { "id": 4628, "url": "https://patchwork.libcamera.org/api/1.1/series/4628/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4628", "date": "2024-09-26T00:24:27", "name": "libcamera: controls: Handle enum values without a cast", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4628/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21375/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21375/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89287C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Sep 2024 00:24:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 373956350E;\n\tThu, 26 Sep 2024 02:24:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DA72634FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Sep 2024 02:24:29 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DEC3169;\n\tThu, 26 Sep 2024 02:23:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TGWlrpxs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727310181;\n\tbh=dwRd3fdu1qyXuryVrqVtIC2yGupFz63B18yPfSsqySM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TGWlrpxsmKpVSwRySGGuK2LuefbeRSBA/7J/Xx+u0B+pWjv1Ydp9Ear4UroRr3YXE\n\tZ3KbATcX1Cw0HfkAjd6JS03NBV1bh7Q0HLNWHKH9bcSVcsr46wVpwbENwZ4XCjFnPc\n\tKD3Fo6YXnw/pb8mknVmMoYQnG1T2Kv9eRKl1T8/k=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Cl=C3=A1udio_Paulo?= <claudio.paulo@makewise.pt>", "Subject": "[PATCH] libcamera: controls: Handle enum values without a cast", "Date": "Thu, 26 Sep 2024 03:24:27 +0300", "Message-ID": "<20240926002427.27703-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When constructing a ControlValue from an enum value, an explicit cast to\nint32_t is needed as we use int32_t as the underlying type for all\nenumerated controls. This makes users of ControlValue more complex. To\nsimplify them, specialize the control_type template for enum types, to\nsupport construction of ControlValue directly without a cast.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/controls.h | 6 +++++-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 2 files changed, 6 insertions(+), 2 deletions(-)\n\n\nbase-commit: f2088eb91fd6477b152233b9031cb115ca1ae824", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 25f67ed948a3..c5131870d402 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -39,7 +39,7 @@ enum ControlType {\n \n namespace details {\n \n-template<typename T>\n+template<typename T, typename = std::void_t<>>\n struct control_type {\n };\n \n@@ -102,6 +102,10 @@ struct control_type<Span<T, N>> : public control_type<std::remove_cv_t<T>> {\n \tstatic constexpr std::size_t size = N;\n };\n \n+template<typename T>\n+struct control_type<T, std::enable_if_t<std::is_enum_v<T>>> : public control_type<int32_t> {\n+};\n+\n } /* namespace details */\n \n class ControlValue\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 430aa902eec8..29d3c6c194c1 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -958,7 +958,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)\n \t\tvalues.reserve(testPatternModes.size());\n \n \t\tfor (auto pattern : testPatternModes)\n-\t\t\tvalues.emplace_back(static_cast<int32_t>(pattern));\n+\t\t\tvalues.emplace_back(pattern);\n \n \t\tcontrols[&controls::draft::TestPatternMode] = ControlInfo(values);\n \t}\n", "prefixes": [] }