Patch Detail
Show a patch.
GET /api/1.1/patches/21303/?format=api
{ "id": 21303, "url": "https://patchwork.libcamera.org/api/1.1/patches/21303/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21303/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240920133941.90629-9-stefan.klug@ideasonboard.com>", "date": "2024-09-20T13:39:23", "name": "[v3,8/9] ipa: rkisp1: Add sensor info to context", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6674294efcce4dbb41f73dca261adbe7bcb1c91a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21303/mbox/", "series": [ { "id": 4609, "url": "https://patchwork.libcamera.org/api/1.1/series/4609/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4609", "date": "2024-09-20T13:39:15", "name": "Implement polynomial lsc support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4609/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21303/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21303/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EEF9C32D5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Sep 2024 13:40:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC7F06350C;\n\tFri, 20 Sep 2024 15:40:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94D93634F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Sep 2024 15:40:08 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:8ade:938d:48b1:cede])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A27D7564;\n\tFri, 20 Sep 2024 15:38:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VUvSVtzU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726839524;\n\tbh=l8JxKxg5cXsAGckCHrm3ubeCGuSAi+tlJq2ir6CjCHE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VUvSVtzU6O28rZn1flaiMxDDS1g7MKv30kmmdA5fAgZB5qnc5UREFUm6sTaUtiXf0\n\t5dXz5DP1GQ3YeN4a5BoE33qCLcewP7gT5W1EwVTdSDP5AsKE+15serRrE60G8qmxGt\n\tARgoyhjU4fg58LFVJ5vr3/9Ose6g/+MU7lME8jf0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v3 8/9] ipa: rkisp1: Add sensor info to context", "Date": "Fri, 20 Sep 2024 15:39:23 +0200", "Message-ID": "<20240920133941.90629-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240920133941.90629-1-stefan.klug@ideasonboard.com>", "References": "<20240920133941.90629-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the LSC algorithm to dynamically calculate the LSC tables based on\nthe sensor size and the crop rectangle it needs access to that data.\nProvide access to it by adding the sensorInfo object to the context.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Collected tags\n- Added documentation\n---\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 4 +++-\n 3 files changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex 730a55b4465a..14d0c02a2b32 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -424,6 +424,9 @@ namespace libcamera::ipa::rkisp1 {\n * \\var IPAContext::hw\n * \\brief RkISP1 version-specific hardware parameters\n *\n+ * \\var IPAContext::sensorInfo\n+ * \\brief The IPA session sensorInfo, immutable during the session\n+ *\n * \\var IPAContext::configuration\n * \\brief The IPA session configuration, immutable during the session\n *\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 3af2774a7fc8..e274d9b01e1c 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -17,6 +17,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n #include <libcamera/geometry.h>\n+#include <libcamera/ipa/core_ipa_interface.h>\n \n #include <libipa/camera_sensor_helper.h>\n #include <libipa/fc_queue.h>\n@@ -180,6 +181,7 @@ struct IPAFrameContext : public FrameContext {\n \n struct IPAContext {\n \tconst IPAHwSettings *hw;\n+\tIPACameraSensorInfo sensorInfo;\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 78d2c375d6dc..9e161cabdea4 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -124,7 +124,7 @@ const ControlInfoMap::Map rkisp1Controls{\n } /* namespace */\n \n IPARkISP1::IPARkISP1()\n-\t: context_({ {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n+\t: context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n {\n }\n \n@@ -158,6 +158,8 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \n \tLOG(IPARkISP1, Debug) << \"Hardware revision is \" << hwRevision;\n \n+\tcontext_.sensorInfo = sensorInfo;\n+\n \tcontext_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel);\n \tif (!context_.camHelper) {\n \t\tLOG(IPARkISP1, Error)\n", "prefixes": [ "v3", "8/9" ] }